Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Poosa, Karthik" <karthik.poosa@intel.com>
To: Sk Anirban <sk.anirban@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <anshuman.gupta@intel.com>, <badal.nilawar@intel.com>,
	<riana.tauro@intel.com>, <raag.jadav@intel.com>,
	<soham.purkait@intel.com>, <mallesh.koujalagi@intel.com>
Subject: Re: [PATCH] tests/intel/i915_pm_rc6_residency: make residency ratio tolerance symmetric
Date: Mon, 5 Oct 2026 12:22:23 +0530	[thread overview]
Message-ID: <c20b0a62-82a1-4efb-b76b-dd17f8fcdeb5@intel.com> (raw)
In-Reply-To: <20260929172810.2077612-2-sk.anirban@intel.com>


On 29-09-2026 22:58, Sk Anirban wrote:
> Bump the upper ratio bound from 1.05 to 1.1 so residency_accuracy()
> allows the same ±10% margin on both sides of the expected duration.
>
> Closes: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/17049
> Signed-off-by: Sk Anirban <sk.anirban@intel.com>
> ---
>   tests/intel/i915_pm_rc6_residency.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/i915_pm_rc6_residency.c b/tests/intel/i915_pm_rc6_residency.c
> index 346796fb2..80c102e31 100644
> --- a/tests/intel/i915_pm_rc6_residency.c
> +++ b/tests/intel/i915_pm_rc6_residency.c
> @@ -112,7 +112,7 @@ static void residency_accuracy(unsigned int diff,
>   
>   	igt_info("Residency in %s or deeper state: %u ms (sleep duration %u ms) (%.1f%% of expected duration)\n",
>   		 name_of_rc6_residency, diff, duration, 100*ratio);
> -	igt_assert_f(ratio > 0.9 && ratio < 1.05,
> +	igt_assert_f(ratio > 0.9 && ratio < 1.1,

Looks fine,

but what is the reason upper bound was different previously ?

>   		     "Sysfs RC6 residency counter is inaccurate.\n");
>   }
>   

      parent reply	other threads:[~2026-10-05  6:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-29 17:28 [PATCH] tests/intel/i915_pm_rc6_residency: make residency ratio tolerance symmetric Sk Anirban
2026-09-29 23:18 ` ✓ i915.CI.BAT: success for " Patchwork
2026-09-30  0:29 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-30  6:41 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-09-30 11:15 ` ✗ i915.CI.Full: " Patchwork
2026-10-05  6:52 ` Poosa, Karthik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20b0a62-82a1-4efb-b76b-dd17f8fcdeb5@intel.com \
    --to=karthik.poosa@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=sk.anirban@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox