From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t 3/5] lib/kms: Drop igt_display_init
Date: Mon, 26 Nov 2018 13:37:03 -0800 [thread overview]
Message-ID: <c42be249-59d9-ab7b-8e8d-5cc4aa3959d8@intel.com> (raw)
In-Reply-To: <20181122093700.31211-3-daniel.vetter@ffwll.ch>
On 22/11/18 01:36, Daniel Vetter wrote:
> If you need the high-level functions, then you probably need a
> full display. Unexport the non-requiring version, and adjust the
> documentation. This also gives us proper docs for the recently
> added igt_display_require.
I actually liked having init and require to be separate. Are there no
negative test cases that might play-around with a failing init?
other than that the series LGTM but you might want someone to look at
[2/5] in details,
Acked-By: Antonio Argenziano
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2018-11-26 21:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-22 9:36 [igt-dev] [PATCH i-g-t 1/5] tests/debugfs: use igt_display_require Daniel Vetter
2018-11-22 9:36 ` [igt-dev] [PATCH i-g-t 2/5] tests: Use igt_display_require Daniel Vetter
2018-11-22 9:36 ` [igt-dev] [PATCH i-g-t 3/5] lib/kms: Drop igt_display_init Daniel Vetter
2018-11-26 21:37 ` Antonio Argenziano [this message]
2018-11-27 8:46 ` Daniel Vetter
2018-11-22 9:36 ` [igt-dev] [PATCH i-g-t 4/5] lib/kms: warn if we commit without outputs Daniel Vetter
2018-11-26 12:33 ` Arkadiusz Hiler
2018-11-22 9:37 ` [igt-dev] [PATCH i-g-t 5/5] lib/kms: Enable outputs by default in igt_require_display Daniel Vetter
2018-11-29 17:18 ` Daniel Vetter
2018-11-23 11:53 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/5] tests/debugfs: use igt_display_require Patchwork
2018-11-23 13:18 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c42be249-59d9-ab7b-8e8d-5cc4aa3959d8@intel.com \
--to=antonio.argenziano@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox