Re: [PATCH i-g-t] tests/intel/kms_psr2_sf: Add eDP check for Early Transport

["Naladala, Ramanaidu" <ramanaidu.naladala@intel.com>]

Hi Jeeavn,


On 9/19/2024 10:54 PM, Jeevan B wrote:
> On current platforms early transport is supported on eDP only
> so avoiding assert for other connector.
> 
> v2: Add checks to handle crashes and fix typo.
> 
> Signed-off-by: Jeevan B <jeevan.b@intel.com>
> ---
>   tests/intel/kms_psr2_sf.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c
> index a9be1a1ec..ca729d558 100644
> --- a/tests/intel/kms_psr2_sf.c
> +++ b/tests/intel/kms_psr2_sf.c
> @@ -935,7 +935,9 @@ static void run(data_t *data)
>   							  data->pipe),
>   							  "FBC still disabled\n");
>   
> -	if (data->et_flag)
> +	/* TODO: Enable this check if other connectors support Early Transport */
> +	if (data->et_flag && data->output != NULL &&
> +	    data->output->config.connector->connector_type == DRM_MODE_CONNECTOR_eDP)
>   		igt_assert_f(early_transport_check(data->debugfs_fd),
>   			     "Early Trasport Disbaled\n");
> 

LGTM,
Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>