From: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>,
IGT development <igt-dev@lists.freedesktop.org>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const
Date: Wed, 5 Dec 2018 14:28:08 +0200 [thread overview]
Message-ID: <c4764b84-0efc-3f6f-cbaf-87123c7b8acc@gmail.com> (raw)
In-Reply-To: <20181204122215.8635-1-daniel.vetter@ffwll.ch>
On 4.12.2018 14.22, Daniel Vetter wrote:
> My gcc is unhappy otherwise:
>
> [191/829] Compiling C object 'tests/te...otation_crc@exe/kms_rotation_crc.c.o'.
> ../tests/kms_rotation_crc.c: In function ‘test_multi_plane_rotation’:
> ../tests/kms_rotation_crc.c:497:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> const static struct {
> ^~~~~
> ../tests/kms_rotation_crc.c:524:2: warning: ‘static’ is not at beginning of declaration [-Wold-style-declaration]
> const static uint32_t formatlist[] = {DRM_FORMAT_RGB565,
> ^~~~~
>
> Fixes
Look like autotools didn't use same flags for gcc as to those meson
does. At least for me autotools build doesn't give any warnings but now
saw those from meson.
Thanks for fixing it for me.
>
> commit 14c1b132c8f829637c55fb071a9a2e5ce00e7ed8
> Author: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> Date: Fri Nov 30 15:34:36 2018 +0200
>
> tests/kms_rotation_crc: Add multi plane tests
>
> Cc: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com
> Cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> tests/kms_rotation_crc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
> index 369936f94528..05349dab5f79 100644
> --- a/tests/kms_rotation_crc.c
> +++ b/tests/kms_rotation_crc.c
> @@ -494,7 +494,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
> struct p_struct *oldplanes;
> drmModeModeInfo *mode;
>
> - const static struct {
> + static const struct {
> igt_rotation_t rotation;
> float_t width;
> float_t height;
> @@ -521,7 +521,7 @@ static void test_multi_plane_rotation(data_t *data, enum pipe pipe)
> * TODO:
> * Built support for NV12 here.
> */
> - const static uint32_t formatlist[] = {DRM_FORMAT_RGB565,
> + static const uint32_t formatlist[] = {DRM_FORMAT_RGB565,
> DRM_FORMAT_XRGB8888};
>
> for_each_valid_output_on_pipe(display, pipe, output) {
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-12-05 12:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-04 12:22 [igt-dev] [PATCH i-g-t] tests/kms_rotation_crc: static before const Daniel Vetter
2018-12-04 12:51 ` Petri Latvala
2018-12-04 13:43 ` Daniel Vetter
2018-12-04 13:50 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-04 20:23 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-05 12:28 ` Juha-Pekka Heikkila [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4764b84-0efc-3f6f-cbaf-87123c7b8acc@gmail.com \
--to=juhapekka.heikkila@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox