From: "Modem, Bhanuprakash" <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, ankit.k.nautiyal@intel.com,
mchehab@kernel.org, kamil.konieczny@linux.intel.com,
zbigniew.kempczynski@intel.com, karthik.b.s@intel.com,
swati2.sharma@intel.com
Subject: Re: [igt-dev] [i-g-t 4/6] Revert "lib/igt_kms: Cache xe_device info for kms tests"
Date: Tue, 9 May 2023 12:52:17 +0530 [thread overview]
Message-ID: <c4b3fee0-6ac9-25ce-de58-886e529bbb2a@intel.com> (raw)
In-Reply-To: <20230504045726.2954788-5-bhanuprakash.modem@intel.com>
On Thu-04-05-2023 10:27 am, Bhanuprakash Modem wrote:
> As this logic is moved to driver open/close level, this is
> redundant, hence revert this logic.
>
> This reverts commit 3e049d7c5048c8e4d0b0cfc22afca18e9e897e9a.
>
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
Cc: Janga Rahul Kumar <janga.rahul.kumar@intel.com>
> ---
> lib/igt_kms.c | 8 --------
> 1 file changed, 8 deletions(-)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index e085e234a..9125a8ccb 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -59,7 +59,6 @@
> #include "igt_device.h"
> #include "igt_sysfs.h"
> #include "sw_sync.h"
> -#include "xe/xe_query.h"
> #ifdef HAVE_CHAMELIUM
> #include "igt_chamelium.h"
> #endif
> @@ -2639,9 +2638,6 @@ void igt_display_require(igt_display_t *display, int drm_fd)
> }
> #endif
>
> - if (is_xe_device(drm_fd))
> - xe_device_get(drm_fd);
> -
> display->n_pipes = IGT_MAX_PIPES;
> display->pipes = calloc(sizeof(igt_pipe_t), display->n_pipes);
> igt_assert_f(display->pipes, "Failed to allocate memory for %d pipes\n", display->n_pipes);
> @@ -2978,10 +2974,6 @@ static void igt_output_fini(igt_output_t *output)
> void igt_display_fini(igt_display_t *display)
> {
> int i;
> - int drm_fd = display->drm_fd;
> -
> - if (is_xe_device(drm_fd))
> - xe_device_put(drm_fd);
>
> for (i = 0; i < display->n_planes; ++i) {
> igt_plane_t *plane = &display->planes[i];
next prev parent reply other threads:[~2023-05-09 7:22 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-04 4:57 [igt-dev] [i-g-t 0/6] XE test cleanup to handle xe_device Bhanuprakash Modem
2023-05-04 4:57 ` [igt-dev] [i-g-t 1/6] lib: Interface to close the drm fd Bhanuprakash Modem
2023-05-09 7:21 ` Modem, Bhanuprakash
2023-05-09 10:30 ` Kamil Konieczny
2023-05-16 13:17 ` Modem, Bhanuprakash
2023-05-18 18:35 ` Zbigniew Kempczyński
2023-05-04 4:57 ` [igt-dev] [i-g-t 2/6] lib: Cache xe_device at driver open/close level Bhanuprakash Modem
2023-05-09 7:21 ` Modem, Bhanuprakash
2023-05-09 9:31 ` Kamil Konieczny
2023-05-11 5:30 ` Zbigniew Kempczyński
2023-05-16 13:41 ` Modem, Bhanuprakash
2023-05-04 4:57 ` [igt-dev] [i-g-t 3/6] lib/xe/xe_query: Add xe_config() interface Bhanuprakash Modem
2023-05-09 7:21 ` Modem, Bhanuprakash
2023-05-09 13:31 ` Kamil Konieczny
2023-05-04 4:57 ` [igt-dev] [i-g-t 4/6] Revert "lib/igt_kms: Cache xe_device info for kms tests" Bhanuprakash Modem
2023-05-09 7:22 ` Modem, Bhanuprakash [this message]
2023-05-09 13:47 ` Kamil Konieczny
2023-05-04 4:57 ` [igt-dev] [i-g-t 5/6] tests: Use drm_close_driver() to close the drm fd Bhanuprakash Modem
2023-05-04 12:07 ` [igt-dev] [i-g-t V2 " Bhanuprakash Modem
2023-05-09 10:24 ` Kamil Konieczny
2023-05-04 4:57 ` [igt-dev] [i-g-t 6/6] tests: Drop xe_device get/put from test level Bhanuprakash Modem
2023-05-09 7:22 ` Modem, Bhanuprakash
2023-05-09 12:26 ` Kamil Konieczny
2023-05-04 5:38 ` [igt-dev] ✗ Fi.CI.BAT: failure for XE test cleanup to handle xe_device Patchwork
2023-05-04 11:29 ` [igt-dev] ✗ GitLab.Pipeline: warning for XE test cleanup to handle xe_device (rev2) Patchwork
2023-05-04 12:03 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
2023-05-04 15:36 ` [igt-dev] ✓ Fi.CI.BAT: success for XE test cleanup to handle xe_device (rev3) Patchwork
2023-05-05 4:22 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2023-05-09 5:05 ` [igt-dev] [i-g-t 0/6] XE test cleanup to handle xe_device Modem, Bhanuprakash
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4b3fee0-6ac9-25ce-de58-886e529bbb2a@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=ankit.k.nautiyal@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=karthik.b.s@intel.com \
--cc=mchehab@kernel.org \
--cc=swati2.sharma@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox