From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2056.outbound.protection.outlook.com [40.107.94.56]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9E16B10E065 for ; Tue, 20 Jun 2023 20:37:43 +0000 (UTC) Message-ID: Date: Tue, 20 Jun 2023 14:37:37 -0600 To: Hersen Wu , igt-dev@lists.freedesktop.org, rodrigo.siqueira@amd.com, aurabindo.pillai@amd.com, stylon.wang@amd.com, hamza.mahfooz@amd.com References: <20230620191603.94265-1-hersenxs.wu@amd.com> Content-Language: en-US From: Alex Hung In-Reply-To: <20230620191603.94265-1-hersenxs.wu@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] [i-g-t] tests/amdgpu/amd_color: fix sub test crtc-lut-accuracy failure List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Reviewed-by: Alex Hung On 2023-06-20 13:16, Hersen Wu wrote: > Add reading degamma_lut_size and regamma_lut_size from Linux kernel > within test_crtc_lut_accuracy. Test fails within lut_init when > lut_size equals to zero. > > Signed-off-by: Hersen Wu > --- > tests/amdgpu/amd_color.c | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tests/amdgpu/amd_color.c b/tests/amdgpu/amd_color.c > index 9eed1da38..34002ed88 100644 > --- a/tests/amdgpu/amd_color.c > +++ b/tests/amdgpu/amd_color.c > @@ -53,7 +53,7 @@ typedef struct data { > > static void lut_init(lut_t *lut, uint32_t size) > { > - igt_assert(size > 0); > + igt_assert_lt(0, size); > > lut->size = size; > lut->data = malloc(size * sizeof(struct drm_color_lut)); > @@ -229,7 +229,6 @@ static void test_crtc_linear_degamma(data_t *data) > > data->degamma_lut_size = > igt_pipe_obj_get_prop(data->pipe, IGT_CRTC_DEGAMMA_LUT_SIZE); > - igt_assert_lt(0, data->degamma_lut_size); > > lut_init(&lut_linear, data->degamma_lut_size); > lut_gen_linear(&lut_linear, 0xffff); > @@ -277,7 +276,6 @@ static void test_crtc_linear_regamma(data_t *data) > > data->regamma_lut_size = > igt_pipe_obj_get_prop(data->pipe, IGT_CRTC_GAMMA_LUT_SIZE); > - igt_assert_lt(0, data->regamma_lut_size); > > lut_init(&lut_linear, data->regamma_lut_size); > lut_gen_linear(&lut_linear, 0xffff); > @@ -340,6 +338,12 @@ static void test_crtc_lut_accuracy(data_t *data) > igt_require(igt_pipe_obj_has_prop(data->pipe, IGT_CRTC_DEGAMMA_LUT)); > igt_require(igt_pipe_obj_has_prop(data->pipe, IGT_CRTC_GAMMA_LUT)); > > + data->degamma_lut_size = > + igt_pipe_obj_get_prop(data->pipe, IGT_CRTC_DEGAMMA_LUT_SIZE); > + > + data->regamma_lut_size = > + igt_pipe_obj_get_prop(data->pipe, IGT_CRTC_GAMMA_LUT_SIZE); > + > lut_init(&lut_degamma, data->degamma_lut_size); > lut_gen_degamma_srgb(&lut_degamma, 0xffff); >