Re: [igt-dev] [PATCH i-g-t] tests/kms_psr2_su: add biplanar selective update tests

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2021-10-26 at 17:13 +0000, Souza, Jose wrote:
> > -if (data.op == FRONTBUFFER &&
> > -    intel_display_ver(intel_get_drm_devid(data.drm_fd)) >= 12) {
> > -/*
> > - * FIXME: Display 12+ platforms now have PSR2
> > - * selective fetch enabled by default but we
> > - * still can't properly handle frontbuffer
> > - * rendering, so right it does full frame
> > - * fetches at every frontbuffer rendering.
> > - * So it is expected that this test will fail
> > - * in display 12+ platform fow now.
> > - */
> > -igt_skip("PSR2 selective fetch is doing full frame fetches for
> > frontbuffer rendering\n");
> 
> Is the above fixed? I don't think so.
> Even if is, this change needs to go into a separated patch.

This sneaked in when rebasing. Thank you for pointing it out. New
version sent out.

> 
> > +const uint32_t *format = formats[data.op];
> > +
> > +while (*format != DRM_FORMAT_INVALID) {
> > +data.format = *format;
> > +igt_describe("Test that selective update works when screen
> > changes");
> > +igt_subtest_f("%s_%s", op_str(data.op),
> > igt_format_str(data.format)) {
> 
> CI folks needs to be aware and ack tests renames.
> 
> CC: Petri Latvala <petri.latvala@intel.com>
> 
> Othan than above lgtm.
> 
> > +prepare(&data);
> > +run(&data);
> > +cleanup(&data);
> >  }
> > -
> > -prepare(&data);
> > -run(&data);
> > -cleanup(&data);
> > +format++;
> >  }
> >  }
> > 

BR,

Jouni Högander