public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Karthik B S <karthik.b.s@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_color: Skip the test early if no outputs found
Date: Fri, 13 Feb 2026 01:26:19 +0530	[thread overview]
Message-ID: <c67cd5d6-f486-4f2e-890c-e31ef17a0bcd@intel.com> (raw)
In-Reply-To: <20260212031816.896622-1-karthik.b.s@intel.com>

Hi Karthik,

On 12-02-2026 08:48 am, Karthik B S wrote:
> Add igt_display_require_output call in the initial test fixture to avoid
> skipping the subtest down the line if output is not found.
>
> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
> ---
>   tests/kms_color.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tests/kms_color.c b/tests/kms_color.c
> index a50793651..aea7e008f 100644
> --- a/tests/kms_color.c
> +++ b/tests/kms_color.c
> @@ -1168,6 +1168,7 @@ int igt_main()
>   		kmstest_set_vt_graphics_mode();
>   
>   		igt_display_require(&data.display, data.drm_fd);
> +		igt_display_require_output(&data.display);
This looks like wrong place for this, there are negative tests which 
doesn't require o/p.
>   	}
>   
>   	igt_subtest_group()

  parent reply	other threads:[~2026-02-12 19:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-12  3:18 [PATCH i-g-t] tests/kms_color: Skip the test early if no outputs found Karthik B S
2026-02-12  3:53 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-02-12  4:08 ` ✗ i915.CI.BAT: failure " Patchwork
2026-02-12 14:48 ` [PATCH i-g-t] " Kamil Konieczny
2026-02-12 19:56 ` Sharma, Swati2 [this message]
2026-02-13  8:28 ` ✓ Xe.CI.FULL: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c67cd5d6-f486-4f2e-890c-e31ef17a0bcd@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=karthik.b.s@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox