Re: [PATCH i-g-t 1/2] lib/igt_kms: Add helper to get non-joiner mode

["Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>]

Hi Pranay,

On 23-02-2026 15:04, Pranay Samala wrote:
> Add igt_get_non_joiner_mode() helper function to find a suitable
> display mode from an output that does not require Big Joiner or
> Ultra Joiner support. This is useful for tests that want to avoid
> joiner modes and use a single pipe configuration.
> 
> The function returns a pointer to the mode if found, or NULL if
> all modes require joiner support.
> 
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
>   lib/igt_kms.c | 31 +++++++++++++++++++++++++++++++
>   lib/igt_kms.h |  1 +
>   2 files changed, 32 insertions(+)
> 
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 5c4879604..107db512d 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -6997,6 +6997,37 @@ bool ultrajoiner_mode_found(int drm_fd, drmModeConnector *connector,
>   	return found;
>   }
>   
> +/**
> + * igt_get_non_joiner_mode:
> + * @drm_fd: drm file descriptor
> + * @output: pointer to the output structure
> + *
> + * Finds the display mode from the output that does not require
> + * Big Joiner or Ultra Joiner.
> + *
> + * Returns: Pointer to non-joiner mode, or NULL if not found.
> + */
> +drmModeModeInfo *igt_get_non_joiner_mode(int drm_fd, igt_output_t *output)
> +{
> +	drmModeConnector *connector;
> +	int max_dotclock;
> +
> +	connector = output->config.connector;
> +	max_dotclock = igt_get_max_dotclock(drm_fd);
> +
> +	for (int i = 0; i < connector->count_modes; i++) {
> +		drmModeModeInfo *current_mode = &connector->modes[i];
> +
> +		/* Check if mode requires joiner */
> +		if (!igt_bigjoiner_possible(drm_fd, current_mode, max_dotclock) &&
> +		    !igt_ultrajoiner_possible(drm_fd, current_mode, max_dotclock)) {
> +			return current_mode;
> +		}
Consider moving this to a function mode_nees_joiner() or something,
Otherwise LGTM.
Reviewed-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>

> +	}
> +
> +	return NULL;
> +}
> +
>   /**
>    * is_joiner_mode:
>    * @drm_fd: drm file descriptor
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index dedc3f880..9a95e8e0a 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1285,6 +1285,7 @@ bool igt_is_joiner_enabled_for_pipe(int drmfd, enum pipe pipe);
>   bool igt_ultrajoiner_possible(int drmfd, drmModeModeInfo *mode, int max_dotclock);
>   bool ultrajoiner_mode_found(int drm_fd, drmModeConnector *connector,
>   			  int max_dotclock, drmModeModeInfo *mode);
> +drmModeModeInfo *igt_get_non_joiner_mode(int drm_fd, igt_output_t *output);
>   bool igt_has_force_joiner_debugfs(int drmfd, char *conn_name);
>   bool is_joiner_mode(int drm_fd, igt_output_t *output);
>   bool igt_check_force_joiner_status(int drmfd, char *connector_name);