Re: [PATCH i-g-t] lib/gpu_cmds: be ready to use xe2 gpgpu fill on newer platforms

["Manszewski, Christoph" <christoph.manszewski@intel.com>]

Hi Dominik,

On 25.04.2024 14:13, Dominik Grzegorzek wrote:
> Doing xe2 gpgpu pipeline implementation we mostly taken into account
> possibility of reusing the implementation for future platforms.
> But not everywhere. Make it common.
> 
> Signed-off-by: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> ---
>   lib/gpu_cmds.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/gpu_cmds.c b/lib/gpu_cmds.c
> index f37e725e7..40522d58e 100644
> --- a/lib/gpu_cmds.c
> +++ b/lib/gpu_cmds.c
> @@ -1030,7 +1030,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb)
>   	intel_bb_out(ibb, 0);
>   
>   	/* stateless data port */
> -	tmp = intel_graphics_ver(ibb->devid) == IP_VER(20, 0) ? 0 : BASE_ADDRESS_MODIFY;
> +	tmp = intel_graphics_ver(ibb->devid) >= IP_VER(20, 0) ? 0 : BASE_ADDRESS_MODIFY;
>   	intel_bb_out(ibb, 0 | tmp);                  //dw3
>   
>   	/* surface */
> @@ -1056,7 +1056,7 @@ xehp_emit_state_base_address(struct intel_bb *ibb)
>   	/* dynamic state buffer size */
>   	intel_bb_out(ibb, 1 << 12 | 1);                             //dw13
>   	/* indirect object buffer size */
> -	if (intel_graphics_ver(ibb->devid) == IP_VER(20, 0))	    //dw14
> +	if (intel_graphics_ver(ibb->devid) >= IP_VER(20, 0))	    //dw14

nice catch, should be like this from the start.

Acked-by: Christoph Manszewski <christoph.manszewski@intel.com>

Christoph

>   		intel_bb_out(ibb, 0);
>   	else
>   		intel_bb_out(ibb, 0xfffff000 | 1);