From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id C509310E51B for ; Fri, 18 Aug 2023 13:40:37 +0000 (UTC) Message-ID: Date: Fri, 18 Aug 2023 15:40:28 +0200 Content-Language: en-US To: References: <20230818051916.28272-1-sai.gowtham.ch@intel.com> <20230818051916.28272-2-sai.gowtham.ch@intel.com> From: Karolina Stolarek In-Reply-To: <20230818051916.28272-2-sai.gowtham.ch@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/intel_reg: Add copy commands in the lib List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Hi Sai, On 18.08.2023 07:19, sai.gowtham.ch@intel.com wrote: > From: Sai Gowtham Ch > > Add memory copy and set commands to the lib. > > Signed-off-by: Sai Gowtham Ch > --- > lib/intel_mocs.h | 2 ++ > lib/intel_reg.h | 4 ++++ > 2 files changed, 6 insertions(+) > > diff --git a/lib/intel_mocs.h b/lib/intel_mocs.h > index 255eac0ff..4f4cf53e0 100644 > --- a/lib/intel_mocs.h > +++ b/lib/intel_mocs.h > @@ -6,6 +6,8 @@ > #ifndef _INTEL_MOCS_H > #define _INTEL_MOCS_H > > +#define MEM_COPY_MOCS_SHIFT 25 > + From what I can see, this flag is only used in the xe_copy_basic test. Would it be possible to keep it local for the time being? Many thanks, Karolina > uint8_t intel_get_wb_mocs(int fd); > uint8_t intel_get_uc_mocs(int fd); > > diff --git a/lib/intel_reg.h b/lib/intel_reg.h > index 3bf3676dc..322aec9fd 100644 > --- a/lib/intel_reg.h > +++ b/lib/intel_reg.h > @@ -2564,6 +2564,10 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. > > #define XY_FAST_COLOR_BLT ((0x2<<29)|(0x44<<22)|0xe) > > +/* RAW memory commands */ > +#define MEM_COPY_CMD ((0x2 << 29)|(0x5a << 22)|0x8) > +#define MEM_SET_CMD ((0x2 << 29)|(0x5b << 22)|0x5) > + > #define XY_FAST_COPY_BLT ((2<<29)|(0x42<<22)|0x8) > /* dword 0 */ > #define XY_FAST_COPY_SRC_TILING_LINEAR (0 << 20)