From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang
Date: Thu, 21 Feb 2019 08:08:04 -0800 [thread overview]
Message-ID: <c904bd88-a4d1-f474-6bb9-e88c1e1587eb@intel.com> (raw)
In-Reply-To: <20190221101944.19711-1-chris@chris-wilson.co.uk>
On 21/02/19 02:19, Chris Wilson wrote:
> To control hang detection, we manipulate the i915.reset module
> parameter. However, to be nice we should SKIP if we cannot modify the
> parameter as opposed to outright FAILing.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=108891
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> lib/igt_gt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 646696727..c98a7553b 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -176,8 +176,8 @@ igt_hang_t igt_allow_hang(int fd, unsigned ctx, unsigned flags)
> if (!igt_check_boolean_env_var("IGT_HANG_WITHOUT_RESET", false))
> igt_require(has_gpu_reset(fd));
>
> - igt_assert(igt_sysfs_set_parameter
> - (fd, "reset", "%d", INT_MAX /* any reset method */));
> + igt_require(igt_sysfs_set_parameter
> + (fd, "reset", "%d", INT_MAX /* any reset method */));
How come we were not able to write that parameter? Isn't that sysfs
always there?
Antonio
>
> if ((flags & HANG_ALLOW_CAPTURE) == 0) {
> param.param = I915_CONTEXT_PARAM_NO_ERROR_CAPTURE;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-02-21 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-21 10:19 [igt-dev] [PATCH i-g-t 1/2] lib: Only require we have i915.reset module parameter for allow-hang Chris Wilson
2019-02-21 10:19 ` [igt-dev] [PATCH i-g-t 2/2] igt/drv_hangman: Skip if resets are disallowed Chris Wilson
2019-02-21 16:11 ` Antonio Argenziano
2019-02-21 11:42 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/2] lib: Only require we have i915.reset module parameter for allow-hang Patchwork
2019-02-21 16:08 ` Antonio Argenziano [this message]
2019-02-21 16:11 ` [igt-dev] [Intel-gfx] [PATCH i-g-t 1/2] " Chris Wilson
2019-02-21 16:16 ` Antonio Argenziano
2019-02-21 17:43 ` [igt-dev] ✓ Fi.CI.IGT: success for series starting with [i-g-t,1/2] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c904bd88-a4d1-f474-6bb9-e88c1e1587eb@intel.com \
--to=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox