From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Vinod Govindapillai <vinod.govindapillai@intel.com>,
igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com, matthew.d.roper@intel.com
Subject: Re: [PATCH i-g-t v2] tests/intel/kms_cdclk: skip cdclk tests for bmg
Date: Mon, 2 Sep 2024 18:18:18 +0530 [thread overview]
Message-ID: <c98ab43a-d327-4824-beab-ad834acfcb53@intel.com> (raw)
In-Reply-To: <20240902083232.21871-1-vinod.govindapillai@intel.com>
LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com
On 02-Sep-24 2:02 PM, Vinod Govindapillai wrote:
> As there is only one cdclk option in BMG, these cdclk tests
> which look for change in cdclk frequency when changing
> between high and low resolution mode will fail. So skip
> these tests for bmg
>
> v2: Add WA info as a comment (Matt Roper)
> fix commit header description (Swati)
>
> Acked-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
> ---
> tests/intel/kms_cdclk.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tests/intel/kms_cdclk.c b/tests/intel/kms_cdclk.c
> index 6fe6e6c3f..382b3e9d1 100644
> --- a/tests/intel/kms_cdclk.c
> +++ b/tests/intel/kms_cdclk.c
> @@ -402,6 +402,9 @@ igt_main
> "Hardware doesn't support crawling/squashing.\n");
> igt_display_require(&data.display, data.drm_fd);
> igt_display_require_output(&data.display);
> +
> + /* Wa_15015413771: Only single possible cdclk value in XE2_HPD */
> + igt_require(!IS_BATTLEMAGE(data.devid));
> }
>
> igt_describe("Plane scaling test to validate cdclk frequency change.");
next prev parent reply other threads:[~2024-09-02 12:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 8:32 [PATCH i-g-t v2] tests/intel/kms_cdclk: skip cdclk tests for bmg Vinod Govindapillai
2024-09-02 12:48 ` Sharma, Swati2 [this message]
2024-09-02 16:39 ` ✓ CI.xeBAT: success for " Patchwork
2024-09-02 16:44 ` ✓ Fi.CI.BAT: " Patchwork
2024-09-02 19:16 ` ✗ CI.xeFULL: failure " Patchwork
2024-09-03 6:29 ` Govindapillai, Vinod
2024-09-03 20:10 ` ✗ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c98ab43a-d327-4824-beab-ad834acfcb53@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
--cc=matthew.d.roper@intel.com \
--cc=vinod.govindapillai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox