From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1DFD6E5CE for ; Thu, 20 Jun 2019 16:14:40 +0000 (UTC) References: <20190620131453.10203-1-andi.shyti@intel.com> From: Tvrtko Ursulin Message-ID: Date: Thu, 20 Jun 2019 17:14:38 +0100 MIME-Version: 1.0 In-Reply-To: <20190620131453.10203-1-andi.shyti@intel.com> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v2] lib/i915: gem_engine_topology: get eb flags from engine's class:instance List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti , IGT dev Cc: Andi Shyti List-ID: Ck9uIDIwLzA2LzIwMTkgMTQ6MTQsIEFuZGkgU2h5dGkgd3JvdGU6Cj4gVGhlIGV4ZWN1dGlvbiBi dWZmZXIgZmxhZyB2YWx1ZSBoYXMgbm93IHRoZSBlbmdpbmUgaW5kZXggYXMgaXQgaXMKPiBtYXBw ZWQgaW4gdGhlIGNvbnRleHQuIFJldHJpZXZlIHRoZSBtYXBwZWQgaW5kZXggYnkgaW50ZXJyb2dh dGluZwo+IHRoZSBkcml2ZXIgc3RhcnRpbmcgZnJvbSB0aGUgY2xhc3MvaW5zdGFuY2UgdHVwbGUu Cj4gCj4gQSAiZ2VtX2NvbnRleHRfZ2V0X2ViX2ZsYWdzX2NpIiBoZWxwZXIgYWxsb3dzIHRvIGF2 b2lkIGRlY2xhcmluZwo+IGEgInN0cnVjdCBpOTE1X2VuZ2luZV9jbGFzc19pbnN0YW5jZSIgZm9y IHRoZSBwdXJwb3NlLgo+IAo+IFJldHVybiAtRUlOVkFMIGlmIHRoZSBlbmdpbmUgaXMgbm90IG1h cHBlZCBpbiB0aGUgZ2l2ZW4gY29udGV4dC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUdnJ0a28gVXJz dWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEFuZGkgU2h5 dGkgPGFuZGkuc2h5dGlAaW50ZWwuY29tPgo+IENjOiBSYW1hbGluZ2FtIEMgPHJhbWFsaW5nYW0u Y0BpbnRlbC5jb20+Cj4gLS0tCj4gVjEgLS0+IFYyIGNoYW5nZWxvZzoKPiAtLS0tLS0tLS0tLS0t LS0tLS0tLQo+IC0gcmVmYWN0b3IgdGhlIGNvZGUgdG8gYXZvaWQgaW5pdGlhbGl6aW5nIHRoZSBj b250ZXh0IGp1c3QgZm9yCj4gICAgdGhlIHB1cnBvc2Ugb2YgZ2V0dGluZyB0aGUgZXhlY3V0aW9u IGJ1ZmZlciBmbGFnICh0aGFua3MKPiAgICBUdnJ0a28pCj4gCj4gICBsaWIvaTkxNS9nZW1fZW5n aW5lX3RvcG9sb2d5LmMgfCAzMSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gICBs aWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmggfCAgNiArKysrKysKPiAgIDIgZmlsZXMgY2hh bmdlZCwgMzcgaW5zZXJ0aW9ucygrKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaTkxNS9nZW1fZW5n aW5lX3RvcG9sb2d5LmMgYi9saWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmMKPiBpbmRleCBm ZGQxYjk1MTY3MmIuLmZkNWJlMzQ5MWI4OSAxMDA2NDQKPiAtLS0gYS9saWIvaTkxNS9nZW1fZW5n aW5lX3RvcG9sb2d5LmMKPiArKysgYi9saWIvaTkxNS9nZW1fZW5naW5lX3RvcG9sb2d5LmMKPiBA QCAtMjcwLDYgKzI3MCwzNyBAQCBpbnQgZ2VtX2NvbnRleHRfbG9va3VwX2VuZ2luZShpbnQgZmQs IHVpbnQ2NF90IGVuZ2luZSwgdWludDMyX3QgY3R4X2lkLAo+ICAgCXJldHVybiAwOwo+ICAgfQo+ ICAgCj4gK2ludCBnZW1fY29udGV4dF9nZXRfZWJfZmxhZ3MoaW50IGZkLCB1aW50MzJfdCBjdHhf aWQsCj4gKwkJCSAgICAgc3RydWN0IGk5MTVfZW5naW5lX2NsYXNzX2luc3RhbmNlICpjaSkKPiAr ewo+ICsJREVGSU5FX0NPTlRFWFRfRU5HSU5FU19QQVJBTShlbmdpbmVzLCBwYXJhbSwgY3R4X2lk LCBHRU1fTUFYX0VOR0lORVMpOwo+ICsKPiArCS8qIGxlZ2FjeSBrZXJuZWxzICovCj4gKwlpZiAo Z2VtX3RvcG9sb2d5X2dldF9wYXJhbShmZCwgJnBhcmFtKSkgewo+ICsJCWNvbnN0IHN0cnVjdCBp bnRlbF9leGVjdXRpb25fZW5naW5lMiAqZTsKPiArCj4gKwkJX19mb3JfZWFjaF9zdGF0aWNfZW5n aW5lKGUpCj4gKwkJCWlmIChlLT5jbGFzcyA9PSBjaS0+ZW5naW5lX2NsYXNzICYmCj4gKwkJCSAg ICBlLT5pbnN0YW5jZSA9PSBjaS0+ZW5naW5lX2luc3RhbmNlKQo+ICsJCQkJcmV0dXJuIGUtPmZs YWdzOwo+ICsKPiArCQlyZXR1cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwkvKiBjb250ZXh0IGhh cyBubyBlbmdpbmUgbWFwcGVkICovCj4gKwlpZiAoIXBhcmFtLnNpemUpCj4gKwkJcmV0dXJuIC1F SU5WQUw7Cj4gKwo+ICsJLyogZW5naW5lIG1hcCBsb29rdXAgKi8KPiArCWZvciAoaW50IGkgPSAw OyBpIDwgcGFyYW0uc2l6ZTsgaSsrKQo+ICsJCWlmIChlbmdpbmVzLmVuZ2luZXNbaV0uZW5naW5l X2NsYXNzID09IGNpLT5lbmdpbmVfY2xhc3MgJiYKPiArCQkgICAgZW5naW5lcy5lbmdpbmVzW2ld LmVuZ2luZV9pbnN0YW5jZSA9PSBjaS0+ZW5naW5lX2luc3RhbmNlKQo+ICsJCQlyZXR1cm4gaTsK PiArCj4gKwkvKiBlbmdpbmUgaXMgbm90IG1hcHBlZCBpbiB0aGUgZ2l2ZW4gY29udGV4dCAqLwo+ ICsJcmV0dXJuIC1FSU5WQUw7Cj4gK30KCkxvb2tzIGdvb2QgdG8gbWUuLiA7KQoKPiArCj4gICB2 b2lkIGdlbV9jb250ZXh0X3NldF9hbGxfZW5naW5lcyhpbnQgZmQsIHVpbnQzMl90IGN0eCkKPiAg IHsKPiAgIAlERUZJTkVfQ09OVEVYVF9FTkdJTkVTX1BBUkFNKGVuZ2luZXMsIHBhcmFtLCBjdHgs IEdFTV9NQVhfRU5HSU5FUyk7Cj4gZGlmZiAtLWdpdCBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9w b2xvZ3kuaCBiL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaAo+IGluZGV4IDI0MTVmZDFl Mzc5Yi4uNTdiNTQ3M2JiZDVhIDEwMDY0NAo+IC0tLSBhL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9w b2xvZ3kuaAo+ICsrKyBiL2xpYi9pOTE1L2dlbV9lbmdpbmVfdG9wb2xvZ3kuaAo+IEBAIC01Myw2 ICs1MywxMiBAQCBpbnQgZ2VtX2NvbnRleHRfbG9va3VwX2VuZ2luZShpbnQgZmQsIHVpbnQ2NF90 IGVuZ2luZSwgdWludDMyX3QgY3R4X2lkLAo+ICAgCj4gICB2b2lkIGdlbV9jb250ZXh0X3NldF9h bGxfZW5naW5lcyhpbnQgZmQsIHVpbnQzMl90IGN0eCk7Cj4gICAKPiAraW50IGdlbV9jb250ZXh0 X2dldF9lYl9mbGFncyhpbnQgZmQsIHVpbnQzMl90IGN0eF9pZCwKPiArCQkJICAgICBzdHJ1Y3Qg aTkxNV9lbmdpbmVfY2xhc3NfaW5zdGFuY2UgKmNpKTsKPiArCj4gKyNkZWZpbmUgZ2VtX2NvbnRl eHRfZ2V0X2ViX2ZsYWdzX2NpKGYsIGMsIC4uLikgXAo+ICsJZ2VtX2NvbnRleHRfZ2V0X2ViX2Zs YWdzKGYsIGMsICYoKHN0cnVjdCBpOTE1X2VuZ2luZV9jbGFzc19pbnN0YW5jZSl7X19WQV9BUkdT X199KSkKPiArCgpIYWggdGhpcyBpcyBzb21lIHRyaWNrLiBJIGFzc3VtZSB0aGlzIGFsbG93czoK CmViLmZsYWdzID0gZ2VtX2NvbnRleHRfZ2V0X2ViX2ZsYWdzKGZkLCBjdHgsIC4uLl9SRU5ERVIs IDApOwoKPwoKV2hhdCBpZiB0b28gZmV3IG9yIHRvbyBtYW55IHBhcmFtZXRlcnMgYXJlIGdpdmVu PyBJJ20gaW4gdHdvIG1pbmRzIGJ1dCAKY2FuJ3QgYXJndWUgaXQgaXMgdmVyeSB0byBiZSBhYmxl IHRvIGRvIHRoaXMgaW4gSUdULgoKPiAgICNkZWZpbmUgX19mb3JfZWFjaF9zdGF0aWNfZW5naW5l KGVfXykgXAo+ICAgCWZvciAoKGVfXykgPSBpbnRlbF9leGVjdXRpb25fZW5naW5lczI7IChlX18p LT5uYW1lOyAoZV9fKSsrKQo+ICAgCj4gCgpDYW4geW91IGV4dGVuZCB0aGUgc2VyaWVzIHdpdGgg YSBwYXRjaCB3aGljaCBjb252ZXJ0cyB0aGUgcHJvYmxlbWF0aWMgCnN1YnRlc3RzIGluIHBlcmZf cG11IHRvIHVzZSB0aGlzIGhlbHBlcj8gT3IgZXZlbiBtZXJnZSBpbnRvIHRoaXMgcGF0Y2gsIApJ IGRvbid0IG1pbmQuIFdvdWxkIGhhdmUgc29tZSBtb3JhbCBncm91bmRzIHRvIHItYiBpdCB0aGVu LiA7KQoKUmVnYXJkcywKClR2cnRrbwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3QtZGV2QGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ln dC1kZXY=