From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id C5A686F244 for ; Thu, 10 Jan 2019 10:10:20 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Thu, 10 Jan 2019 11:10:09 +0100 In-Reply-To: <20190108152001.5367-4-maxime.ripard@bootlin.com> References: <20190108152001.5367-4-maxime.ripard@bootlin.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maxime Ripard , igt-dev@lists.freedesktop.org Cc: Petri Latvala , eben@raspberrypi.org, Thomas Petazzoni List-ID: T24gVHVlLCAyMDE5LTAxLTA4IGF0IDE2OjE5ICswMTAwLCBNYXhpbWUgUmlwYXJkIHdyb3RlOgo+ IFRoZSBZVVYgYnVmZmVyIGFsbG9jYXRpb24gcGF0aCBmb3IgdGhlIGk5MTUgZHJpdmVyIGFsc28g aGFzIHNvbWUgY29kZSB0bwo+IGNsZWFyIGEgWVVWIGJ1ZmZlci4KPiAKPiBBcyB0aGF0IGlzIGdv aW5nIHRvIGJlIHVzZWZ1bCBmb3IgYWxsIHRoZSBvdGhlciBkcml2ZXJzLCBsZXQncyBtb3ZlIGl0 IHRvCj4gYSBzZXBhcmF0ZSBmdW5jdGlvbi4KPgo+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBh cmQgPG1heGltZS5yaXBhcmRAYm9vdGxpbi5jb20+CgpJJ20gbm90IHJlYWxseSBzdXJlIHdoeSBj bGVhcmluZyB0aGUgYnVmZmVycyBpcyBhIHVzZWZ1bCB0aGluZyB0byBkbwphbmQgd2h5IHdlIHNo b3VsZCBvbmx5IGRvIGl0IGZvciBZVVYgYW5kIG5vdCBSR0IgZm9ybWF0cy4KCkFueXdheSwgc2lu Y2UgdGhpcyBjb2RlIHdhcyBhbHJlYWR5IHRoZXJlIGFuZCB0aGUgcmVmYWN0b3JpbmcKZGVmaW5p dGVseSBtYWtlcyBzZW5zZToKClJldmlld2VkLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5r b2NpYWxrb3dza2lAYm9vdGxpbi5jb20+CgpDaGVlcnMsCgpQYXVsCgo+IC0tLQo+ICBsaWIvaWd0 X2ZiLmMgfCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCA0MiBpbnNlcnRpb25zKCspLCAzOCBkZWxldGlvbnMo LSkKPiAKPiBkaWZmIC0tZ2l0IGEvbGliL2lndF9mYi5jIGIvbGliL2lndF9mYi5jCj4gaW5kZXgg NDU2OTFmZDQ0MWQ5Li5kNjljM2ZiMmQzOGQgMTAwNjQ0Cj4gLS0tIGEvbGliL2lndF9mYi5jCj4g KysrIGIvbGliL2lndF9mYi5jCj4gQEAgLTQ4NCw2ICs0ODQsNDcgQEAgdWludDY0X3QgaWd0X2Zi X3RpbGluZ190b19tb2QodWludDY0X3QgdGlsaW5nKQo+ICAJfQo+ICB9Cj4gIAo+ICtzdGF0aWMg dm9pZCBjbGVhcl95dXZfYnVmZmVyKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICt7Cj4gKwlib29sIGZ1 bGxfcmFuZ2UgPSBmYi0+Y29sb3JfcmFuZ2UgPT0gSUdUX0NPTE9SX1lDQkNSX0ZVTExfUkFOR0U7 Cj4gKwl2b2lkICpwdHI7Cj4gKwo+ICsJaWd0X2Fzc2VydChpZ3RfZm9ybWF0X2lzX3l1dihmYi0+ ZHJtX2Zvcm1hdCkpOwo+ICsKPiArCS8qIEVuc3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxs b2NhdGVkICovCj4gKwlwdHIgPSBpZ3RfZmJfbWFwX2J1ZmZlcihmYi0+ZmQsIGZiKTsKPiArCWln dF9hc3NlcnQoKih1aW50MzJfdCAqKXB0ciA9PSAwKTsKPiArCj4gKwlzd2l0Y2ggKGZiLT5kcm1f Zm9ybWF0KSB7Cj4gKwljYXNlIERSTV9GT1JNQVRfTlYxMjoKPiArCQltZW1zZXQocHRyICsgZmIt Pm9mZnNldHNbMF0sCj4gKwkJICAgICAgIGZ1bGxfcmFuZ2UgPyAweDAwIDogMHgxMCwKPiArCQkg ICAgICAgZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdKTsKPiArCQltZW1zZXQo cHRyICsgZmItPm9mZnNldHNbMV0sCj4gKwkJICAgICAgIDB4ODAsCj4gKwkJICAgICAgIGZiLT5z dHJpZGVzWzFdICogZmItPnBsYW5lX2hlaWdodFsxXSk7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIERS TV9GT1JNQVRfWFlVVjg4ODg6Cj4gKwkJd21lbXNldChwdHIgKyBmYi0+b2Zmc2V0c1swXSwgZnVs bF9yYW5nZSA/IDB4MDAwMDgwODAgOiAweDAwMTA4MDgwLAo+ICsJCQlmYi0+c3RyaWRlc1swXSAq IGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+ICsJCWJyZWFrOwo+ICsJ Y2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gKwljYXNlIERSTV9GT1JNQVRfWVZZVToKPiArCQl3bWVt c2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ICsJCQlmdWxsX3JhbmdlID8gMHg4MDAwODAwMCA6 IDB4ODAxMDgwMTAsCj4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAv IHNpemVvZih3Y2hhcl90KSk7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIERSTV9GT1JNQVRfVVlWWToK PiArCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ICsJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNb MF0sCj4gKwkJCWZ1bGxfcmFuZ2UgPyAweDAwODAwMDgwIDogMHgxMDgwMTA4MCwKPiArCQkJZmIt PnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiAr CQlicmVhazsKPiArCX0KPiArCj4gKwlpZ3RfZmJfdW5tYXBfYnVmZmVyKGZiLCBwdHIpOwo+ICt9 Cj4gKwo+ICAvKiBoZWxwZXJzIHRvIGNyZWF0ZSBuaWNlLWxvb2tpbmcgZnJhbWVidWZmZXJzICov Cj4gIHN0YXRpYyBpbnQgY3JlYXRlX2JvX2Zvcl9mYihzdHJ1Y3QgaWd0X2ZiICpmYikKPiAgewo+ IEBAIC01MDEsNTAgKzU0MiwxMyBAQCBzdGF0aWMgaW50IGNyZWF0ZV9ib19mb3JfZmIoc3RydWN0 IGlndF9mYiAqZmIpCj4gIAkJZmItPmlzX2R1bWIgPSBmYWxzZTsKPiAgCj4gIAkJaWYgKGlzX2k5 MTVfZGV2aWNlKGZkKSkgewo+IC0JCQl2b2lkICpwdHI7Cj4gLQkJCWJvb2wgZnVsbF9yYW5nZSA9 IGZiLT5jb2xvcl9yYW5nZSA9PSBJR1RfQ09MT1JfWUNCQ1JfRlVMTF9SQU5HRTsKPiAgCj4gIAkJ CWZiLT5nZW1faGFuZGxlID0gZ2VtX2NyZWF0ZShmZCwgZmItPnNpemUpOwo+ICAKPiAgCQkJZ2Vt X3NldF90aWxpbmcoZmQsIGZiLT5nZW1faGFuZGxlLAo+ICAJCQkJICAgICAgIGlndF9mYl9tb2Rf dG9fdGlsaW5nKGZiLT50aWxpbmcpLAo+ICAJCQkJICAgICAgIGZiLT5zdHJpZGVzWzBdKTsKPiAt Cj4gLQkJCWdlbV9zZXRfZG9tYWluKGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiAtCQkJCSAgICAgICBJ OTE1X0dFTV9ET01BSU5fR1RULCBJOTE1X0dFTV9ET01BSU5fR1RUKTsKPiAtCj4gLQkJCS8qIEVu c3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxsb2NhdGVkICovCj4gLQkJCXB0ciA9IGdlbV9t bWFwX19ndHQoZmQsIGZiLT5nZW1faGFuZGxlLAo+IC0JCQkJCSAgICBmYi0+c2l6ZSwgUFJPVF9S RUFEIHwgUFJPVF9XUklURSk7Cj4gLQkJCWlndF9hc3NlcnQoKih1aW50MzJfdCAqKXB0ciA9PSAw KTsKPiAtCj4gLQkJCXN3aXRjaCAoZmItPmRybV9mb3JtYXQpIHsKPiAtCQkJY2FzZSBEUk1fRk9S TUFUX05WMTI6Cj4gLQkJCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gLQkJCQkgICAg ICAgZnVsbF9yYW5nZSA/IDB4MDAgOiAweDEwLAo+IC0JCQkJICAgICAgIGZiLT5zdHJpZGVzWzBd ICogZmItPnBsYW5lX2hlaWdodFswXSk7Cj4gLQkJCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNb MV0sCj4gLQkJCQkgICAgICAgMHg4MCwKPiAtCQkJCSAgICAgICBmYi0+c3RyaWRlc1sxXSAqIGZi LT5wbGFuZV9oZWlnaHRbMV0pOwo+IC0JCQkJYnJlYWs7Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9Y WVVWODg4ODoKPiAtCQkJCXdtZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sIGZ1bGxfcmFuZ2Ug PyAweDAwMDA4MDgwIDogMHgwMDEwODA4MCwKPiAtCQkJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5w bGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkpOwo+IC0JCQkJYnJlYWs7Cj4gLQkJCWNh c2UgRFJNX0ZPUk1BVF9ZVVlWOgo+IC0JCQljYXNlIERSTV9GT1JNQVRfWVZZVToKPiAtCQkJCXdt ZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gLQkJCQkJZnVsbF9yYW5nZSA/IDB4ODAwMDgw MDAgOiAweDgwMTA4MDEwLAo+IC0JCQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdo dFswXSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gLQkJCQlicmVhazsKPiAtCQkJY2FzZSBEUk1fRk9S TUFUX1VZVlk6Cj4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+IC0JCQkJd21lbXNldChwdHIg KyBmYi0+b2Zmc2V0c1swXSwKPiAtCQkJCQlmdWxsX3JhbmdlID8gMHgwMDgwMDA4MCA6IDB4MTA4 MDEwODAsCj4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0WzBdIC8gc2l6 ZW9mKHdjaGFyX3QpKTsKPiAtCQkJCWJyZWFrOwo+IC0JCQl9Cj4gLQkJCWdlbV9tdW5tYXAocHRy LCBmYi0+c2l6ZSk7Cj4gKwkJCWNsZWFyX3l1dl9idWZmZXIoZmQpOwo+ICAKPiAgCQkJcmV0dXJu IGZiLT5nZW1faGFuZGxlOwo+ICAJCX0gZWxzZSB7Ci0tIApQYXVsIEtvY2lhbGtvd3NraSwgQm9v dGxpbgpFbWJlZGRlZCBMaW51eCBhbmQga2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxp bi5jb20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmln dC1kZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=