Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: Jesse Zhang <jesse.zhang@amd.com>, igt-dev@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Luben Tuikov <luben.tuikov@amd.com>
Subject: Re: [PATCH i-g-t] tests/amdgpu: fix VM test issue
Date: Thu, 14 Dec 2023 10:53:31 +0100	[thread overview]
Message-ID: <cadc9180-d2b4-4dee-890b-96c3dc5402d3@amd.com> (raw)
In-Reply-To: <20231214090749.1711421-1-jesse.zhang@amd.com>

Am 14.12.23 um 10:07 schrieb Jesse Zhang:
> In some cases, the size of Vram and GTT is not large, such as mobile devices.
> It should be skipped.

Well how much memory is actually needed? The unaligned mmap test should 
be able to work with something like 2-8MiB.

Maybe we are just using something to big here, that below looks like we 
are using a 1GiB buffer.

Christian.

>
> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Christian Koenig <christian.koenig@amd.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
>
> Signed-off-by: Jesse zhang <jesse.zhang@amd.com>
> ---
>   tests/amdgpu/amd_vm.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/amdgpu/amd_vm.c b/tests/amdgpu/amd_vm.c
> index 11be25ae8..0dde28e2e 100644
> --- a/tests/amdgpu/amd_vm.c
> +++ b/tests/amdgpu/amd_vm.c
> @@ -127,8 +127,8 @@ amdgpu_vm_unaligned_map(amdgpu_device_handle device_handle)
>   	request.preferred_heap = AMDGPU_GEM_DOMAIN_VRAM;
>   	request.flags = AMDGPU_GEM_CREATE_NO_CPU_ACCESS;
>   
> -	r = amdgpu_bo_alloc(device_handle, &request, &buf_handle);
> -	igt_assert_eq(r, 0);
> +	/* Don't let the test fail if the device doesn't have enough VRAM */
> +	igt_skip_on(amdgpu_bo_alloc(device_handle, &request, &buf_handle));
>   
>   	r = amdgpu_va_range_alloc(device_handle, amdgpu_gpu_va_range_general,
>   				4ULL << 30, 1ULL << 30, 0, &vmc_addr,

  reply	other threads:[~2023-12-14  9:53 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-14  9:07 [PATCH i-g-t] tests/amdgpu: fix VM test issue Jesse Zhang
2023-12-14  9:53 ` Christian König [this message]
2023-12-15  1:43   ` Zhang, Jesse(Jie)
2023-12-15  9:28     ` Christian König
2023-12-14 12:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2023-12-14 12:57 ` ✓ CI.xeBAT: " Patchwork
2023-12-14 13:46 ` ✗ Fi.CI.IGT: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2024-01-05  5:18 [PATCH i-g-t] tests/amdgpu:fix vm " Jesse Zhang
2024-01-05  5:18 ` Jesse Zhang
2024-01-05  9:42 ` Kamil Konieczny
2024-01-05  9:43 ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cadc9180-d2b4-4dee-890b-96c3dc5402d3@amd.com \
    --to=christian.koenig@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jesse.zhang@amd.com \
    --cc=luben.tuikov@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox