From: "Manszewski, Christoph" <christoph.manszewski@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>,
igt-dev@lists.freedesktop.org
Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>,
Katarzyna Piecielska <katarzyna.piecielska@intel.com>
Subject: Re: [PATCH i-g-t] scripts/test_list: Don't log missing testlist
Date: Thu, 19 Sep 2024 12:25:50 +0200 [thread overview]
Message-ID: <caf78282-e322-4a04-9e3b-e03fa2d77b97@intel.com> (raw)
In-Reply-To: <20240919081603.523299-1-zbigniew.kempczynski@intel.com>
Hi Zbigniew,
On 19.09.2024 10:16, Zbigniew Kempczyński wrote:
> When tests are compiled conditionally and compilation flag is set
> to false they have no binaries in the build directory. As testlist
> is built from .c source file list, unnecessary warnings about missing
> .testlist files are produced.
>
> Avoid this warnings by skipping processing testlists for which binaries
> weren't produced.
Agree, since we commited to allow such a state, we should skip this
check too.
Reviewed-by: Christoph Manszewski <christoph.manszewski@intel.com>
Thanks,
Christoph
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Dominik Grzegorzek <dominik.grzegorzek@intel.com>
> Cc: Katarzyna Piecielska <katarzyna.piecielska@intel.com>
> Cc: Christoph Manszewski <christoph.manszewski@intel.com>
> ---
> scripts/test_list.py | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/test_list.py b/scripts/test_list.py
> index d050687fe1..40b6b7829b 100644
> --- a/scripts/test_list.py
> +++ b/scripts/test_list.py
> @@ -1127,8 +1127,13 @@ class TestList:
>
> """ Return a list of tests as reported by --list-subtests """
> tests = []
> + no_binaries = self.get_not_compiled()
> for name in self.filenames:
> - testlist = re.sub(r"\.c$", ".testlist", name.split('/')[-1])
> + binary = re.sub(r"\.c$", "", name.split('/')[-1])
> + if binary in no_binaries:
> + continue
> +
> + testlist = binary + ".testlist" > fname = os.path.join(self.igt_build_path, "tests",
testlist)
>
> if not os.path.isfile(fname):
next prev parent reply other threads:[~2024-09-19 10:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 8:16 [PATCH i-g-t] scripts/test_list: Don't log missing testlist Zbigniew Kempczyński
2024-09-19 10:25 ` Manszewski, Christoph [this message]
2024-09-19 23:36 ` ✓ Fi.CI.BAT: success for " Patchwork
2024-09-19 23:46 ` ✓ CI.xeBAT: " Patchwork
2024-09-20 1:56 ` ✓ CI.xeFULL: " Patchwork
2024-09-20 8:11 ` ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=caf78282-e322-4a04-9e3b-e03fa2d77b97@intel.com \
--to=christoph.manszewski@intel.com \
--cc=dominik.grzegorzek@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=katarzyna.piecielska@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox