From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2B0596E4B4 for ; Fri, 2 Nov 2018 12:11:33 +0000 (UTC) References: <20181102095726.9052-1-daniel.vetter@ffwll.ch> <20181102095726.9052-5-daniel.vetter@ffwll.ch> From: Maarten Lankhorst Message-ID: Date: Fri, 2 Nov 2018 13:11:30 +0100 MIME-Version: 1.0 In-Reply-To: <20181102095726.9052-5-daniel.vetter@ffwll.ch> Content-Language: en-US Subject: Re: [igt-dev] [PATCH i-g-t 5/5] lib/kms: warn if we commit without outputs List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter , IGT development Cc: Daniel Vetter List-ID: T3AgMDItMTEtMTggb20gMTA6NTcgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+IFdpdGggdGhlIGhp Z2gtbGV2ZWwgaGVscGVycyByZXF1aXJpbmcgb3V0cHV0cyB0aGVyZSdzIG5vdCBwb2ludAo+IGlu IHNpbGVudGx5IGlnbm9yaW5nIGlzc3VlcyBhbnltb3JlLiBDb21wbGFpbiBhYm91dCB0aGF0IGlm IGl0Cj4gZXZlciBoYXBwZW5zLgo+Cj4gVGhpcyByZXZlcnRzCj4KPiBjb21taXQgMjEyYjcxMzcy YmZiYjczNjYzZDg3MmRmMzExMThkNmIzOTZhZGE0Zgo+IEF1dGhvcjogQ2hyaXMgV2lsc29uIDxj aHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gRGF0ZTogICBGcmkgU2VwIDE0IDIxOjAzOjM4IDIw MTggKzAxMDAKPgo+ICAgICBsaWIva21zOiBTa2lwIG5vLW9wIGRpc3BsYXkgdXBkYXRlcwo+Cj4g d2hpY2ggY3JlYXRlZCBhbiBpbiBteSBvcGluaW9uIHNlcmlvdXMgQVBJIGlzc3VlIGJ5IHNpbGVu dGx5IGRyb3BwaW5nCj4gcG9zc2libGUgZXJyb3JzIG9uIHRoZSBmbG9vci4gSW5zdGVhZCBvZiBz aWxlbnRseSBzZWNvbmQgZ3Vlc3Mgd2hhdAo+IHRoZSB0ZXN0IG1pZ2h0IGhhdmUgd2FudGVkIHRv IGRvIGluIHRoZSBhYnNlbmNlIG9mIGRpc3BsYXkgb3V0cHV0cwo+IGl0J3MgbXVjaCBiZXR0ZXIg dG8gYmUgZXhwbGljaXQsIGFuZCBlbmZvcmNlIHRoYXQuCj4KPiB2MjogSW1wcm92ZSBjb21taXQg bWVzc2FnZS4KPgo+IENjOiBBbnRvbmlvIEFyZ2Vuemlhbm8gPGFudG9uaW8uYXJnZW56aWFub0Bp bnRlbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+ IENjOiBBcmthZGl1c3ogSGlsZXIgPGFya2FkaXVzei5oaWxlckBpbnRlbC5jb20+Cj4gQ2M6IE1h YXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0t Cj4gIGxpYi9pZ3Rfa21zLmMgfCA0ICsrLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttcy5jIGIvbGli L2lndF9rbXMuYwo+IGluZGV4IDcyMTQxMDFlMjY5Ni4uNWEzNWY2YmJjMTc3IDEwMDY0NAo+IC0t LSBhL2xpYi9pZ3Rfa21zLmMKPiArKysgYi9saWIvaWd0X2ttcy5jCj4gQEAgLTMyOTIsNyArMzI5 Miw3IEBAIHN0YXRpYyBpbnQgZG9fZGlzcGxheV9jb21taXQoaWd0X2Rpc3BsYXlfdCAqZGlzcGxh eSwKPiAgCWVudW0gcGlwZSBwaXBlOwo+ICAJTE9HX0lOREVOVChkaXNwbGF5LCAiY29tbWl0Iik7 Cj4gIAo+IC0JaWYgKCFkaXNwbGF5LT5uX3BpcGVzIHx8ICFkaXNwbGF5LT5uX291dHB1dHMpCj4g KwlpZiAoaWd0X3dhcm5fb24oIWRpc3BsYXktPm5fcGlwZXMgfHwgIWRpc3BsYXktPm5fb3V0cHV0 cykpCj4gIAkJcmV0dXJuIDA7IC8qIG5vdGhpbmcgdG8gZG8gKi8KPiAgCj4gIAlpZ3RfZGlzcGxh eV9yZWZyZXNoKGRpc3BsYXkpOwo+IEBAIC0zMzQ1LDcgKzMzNDUsNyBAQCBpbnQgaWd0X2Rpc3Bs YXlfdHJ5X2NvbW1pdF9hdG9taWMoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSwgdWludDMyX3QgZmxh Z3MsIHZvaWQgKgo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWlmICghZGlzcGxheS0+bl9waXBl cyB8fCAhZGlzcGxheS0+bl9vdXRwdXRzKQo+ICsJaWYgKGlndF93YXJuX29uKCFkaXNwbGF5LT5u X3BpcGVzIHx8ICFkaXNwbGF5LT5uX291dHB1dHMpKQo+ICAJCXJldHVybiAwOyAvKiBub3RoaW5n IHRvIGRvICovCj4gIAo+ICAJTE9HX0lOREVOVChkaXNwbGF5LCAiY29tbWl0Iik7CgpSZXZpZXdl ZC1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNv bT4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmlndC1k ZXYgbWFpbGluZyBsaXN0CmlndC1kZXZAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaWd0LWRldgo=