Re: [PATCH i-g-t] tests/intel/kms_dirtyfb: Skip output which doesn't support PSR

["Hogander, Jouni" <jouni.hogander@intel.com>]

On Tue, 2026-03-17 at 05:58 +0000, Bilal, Mohammed wrote:
> Hi Jeevan ,
> 
> > -----Original Message-----
> > From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of
> > Jeevan B
> > Sent: 17 March 2026 11:02
> > To: igt-dev@lists.freedesktop.org
> > Cc: Hogander, Jouni <jouni.hogander@intel.com>; B, Jeevan
> > <jeevan.b@intel.com>
> > Subject: [PATCH i-g-t] tests/intel/kms_dirtyfb: Skip output which
> > doesn't support
> > PSR
> > 
> > Pass the actual output to psr_sink_support() instead of NULL so
> > that PSR sink
> > support is checked per-output rather than generically.

I think you should go through all igt_psr calls in kms_dirtyfb.

BR,
Jouni Högander

> > 
> > Signed-off-by: Jeevan B <jeevan.b@intel.com>
> > ---
> >  tests/intel/kms_dirtyfb.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/tests/intel/kms_dirtyfb.c b/tests/intel/kms_dirtyfb.c
> > index
> > b85e09346..36eee29db 100644
> > --- a/tests/intel/kms_dirtyfb.c
> > +++ b/tests/intel/kms_dirtyfb.c
> > @@ -120,8 +120,8 @@ static bool check_support(data_t *data)
> >  			return false;
> >  		}
> >  		if (!psr_sink_support(data->drm_fd, data-
> > >debugfs_fd,
> > -				      PSR_MODE_1, NULL)) {
> > -			igt_info("Output doesn't support PSR\n");
> > +				      PSR_MODE_1, data->output)) {
> > +			igt_info("Output %s doesn't support
> > PSR\n",
> > +igt_output_name(data->output));
> >  			return false;
> >  		}
> >  		return true;
> > --
> > 2.43.0
> 
> LGTM.
> 
> Reviewed-by: Mohammed Bilal <mohammed.bilal@intel.com>
>