public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: vitaly prosyak <vprosyak@amd.com>, <igt-dev@lists.freedesktop.org>
Cc: <kamil.konieczny@intel.com>, <kunal1.joshi@intel.com>,
	Jesse Zhang <jesse.zhang@amd.com>,
	Vitaly Prosyak <vitaly.prosyak@amd.com>
Subject: Re: [PATCH i-g-t] tests/amdgpu/amd_fuzzing: Remove unused variable
Date: Thu, 2 Apr 2026 20:13:02 +0530	[thread overview]
Message-ID: <cc27d577-365d-4fa6-ae7b-c21aa6d77549@intel.com> (raw)
In-Reply-To: <9ad5da9e-2671-4b3d-b1a3-d65beca63834@amd.com>

Hi Vitaly,

No problem. Thanks for the rb. Pushed.

Regards,
Karthik.B.S

On 4/2/2026 5:53 PM, vitaly prosyak wrote:
> Hi Karthik,
>
> Thanks for fixing this, and apologies for the warning introduced by my earlier patch.
>
> Reviewed-by: Vitaly Prosyak  <vitaly.prosyak@amd.com>
>
> Vitaly
>
> On 2026-04-02 04:50, Karthik B S wrote:
>> Fix compilation warning:
>>
>> [1694/2119] Compiling C object tests/amdgpu/amd_fuzzing.p/amd_fuzzing.c.o
>> ../tests/amdgpu/amd_fuzzing.c: In function ‘amd_kgd_multi_ioctl_field_fuzzing’:
>> ../tests/amdgpu/amd_fuzzing.c:298:14: warning: unused variable ‘have_amdgpu_dev’ [-Wunused-variable]
>>    298 |         bool have_amdgpu_dev = (amdgpu_dev != NULL);
>>        |              ^~~~~~~~~~~~~~~
>>
>> Cc: Jesse Zhang <jesse.zhang@amd.com>
>> Cc: Vitaly Prosyak <vitaly.prosyak@amd.com>
>> Fixes: 49cf0900dd23 ("tests/amdgpu: add field-level negative ioctl fuzzing tests")
>> Signed-off-by: Karthik B S <karthik.b.s@intel.com>
>> ---
>>   tests/amdgpu/amd_fuzzing.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/tests/amdgpu/amd_fuzzing.c b/tests/amdgpu/amd_fuzzing.c
>> index 21dab4afe..00717e593 100644
>> --- a/tests/amdgpu/amd_fuzzing.c
>> +++ b/tests/amdgpu/amd_fuzzing.c
>> @@ -295,7 +295,6 @@ amd_kgd_multi_ioctl_field_fuzzing(int fd, amdgpu_device_handle amdgpu_dev)
>>   	uint32_t valid_bo_handle = 0;
>>   	bool have_valid_ctx = false;
>>   	bool have_valid_bo = false;
>> -	bool have_amdgpu_dev = (amdgpu_dev != NULL);
>>   
>>   	memset(&valid_ctx, 0, sizeof(valid_ctx));
>>   	valid_ctx.in.op = AMDGPU_CTX_OP_ALLOC_CTX;

  reply	other threads:[~2026-04-02 14:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  8:50 [PATCH i-g-t] tests/amdgpu/amd_fuzzing: Remove unused variable Karthik B S
2026-04-02  9:58 ` ✓ Xe.CI.BAT: success for " Patchwork
2026-04-02 10:02 ` ✓ i915.CI.BAT: " Patchwork
2026-04-02 12:23 ` [PATCH i-g-t] " vitaly prosyak
2026-04-02 14:43   ` Karthik B S [this message]
2026-04-02 16:59 ` ✓ Xe.CI.FULL: success for " Patchwork
2026-04-03  5:28 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc27d577-365d-4fa6-ae7b-c21aa6d77549@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jesse.zhang@amd.com \
    --cc=kamil.konieczny@intel.com \
    --cc=kunal1.joshi@intel.com \
    --cc=vitaly.prosyak@amd.com \
    --cc=vprosyak@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox