From: Antonio Argenziano <antonio.argenziano@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_ctx_shared: Fixup vec0 mmio base for icl
Date: Tue, 4 Jun 2019 11:43:35 -0700 [thread overview]
Message-ID: <cc7dacb7-a364-7003-1161-e4424e9adde0@intel.com> (raw)
In-Reply-To: <20190604162912.28359-1-chris@chris-wilson.co.uk>
On 04/06/19 09:29, Chris Wilson wrote:
> I told vecs0 to use vecs1 registers...
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_ctx_shared.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_shared.c b/tests/i915/gem_ctx_shared.c
> index 67ecd0953..069964546 100644
> --- a/tests/i915/gem_ctx_shared.c
> +++ b/tests/i915/gem_ctx_shared.c
> @@ -544,9 +544,11 @@ static void independent(int i915, unsigned ring, unsigned flags)
> mmio_base = 0x22000;
> break;
>
> +#define GEN11_VECS0_BASE 0x1c8000
> +#define GEN11_VECS1_BASE 0x1d8000
VECS1 coming next?
> case I915_EXEC_VEBOX:
There is a commented-out case for BSD, why is that?
> if (intel_gen(intel_get_drm_devid(i915)) >= 11)
> - mmio_base = 0x1d8000;
> + mmio_base = GEN11_VECS0_BASE;
Might as well define all bases.
Still, fixes the test so:
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>
Antonio
> else
> mmio_base = 0x1a000;
> break;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-04 18:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 16:29 [igt-dev] [PATCH i-g-t] i915/gem_ctx_shared: Fixup vec0 mmio base for icl Chris Wilson
2019-06-04 17:12 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-04 18:43 ` Antonio Argenziano [this message]
2019-06-04 20:00 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2019-06-05 14:15 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc7dacb7-a364-7003-1161-e4424e9adde0@intel.com \
--to=antonio.argenziano@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox