From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id C821D89EB1 for ; Thu, 21 Mar 2019 11:39:37 +0000 (UTC) References: <20190321010015.1317-1-andi.shyti@intel.com> <20190321010015.1317-5-andi.shyti@intel.com> <34e42d43-c18b-d832-6971-505146fbec71@linux.intel.com> <20190321112343.GA1774@intel.intel> From: Tvrtko Ursulin Message-ID: Date: Thu, 21 Mar 2019 11:39:35 +0000 MIME-Version: 1.0 In-Reply-To: <20190321112343.GA1774@intel.intel> Content-Language: en-US Subject: Re: [igt-dev] [PATCH v14 4/5] lib/i915: add gem_engine_topology library and for_each loop definition List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Andi Shyti Cc: IGT dev , Andi Shyti List-ID: Ck9uIDIxLzAzLzIwMTkgMTE6MjMsIEFuZGkgU2h5dGkgd3JvdGU6Cj4+PiArc3RhdGljIHZvaWQg aW5pdF9lbmdpbmUoc3RydWN0IGludGVsX2V4ZWN1dGlvbl9lbmdpbmUyICplMiwgY29uc3QgY2hh ciAqbmFtZSwKPj4+ICsJCQl1aW50MTZfdCBjbGFzcywgdWludDE2X3QgaW5zdGFuY2UsIHVpbnQ4 X3QgZmxhZ3MpCj4+Cj4+IEknZCBwcm9iYWJseSB1c2UgdTY0IGZvciBmbGFncyB0byBtYXRjaCB0 aGUgc3RydWN0dXJlLgo+IAo+IHllcywgZmxhZ3MgaXQncyB1NjQsIEkgdXNlZCB1OCBiZWNhdXNl IHRoZSBmbGFncyB3ZSB1c2UgaXMgbmV2ZXIKPiBzdXBwb3NlZCB0byBiZSBoaWdoZXIgdGhhbiB0 aGFuIDNmLiBCdXQgc3VyZSwgY2FuIG1ha2UgaXQgdTY0Lgo+IAo+Pj4gK3sKPj4+ICsJc3RhdGlj IGNvbnN0IGNoYXIgKnVua19uYW1lID0gInVuayI7Cj4+PiArCj4+PiArCWUyLT5jbGFzcyAgICA9 IGNsYXNzOwo+Pj4gKwllMi0+aW5zdGFuY2UgPSBpbnN0YW5jZTsKPj4+ICsJZTItPmZsYWdzICAg ID0gZmxhZ3M7Cj4+PiArCj4+PiArCWlmIChuYW1lKSB7Cj4+PiArCQllMi0+bmFtZSA9IG5hbWU7 Cj4+Cj4+IFRoaXMgcGF0aCBpcyB1c2VkIG9ubHkgZm9yIHRoZSBsZWdhY3kgZmFsbCBiYWNrIG1v ZGUgc28gSSBhbSBjb250ZW1wbGF0aW5nCj4+IHdoZXRoZXIgaXMgaXMgZXZlbiB3b3J0aCBoYXZp bmcgdGhlIG5hbWUgcGFzc2VkIGluLgo+IAo+IHllcywganVzdCB3YW50ZWQgdG8gYmUgY29uc2lz dGVudC4gQXQgdGhlIGJpZ2lubmluZyB0aGUKPiBkdXBfZW5naW5lIGhhZCBhIGJpZ2dlciByb2xl LCBidXQgdGhlbiBJIGRlbW90ZWQgaXQgdG8ganVzdCBkb2luZwo+IHRoaXMuCj4gCj4+IFRoZSBp ZiB5b3UgZmluZCBhIHZpcnR1YWwgZW5naW5lIGluIHRoZSBsaXN0ICgKPj4gSTkxNV9FTkdJTkVf Q0xBU1NfSU5WQUxJRC9JOTE1X0VOR0lORV9DTEFTU19JTlZBTElEX1ZJUlRVQUwpIHlvdSBjb3Vs ZCBzZXQKPj4gdGhlIG5hbWUgdG8gInZpcnR1YWwiIG9yIHNvbWV0aGluZy4KPiAKPiBkbyB3ZSBy ZWFsbHkgbmVlZCBhIG5hbWUgb2YgdGhlIHR5cGUgInZpcnR1YWwtPGVuZ2luZT4iPwoKUHJvYmFi bHkgbm90LiBQbGFpbiAidmlydHVhbCIgc291bmRzIG9rLgoKPiAKPj4gTm93IGxpc3RlbiB0byB0 aGlzLi4gaG93IGFib3V0IHdlIGV4cG9ydCB0aGUgZW5naW5lIG5hbWVzIHZpYSB0aGUgcXVlcnkg QVBJPwo+PiBQcmltYXJpbHkgSSB3YXMgdGhpbmtpbmcgdG8gZGlzdGluZ3Vpc2ggZGlmZmVyZW5j ZSBpbnN0YW5jZSBvZiB2aXJ0dWFsLCBidXQKPj4gdGhlbiBpdCB3b3VsZCBhbHNvIGxlc3NlbiB0 aGUgcmVsaWFuY2Ugb24gdGhlIHN0YXRpYyBtYXAuIFRob3VnaHRzPwo+IAo+IERvIHlvdSBtZWFu IHRoYXQgdGhlIG5hbWUgd291bGQgYmUgcHJvdmlkZWQgYnkgdGhlIGRyaXZlcj8KPiAKPiBPdGhl ciB0aGFuIGltcHJvdmluZyB0aGUgZGVidWcgaW5mb3JtYXRpb24sIGlzIHRoZSBuYW1lCj4gZm9y bWF0dGluZyBnaXZpbmcgYW55IGFkdmFudGFnZSBpZiB3ZSBjYW4gZGlzdGluZ3Vpc2ggYnkKPiBj bGFzcy9pbnN0YW5jZS9mbGFncz8KPiAKPiBXZSBjYW4ndCB1c2UgaXQgYW55d2F5IGZvciB0ZXN0 IGNyZWF0aW9uLgoKWWVhaCwganVzdCBuZWVkIHRvIHNraXAgaXQgZHVyaW5nIGZvcl9lYWNoX3Bo eXNpY2FsX2VuZ2luZS4KCj4gCj4gWy4uLl0KPiAKPj4+ICsJCXVpbnQ4X3QgbmVuZ2luZXMgPSAo cGFyYW0uc2l6ZSAtCj4+PiArCQkJCXNpemVvZihzdHJ1Y3QgaTkxNV9jb250ZXh0X3BhcmFtX2Vu Z2luZXMpKSAvCj4+PiArCQkJCXNpemVvZihlbmdpbmVzLT5jbGFzc19pbnN0YW5jZVswXSk7Cj4+ Cj4+IEknZCBwcm9iYWJseSBqdXN0IHVzZSB1bnNpZ25lZCBpbnQuCj4gCj4gT2guLi4gSSBoYXZl IHNldCB1MzIgaW4gdGhlIGludGVsX2VuZ2luZV9kYXRhLCBJIGRpZG4ndCByZWxpYXNlLAo+IEkg YXNzdW1lIHRoYXQgbmVuZ2luZXMgd291bGQgbmV2ZXIgYmUgaGlnaGVyIHRoYW4gNjQgKGlmIHRo YXQKPiBoYXBwZW5zIHdlIGNhbid0IGhhbmRsZSBpdCBoZXJlKS4KPiAKPiBCdXQgQ2hyaXMgaXMg Y29uc2lkZXJpbmcgdGhlIGNhc2Ugd2Ugd2lsbCBoYXZlIG1vcmUgdGhhIDY0Cj4gZW5naW5lcywg SSBjYW4gc2V0IGl0IHRvIHUzMiwgb2YgY291cnNlLgo+IAo+IFsuLi5dCj4gCj4+PiArI2RlZmlu ZSBmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmRfXywgY3R4X18sIGVfXykgXAo+Pj4g Kwlmb3IgKHN0cnVjdCBpbnRlbF9lbmdpbmVfZGF0YSBpX18gPSBpbnRlbF9pbml0X2VuZ2luZV9s aXN0KGZkX18sIGN0eF9fKTsgXAo+Pj4gKwkJKChlX18pID0gKGlfXy5uIDwgaV9fLm5lbmdpbmVz KSA/ICZpX18uZW5naW5lc1tpX18ubl0gOiBOVUxMKTsgXAo+Pj4gKwkJCWlfXy5uKyspCj4+Cj4+ IERvIHdlIHdhbnQgYSBjb250ZXh0IHBhcmFtZXRlciBpbiB0aGlzIGhlbHBlciwgb3IgZXZlbiB0 aGlzIGhlbHBlciBhdCBhbGw/IEkKPj4gdGhvdWdodCB3ZSBjYW4gZW5kIHVwIHdpdGggb25seSB0 d28sIGZvcl9lYWNoX3BoeXNpY2FsX2VuZ2luZSBhbmQKPj4gZm9yX2VhY2hfY29udGV4dF9lbmdp bmUgLSBidXQgSSBndWVzcyBpdCBpcyBvcGVuIGZvciBkaXNjdXNzaW9uLgo+IAo+IEkgZG9uJ3Qg a25vdyBvZiBwb3NzaWJsZSB1c2UgY2FzZXMgdGhhdCBkbyBvciBkb24ndCBuZWVkIGN0eAo+IG91 dHNpZGUgdGhlIGZvcl9lYWNoLi4uKCkuCj4gCj4gSWYgeW91IGRvbid0IHNlZSBhbnkgdXNlIG9m IHRoZSBjb250ZXh0IGluZGV4IG91dHNpZGUgdGhlCj4gZm9yX2VhY2ggSSBjYW4gY3JlYXRlIHRo ZSBjb250ZXh0IGluc2lkZSB0aGUgaW5pdF9saXN0IGZ1bmN0aW9uLgo+IAo+IEJ1dCwgSSBoYXZl IGEgbGl0dGxlIGNvbmNlcm4gYWJvdXQgdGhlIGRlc3RyYWN0aW9uIG9mIHRoYXQKPiBjb250ZXh0 LiBJZiB0aGUgZm9yX2VhY2guLi4gZ2V0cyBpbnRlcnJ1cHRlZCBpbiB0aGUgbWlkZGxlIG9mIHRo ZQo+IGxvb3AsIHdlIGxvc2UgdGhlIGNvbnRleHQuCgpJIGFtIG5vdCBmb2xsb3dpbmcgaG93IHdl IGxvc2UgdGhlIGNvbnRleHQ/CgpJIHdhcyBqdXN0IGRpc2N1c3Npbmcgb2Ygb3VyIGRlc2lyZWQg ZW5kIGdhbWUgaW4gdGhlcm1zIG9mIG51bWJlciBhbmQgCnNpZ25hdHVyZSBmb3IgZm9yX2VhY2hf Li4gaXRlcmF0b3JzLgoKRm9yIG1lIGZvcl9lYWNoX3BoeXNpY2FsX2VuZ2luZSBkb2Vzbid0IG5l ZWQgdGhlIGNvbnRleHQgc2luY2UgaXQgaXMgCmFib3V0IHBoeXNpY2FsIGVuZ2luZXMgLSBub3Qg ZW5naW5lIGZyb20gdGhlIGVuZ2luZSBtYXAuIE1heWJlIHRoYXQgb25lIApzaG91bGQgZXZlbiBo YXZlIHNvbWUgYXNzZXJ0cyB0aGVuIHRvIG1ha2Ugc3VyZSBzb21lb25lIGhhc24ndCAKcmUtY29u ZmlndXJlZCB0aGUgZGVmYXVsdCBjb250ZXh0LgoKQW5kIHdlIGhhdmUgX19mb3JfZWFjaF9waHlz aWNhbF9lbmdpbmUgd2hpY2ggdXNlcyB0aGUgc3RhdGljIHRhYmxlLCBmb3IgCnN1YnRlc3QgZW51 bWVyYXRpb24uCgpUaGVuIGZvcl9lYWNoX2NvbnRleHRfZW5naW5lIGlzIHRoZSBmdWxseSBmZWF0 dXJlZCBvbmUsIHdoaWNoIGhhcyB0aGUgCmNvbnRleHQgaWQgaW4gcGFyYW1ldGVycy4KCkNhbiB3 ZSBzb2x2ZSBhbGwgdXNlIGNhc2VzIHdpdGggdGhvc2UgdGhyZWUgb3Igd2UgbmVlZCBtb2RlPwoK Q2hyaXM/Cgo+IAo+IFsuLi5dCj4gCj4+PiBAQCAtNDM0LDcgKzQzNCw3IEBAIGJ1c3lfY2hlY2tf YWxsKGludCBnZW1fZmQsIGNvbnN0IHN0cnVjdCBpbnRlbF9leGVjdXRpb25fZW5naW5lMiAqZSwK Pj4+ICAgIAlpID0gMDsKPj4+ICAgIAlmZFswXSA9IC0xOwo+Pj4gLQlmb3JfZWFjaF9lbmdpbmVf Y2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCBlXykgewo+Pj4gKwlmb3JfZWFjaF9lbmdpbmVfY2xhc3Nf aW5zdGFuY2UoZ2VtX2ZkLCAwLCBlXykgewo+Pj4gICAgCQlpZiAoZSA9PSBlXykKPj4+ICAgIAkJ CWJ1c3lfaWR4ID0gaTsKPj4+IEBAIC00OTcsNyArNDk3LDcgQEAgbW9zdF9idXN5X2NoZWNrX2Fs bChpbnQgZ2VtX2ZkLCBjb25zdCBzdHJ1Y3QgaW50ZWxfZXhlY3V0aW9uX2VuZ2luZTIgKmUsCj4+ PiAgICAJdW5zaWduZWQgaW50IGlkbGVfaWR4LCBpOwo+Pj4gICAgCWkgPSAwOwo+Pj4gLQlmb3Jf ZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCBlXykgewo+Pj4gKwlmb3JfZWFjaF9l bmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCAwLCBlXykgewo+Pj4gICAgCQlpZiAoZSA9PSBl XykKPj4+ICAgIAkJCWlkbGVfaWR4ID0gaTsKPj4+ICAgIAkJZWxzZSBpZiAoc3BpbikKPj4+IEBA IC01NTQsNyArNTU0LDcgQEAgYWxsX2J1c3lfY2hlY2tfYWxsKGludCBnZW1fZmQsIGNvbnN0IHVu c2lnbmVkIGludCBudW1fZW5naW5lcywKPj4+ICAgIAl1bnNpZ25lZCBpbnQgaTsKPj4+ICAgIAlp ID0gMDsKPj4+IC0JZm9yX2VhY2hfZW5naW5lX2NsYXNzX2luc3RhbmNlKGdlbV9mZCwgZSkgewo+ Pj4gKwlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZ2VtX2ZkLCAwLCBlKSB7Cj4+PiAg ICAJCWlmIChzcGluKQo+Pj4gICAgCQkJX19zdWJtaXRfc3Bpbl9iYXRjaChnZW1fZmQsIHNwaW4s IGUsIDY0KTsKPj4+ICAgIAkJZWxzZQo+Pj4gQEAgLTE2ODMsNyArMTY4Myw3IEBAIGlndF9tYWlu Cj4+PiAgICAJCWlndF9yZXF1aXJlX2dlbShmZCk7Cj4+PiAgICAJCWlndF9yZXF1aXJlKGk5MTVf dHlwZV9pZCgpID4gMCk7Cj4+PiAtCQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQs IGUpCj4+PiArCQlmb3JfZWFjaF9lbmdpbmVfY2xhc3NfaW5zdGFuY2UoZmQsIDAsIGUpCj4+PiAg ICAJCQludW1fZW5naW5lcysrOwo+Pj4gICAgCX0KPj4+Cj4+Cj4+IExvb2tzIGxpa2UgdGhpcyB3 b3VsZCB3b3JrLiBKdXN0IHRoZSBxdWVzdGlvbiBvZiB2aXJ0dWFsIGVuZ2luZSwgc2V0IG9mCj4+ IGNob3NlbiBpdGVyYXRvcnMsIGFuZCBtYXliZSBzb21lIG5pdHMuCj4gCj4gWWVzLCBhcyB3ZSBk aXNjdXNzZWQsIHJpZ2h0IGFmdGVyIHRoaXMgcGF0Y2hzZXQgSSB3aWxsIGRvIHRoZQo+IGZvcl9l YWNoX3BoeXNpY2FsLgo+IAo+IFdoYXQgYXJlIHRoZSBuaXRzPyBJIGxvdmUgbml0cyA6KQoKSnVz dCB0aGluZ3MgbGlrZSB0eXBlcyBhbmQgY29kaW5nIHN0eWxlLiA6KSBBbmQgc29tZSBtb3JlIGRl dGFpbHMgZnJvbSAKQ2hyaXMnIHJldmlldy4KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QK aWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2