From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 88E6210E798 for ; Wed, 18 Jan 2023 16:36:20 +0000 (UTC) Message-ID: Date: Wed, 18 Jan 2023 22:06:13 +0530 MIME-Version: 1.0 To: "Hogander, Jouni" , "igt-dev@lists.freedesktop.org" References: <20230112073537.27890-1-swati2.sharma@intel.com> <20230112073537.27890-4-swati2.sharma@intel.com> Content-Language: en-US From: Swati Sharma In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t v4 3/8] lib/dsc: Add helpers for VDSC YCbCr420 debugfs entry List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 13-Jan-23 1:47 PM, Hogander, Jouni wrote: >> + * Returns: 1 on success or negative error code, in case of failure. > 0 is usually success, < 0 is error. This is also in coding style > document. I see igt_force_dsc_enable is also using 1. Maybe you should > fix that as well in a separate patch. > This ret value is returned from igt_sysfs_write() which returns the number of bytes written, or -errno on error. I guess we can't change this. -- ~Swati Sharma