Re: [igt-dev] [PATCH i-g-t v4 1/3] Format modifier for Intel Gen-12 render compression

["Kahola, Mika" <mika.kahola@intel.com>]

On Mon, 2019-11-11 at 13:08 +0200, Petri Latvala wrote:
> On Mon, Nov 11, 2019 at 01:00:47PM +0200, Mika Kahola wrote:
> > Gen-12 has a new compression format for render compression.
> > For this, a new modifier is needed to indicate that.
> > 
> > Signed-off-by: Mika Kahola <mika.kahola@intel.com>
> > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> > ---
> >  include/drm-uapi/drm_fourcc.h | 1 +
> >  lib/ioctl_wrappers.h          | 1 +
> >  2 files changed, 2 insertions(+)
> > 
> > diff --git a/include/drm-uapi/drm_fourcc.h b/include/drm-
> > uapi/drm_fourcc.h
> > index 3feeaa3f..b93eb2d4 100644
> > --- a/include/drm-uapi/drm_fourcc.h
> > +++ b/include/drm-uapi/drm_fourcc.h
> > @@ -409,6 +409,7 @@ extern "C" {
> >   */
> >  #define I915_FORMAT_MOD_Y_TILED_CCS	fourcc_mod_code(INTEL,
> > 4)
> >  #define I915_FORMAT_MOD_Yf_TILED_CCS	fourcc_mod_code(INTEL,
> > 5)
> > +#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS
> > fourcc_mod_code(INTEL, 6)
> >  
> >  /*
> >   * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized
> > macroblocks
> > diff --git a/lib/ioctl_wrappers.h b/lib/ioctl_wrappers.h
> > index 03211c97..f2412d78 100644
> > --- a/lib/ioctl_wrappers.h
> > +++ b/lib/ioctl_wrappers.h
> > @@ -200,6 +200,7 @@ struct local_drm_mode_fb_cmd2 {
> >  #define LOCAL_I915_FORMAT_MOD_Yf_TILED	local_fourcc_mod_code(I
> > NTEL, 3)
> >  #define LOCAL_I915_FORMAT_MOD_Y_TILED_CCS	local_fourcc_mod_code(I
> > NTEL, 4)
> >  #define LOCAL_I915_FORMAT_MOD_Yf_TILED_CCS	local_fourcc_mod_code(I
> > NTEL, 5)
> > +#define LOCAL_I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS
> > fourcc_mod_code(INTEL, 6)
> 
> Why do we carry these LOCAL_ defines when we have the kernel uapi
> headers copied that define them?
I guess there was some historical reason to do this, which I don't
know.

Maybe we could prepare a clean up patch and drop these local
definitions altogether?


> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev