From: Karthik B S <karthik.b.s@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] tests/kms_vblank: cosmetic changes
Date: Wed, 11 Oct 2023 10:48:04 +0530 [thread overview]
Message-ID: <cd1714fe-365f-f2ea-a41a-d0f8fc0345fa@intel.com> (raw)
In-Reply-To: <20231010051923.41431-2-swati2.sharma@intel.com>
On 10/10/2023 10:49 AM, Swati Sharma wrote:
> Fix igt_describe() documentation. Remove redundant documentation.
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
Reviewed-by: Karthik B S <karthik.b.s@intel.com>
> ---
> tests/kms_vblank.c | 15 +++++----------
> 1 file changed, 5 insertions(+), 10 deletions(-)
>
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 33e933c22..bcfd8d012 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -21,11 +21,6 @@
> * IN THE SOFTWARE.
> */
>
> -/** @file kms_vblank.c
> - *
> - * This is a test of performance of drmWaitVblank.
> - */
> -
> #include "igt.h"
> #include <stdlib.h>
> #include <stdio.h>
> @@ -46,7 +41,7 @@
> * Description: Test speed of WaitVblank.
> *
> * SUBTEST: crtc-id
> - * Description: check the Vblank and flip events works with given crtc id
> + * Description: Check the vblank and flip events works with given crtc id
> * Driver requirement: i915, xe
> * Functionality: vblank
> * Mega feature: General Display Features
> @@ -623,7 +618,7 @@ static void run_subtests_for_pipe(data_t *data)
> if (m->flags & ~(f->valid | NOHANG))
> continue;
>
> - igt_describe("Check if test run while hanging by introducing NOHANG flag");
> + igt_describe("Check if test run while hanging by introducing NOHANG flag.");
> igt_subtest_f("pipe-%s-%s-%s",
> kmstest_pipe_name(data->pipe),
> f->name, m->name) {
> @@ -645,7 +640,7 @@ static void run_subtests_for_pipe(data_t *data)
> if (f->valid & NOHANG || m->flags & NOHANG)
> continue;
>
> - igt_describe("check if injected hang is working properly");
> + igt_describe("Check if injected hang is working properly.");
> igt_subtest_f("pipe-%s-%s-%s-hang",
> kmstest_pipe_name(data->pipe),
> f->name, m->name) {
> @@ -742,11 +737,11 @@ igt_main
> igt_display_require_output(&data.display);
> }
>
> - igt_describe("Negative test for vblank request");
> + igt_describe("Negative test for vblank request.");
> igt_subtest("invalid")
> invalid_subtest(&data, fd);
>
> - igt_describe("check the Vblank and flip events works with given crtc id");
> + igt_describe("Check the vblank and flip events works with given crtc id.");
> igt_subtest("crtc-id")
> crtc_id_subtest(&data, fd);
>
next prev parent reply other threads:[~2023-10-11 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 5:19 [igt-dev] [PATCH i-g-t 0/2] tests/kms_vblank: Test cleanup and dynamic conversion Swati Sharma
2023-10-10 5:19 ` [igt-dev] [PATCH i-g-t 1/2] tests/kms_vblank: cosmetic changes Swati Sharma
2023-10-11 5:18 ` Karthik B S [this message]
2023-10-10 5:19 ` [igt-dev] [PATCH i-g-t 2/2] tests/kms_vblank: convert test to dynamic Swati Sharma
2023-10-10 6:55 ` [igt-dev] ✗ CI.xeBAT: failure for tests/kms_vblank: Test cleanup and dynamic conversion (rev2) Patchwork
2023-10-10 6:58 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2023-10-10 12:50 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd1714fe-365f-f2ea-a41a-d0f8fc0345fa@intel.com \
--to=karthik.b.s@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=swati2.sharma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox