igt-dev.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
To: Swati Sharma <swati2.sharma@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t 1/6] include/drm-uapi: Add DRM_COLOROP_FIXED_MATRIX definition
Date: Thu, 13 Aug 2026 19:27:04 +0530	[thread overview]
Message-ID: <cd213040-adc7-4d4e-a489-72f06f1651a5@intel.com> (raw)
In-Reply-To: <20260806120345.19406-2-swati2.sharma@intel.com>



On 8/6/2026 5:33 PM, Swati Sharma wrote:
> Add DRM_COLOROP_FIXED_MATRIX to the colorop type enumeration. This
> colorop type represents a pre-defined matrix operation selected via
> the FIXED_MATRIX_TYPE enum property. The driver advertises the
> supported operations through this property.
> 
> Aligns with kernel commit introducing the Fixed Matrix colorop
> type for Intel display hardware.
> 
> v2: -Naming changes (CSC_FF -> FIXED_MATRIX)
> 

I am not sure how strict is the rule for adding the kernel patch's sha
to the commit message but the change itself looks good.

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Assisted-by: Claude Opus 4.6
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> ---
>   include/drm-uapi/drm_mode.h | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/include/drm-uapi/drm_mode.h b/include/drm-uapi/drm_mode.h
> index de10ce859..0924e38af 100644
> --- a/include/drm-uapi/drm_mode.h
> +++ b/include/drm-uapi/drm_mode.h
> @@ -934,6 +934,17 @@ enum drm_colorop_type {
>   	 * LUT size is advertised via the SIZE property.
>   	 */
>   	DRM_COLOROP_3D_LUT,
> +
> +	/**
> +	 * @DRM_COLOROP_FIXED_MATRIX:
> +	 *
> +	 * enum string "Fixed Matrix"
> +	 *
> +	 * A Colorop block that performs a pre-defined matrix operation selected
> +	 * via the FIXED_MATRIX_TYPE enum property. The driver advertises the supported
> +	 * operations through this property.
> +	 */
> +	DRM_COLOROP_FIXED_MATRIX,
>   };
>   
>   /**


  reply	other threads:[~2026-08-13 13:57 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 12:03 [PATCH i-g-t v3 0/6] Add FIXED_MATRIX colorop tests Swati Sharma
2026-08-06 12:03 ` [PATCH i-g-t 1/6] include/drm-uapi: Add DRM_COLOROP_FIXED_MATRIX definition Swati Sharma
2026-08-13 13:57   ` Borah, Chaitanya Kumar [this message]
2026-08-06 12:03 ` [PATCH i-g-t 2/6] lib/igt_kms: Add FIXED_MATRIX_TYPE colorop property Swati Sharma
2026-08-13 13:57   ` Borah, Chaitanya Kumar
2026-08-06 12:03 ` [PATCH i-g-t 3/6] tests/kms_colorop_helper: Add FIXED_MATRIX colorop support Swati Sharma
2026-08-13 13:58   ` Borah, Chaitanya Kumar
2026-08-06 12:03 ` [PATCH i-g-t 4/6] tests/kms_color_pipeline: Add FIXED_MATRIX colorop tests Swati Sharma
2026-08-13 14:00   ` Borah, Chaitanya Kumar
2026-08-06 12:03 ` [PATCH i-g-t 5/6] tests/kms_color_pipeline: Remove unused color_depth and drm_format Swati Sharma
2026-08-13 14:00   ` Borah, Chaitanya Kumar
2026-08-06 12:03 ` [PATCH i-g-t 6/6] tests/kms_chamelium_color_pipeline: Add FIXED_MATRIX colorop tests Swati Sharma
2026-08-06 15:02   ` Jani Nikula
2026-08-13 14:00   ` Borah, Chaitanya Kumar
2026-08-07  0:28 ` ✓ Xe.CI.BAT: success for Add FIXED_MATRIX colorop tests (rev3) Patchwork
2026-08-07  0:30 ` ✓ i915.CI.BAT: " Patchwork
2026-08-07  8:57 ` ✗ i915.CI.Full: failure " Patchwork
2026-08-07 14:19 ` ✓ Xe.CI.FULL: success " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2026-07-27 18:55 [PATCH i-g-t 0/6] Add FIXED_MATRIX colorop tests Swati Sharma
2026-07-27 18:55 ` [PATCH i-g-t 1/6] include/drm-uapi: Add DRM_COLOROP_FIXED_MATRIX definition Swati Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd213040-adc7-4d4e-a489-72f06f1651a5@intel.com \
    --to=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=swati2.sharma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).