Re: [PATCH i-g-t] tests/intel/hwmon: Check temperature limit in hwmon-read

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

Hi Karthik,

On 12-12-2025 01:12 am, Karthik Poosa wrote:
> Improve hwmon-read test to check if current temperature
> is above critical temperature limit in hwmon-read test.
> This will help identify any thermal issues with the
> setups during test runs.
>
> Signed-off-by: Karthik Poosa <karthik.poosa@intel.com>
> ---
>   tests/intel/intel_hwmon.c | 21 +++++++++++++++++++++
>   1 file changed, 21 insertions(+)
>
> diff --git a/tests/intel/intel_hwmon.c b/tests/intel/intel_hwmon.c
> index 103ae69cd..b19868440 100644
> --- a/tests/intel/intel_hwmon.c
> +++ b/tests/intel/intel_hwmon.c
> @@ -26,6 +26,25 @@
>   
>   IGT_TEST_DESCRIPTION("Tests for intel hwmon");
>   
> +static void check_if_temp_valid(int hwm, char *sysfs_name, u32 cur_val)
> +{
> +	char str[32] = {0};
> +	uint8_t ch = 0;
> +	s32 limit = 0;
> +
> +	sscanf(sysfs_name, "temp%hhu_%s", &ch, str);

Please add sscanf validation

> +
> +	/* If entry is tempX_input, check if it exceeds tempX_crit. */
> +	if (!strncmp(sysfs_name, "temp", 4) && !strncmp(str, "input", 5)) {
> +		sprintf(str, "temp%d_crit", ch);

ch type inconsistency (%hhu and %d)

Thanks

-/Mallesh

> +		if (!faccessat(hwm, str, R_OK, 0)) {
> +			igt_assert_lt(0, igt_sysfs_scanf(hwm, str, "%d", &limit));
> +			igt_debug("current value = %d limit = %d\n", cur_val, limit);
> +			igt_assert_f(cur_val <= limit, "current temperature exceeds limit!\n");
> +		}
> +	}
> +}
> +
>   static void hwmon_read(int hwm)
>   {
>   	struct dirent *de;
> @@ -43,6 +62,8 @@ static void hwmon_read(int hwm)
>   		igt_assert(igt_sysfs_scanf(hwm, de->d_name, "%127s", val) == 1);
>   		igt_debug("'%s': %s\n", de->d_name, val);
>   
> +		check_if_temp_valid(hwm, de->d_name, atoi(val));
> +
>   	}
>   	closedir(dir);
>   }