From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by gabe.freedesktop.org (Postfix) with ESMTPS id 84EE510E422 for ; Tue, 15 Mar 2022 16:00:53 +0000 (UTC) Received: by mail-ed1-x536.google.com with SMTP id w4so24804083edc.7 for ; Tue, 15 Mar 2022 09:00:53 -0700 (PDT) Message-ID: Date: Tue, 15 Mar 2022 18:00:43 +0200 MIME-Version: 1.0 Content-Language: en-US To: Jeevan B , igt-dev@lists.freedesktop.org References: <20220309164452.8240-1-jeevan.b@intel.com> <20220309164452.8240-5-jeevan.b@intel.com> From: Juha-Pekka Heikkila In-Reply-To: <20220309164452.8240-5-jeevan.b@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [igt-dev] [PATCH i-g-t 4/5] tests/kms_draw_crc: Use 4 tiling when filling framebuffer List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: juhapekka.heikkila@gmail.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Reviewed-by: Juha-Pekka Heikkila On 9.3.2022 18.44, Jeevan B wrote: > From: Mika Kahola > > For platforms with 4 tiling, let's use 4 tiling instead of Y tiling. > > Signed-off-by: Mika Kahola > Signed-off-by: Jeevan B > --- > tests/i915/kms_draw_crc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/tests/i915/kms_draw_crc.c b/tests/i915/kms_draw_crc.c > index 33b7bdf4..33fefed4 100644 > --- a/tests/i915/kms_draw_crc.c > +++ b/tests/i915/kms_draw_crc.c > @@ -226,6 +226,7 @@ static void fill_fb_subtest(void) > int rc; > struct igt_fb fb; > igt_crc_t base_crc, crc; > + bool has_4tile = intel_get_device_info(intel_get_drm_devid(drm_fd))->has_4tile; > > igt_create_fb(drm_fd, ms.mode->hdisplay, ms.mode->vdisplay, > DRM_FORMAT_XRGB8888, DRM_FORMAT_MOD_LINEAR, &fb); > @@ -248,7 +249,9 @@ static void fill_fb_subtest(void) > igt_assert_crc_equal(&crc, &base_crc); > > if (intel_display_ver(intel_get_drm_devid(drm_fd)) >= 9) { > - get_fill_crc(I915_FORMAT_MOD_Y_TILED, &crc); > + get_fill_crc(has_4tile ? > + I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED, > + &crc); > igt_assert_crc_equal(&crc, &base_crc); > } >