Re: [PATCH i-g-t] tests/kms_content_protection: Add LIC Type 1 scenario

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Suraj,

On 16-Jan-24 3:04 PM, Nautiyal, Ankit K wrote:
> LGTM.
> 
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> 
> On 1/12/2024 4:03 PM, Suraj Kandpal wrote:
>> Currently LIC is done only for type0 content this patch
>> adds LIC for type1 content too.
>>
>> Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
>> ---
>>   tests/kms_content_protection.c | 16 ++++++++++++----
>>   1 file changed, 12 insertions(+), 4 deletions(-)
>>
>> diff --git a/tests/kms_content_protection.c 
>> b/tests/kms_content_protection.c
>> index 6d472ee02..38e4143c8 100644
>> --- a/tests/kms_content_protection.c
>> +++ b/tests/kms_content_protection.c
>> @@ -43,8 +43,11 @@
>>   #include "igt_kmod.h"
>>   /**
>> - * SUBTEST: lic
>> - * Description: Test for the integrity of link.
>> + * SUBTEST: lic-type-0
>> + * Description: Test for the integrity of link for type 0 content.
>> + *
>> + * SUBTEST: lic-type-1
>> + * Description: Test for the integrity of link for type 1 content.
>>    *

Instead if writing description like this you can add
lic-%arg[1]

@arg[1]:
@type0:		type-0
@type1:		type-1

Check this 
https://gitlab.freedesktop.org/drm/igt-gpu-tools/-/blob/master/docs/test_documentation.md?ref_type=heads

And functionality for both these tests will be hdcp1.4. Is this correct?
Or do we need to add hdcp2.2 too?
Please update functionality.

>>    * SUBTEST: content-type-change
>>    * Description: Test the content type change when the content 
>> protection already
>> @@ -783,11 +786,16 @@ static const struct {
>>         .cp_tests = CP_DPMS,
>>         .content_type = HDCP_CONTENT_TYPE_0
>>       },
>> -    { .desc = "Test for the integrity of link.",
>> -      .name = "lic",
>> +    { .desc = "Test for the integrity of link with type 0 content.",
>> +      .name = "lic-type-0",
>>         .cp_tests = CP_LIC,
>>         .content_type = HDCP_CONTENT_TYPE_0,
>>       },
>> +    { .desc = "Test for the integrity of link with type 1 content",
>> +      .name = "lic-type-1",
>> +      .cp_tests = CP_LIC,
>> +      .content_type = HDCP_CONTENT_TYPE_1,
>> +    },
>>       { .desc = "Test content protection with content type 1 "
>>             "that can be handled only through HDCP2.2.",
>>         .name = "type1",