Re: [igt-dev] [PATCH i-g-t v2 0/7] removal of igt_skip_on_simulation() from i915/ tests

["Summers, Stuart" <stuart.summers@intel.com>]

[-- Attachment #1.1: Type: text/plain, Size: 7151 bytes --]

On Mon, 2019-12-02 at 11:31 +0530, Swati Sharma wrote:
> Removing igt_skip_on_simulation() since this feature is not supported
> anymore by i915 driver. Removing it from gem, kms, i915 specific, 

Can you be a little more specific about why we need to do this? Which
support was removed? Or is it simply that we're relying more on the IGT
infrastructure, i.e. skip, require_platform, etc, to determine whether
a test should be run in a particular environment?

Thanks,
Stuart

> tools
> and benchmark tests.
> 
> Swati Sharma (7):
>   tests/i915/gem: remove igt_skip_on_simulation()
>   tests/i915/kms: remove igt_skip_on_simulation()
>   tests/i915: remove igt_skip_on_simulation()
>   tests: remove igt_skip_on_simulation()
>   tools: remove igt_skip_on_simulation()
>   benchmarks: remove igt_skip_on_simulation()
>   lib: remove igt_skip_on_simulation
> 
>  benchmarks/gem_userptr_benchmark.c          | 2 --
>  lib/igt_aux.c                               | 7 -------
>  lib/intel_os.c                              | 2 --
>  tests/debugfs_test.c                        | 2 --
>  tests/i915/gem_busy.c                       | 2 --
>  tests/i915/gem_caching.c                    | 2 --
>  tests/i915/gem_concurrent_all.c             | 2 --
>  tests/i915/gem_create.c                     | 2 --
>  tests/i915/gem_cs_prefetch.c                | 2 --
>  tests/i915/gem_cs_tlb.c                     | 2 --
>  tests/i915/gem_ctx_exec.c                   | 2 --
>  tests/i915/gem_ctx_switch.c                 | 6 ------
>  tests/i915/gem_ctx_thrash.c                 | 2 --
>  tests/i915/gem_double_irq_loop.c            | 2 --
>  tests/i915/gem_eio.c                        | 2 --
>  tests/i915/gem_exec_async.c                 | 2 --
>  tests/i915/gem_exec_balancer.c              | 2 --
>  tests/i915/gem_exec_blt.c                   | 2 --
>  tests/i915/gem_exec_capture.c               | 2 --
>  tests/i915/gem_exec_fence.c                 | 2 --
>  tests/i915/gem_exec_gttfill.c               | 2 --
>  tests/i915/gem_exec_lut_handle.c            | 2 --
>  tests/i915/gem_exec_schedule.c              | 2 --
>  tests/i915/gem_exec_suspend.c               | 2 --
>  tests/i915/gem_fence_thrash.c               | 2 --
>  tests/i915/gem_fence_upload.c               | 2 --
>  tests/i915/gem_fenced_exec_thrash.c         | 2 --
>  tests/i915/gem_flink_race.c                 | 2 --
>  tests/i915/gem_gtt_cpu_tlb.c                | 2 --
>  tests/i915/gem_gtt_hog.c                    | 2 --
>  tests/i915/gem_gtt_speed.c                  | 2 --
>  tests/i915/gem_largeobject.c                | 2 --
>  tests/i915/gem_madvise.c                    | 2 --
>  tests/i915/gem_mmap_offset_exhaustion.c     | 2 --
>  tests/i915/gem_partial_pwrite_pread.c       | 2 --
>  tests/i915/gem_persistent_relocs.c          | 2 --
>  tests/i915/gem_pread_after_blit.c           | 2 --
>  tests/i915/gem_pwrite_pread.c               | 2 --
>  tests/i915/gem_pwrite_snooped.c             | 2 --
>  tests/i915/gem_read_read_speed.c            | 2 --
>  tests/i915/gem_readwrite.c                  | 2 --
>  tests/i915/gem_reloc_vs_gpu.c               | 2 --
>  tests/i915/gem_render_linear_blits.c        | 3 ---
>  tests/i915/gem_render_tiled_blits.c         | 3 ---
>  tests/i915/gem_reset_stats.c                | 1 -
>  tests/i915/gem_ringfill.c                   | 2 --
>  tests/i915/gem_set_tiling_vs_blt.c          | 2 --
>  tests/i915/gem_set_tiling_vs_gtt.c          | 2 --
>  tests/i915/gem_set_tiling_vs_pwrite.c       | 2 --
>  tests/i915/gem_shrink.c                     | 2 --
>  tests/i915/gem_softpin.c                    | 2 --
>  tests/i915/gem_spin_batch.c                 | 2 --
>  tests/i915/gem_stolen.c                     | 2 --
>  tests/i915/gem_storedw_batches_loop.c       | 2 --
>  tests/i915/gem_sync.c                       | 2 --
>  tests/i915/gem_threaded_access_tiled.c      | 2 --
>  tests/i915/gem_tiled_fence_blits.c          | 3 ---
>  tests/i915/gem_tiled_partial_pwrite_pread.c | 2 --
>  tests/i915/gem_unfence_active_buffers.c     | 2 --
>  tests/i915/gem_unref_active_buffers.c       | 2 --
>  tests/i915/gem_wait.c                       | 2 --
>  tests/i915/gem_write_read_ring_switch.c     | 2 --
>  tests/i915/i915_hangman.c                   | 2 --
>  tests/i915/i915_pm_backlight.c              | 2 --
>  tests/i915/i915_pm_dc.c                     | 1 -
>  tests/i915/i915_pm_rc6_residency.c          | 2 --
>  tests/i915/i915_pm_rps.c                    | 2 --
>  tests/i915/i915_pm_sseu.c                   | 3 ---
>  tests/i915/i915_suspend.c                   | 2 --
>  tests/kms_atomic_interruptible.c            | 2 --
>  tests/kms_atomic_transition.c               | 2 --
>  tests/kms_available_modes_crc.c             | 2 --
>  tests/kms_big_fb.c                          | 2 --
>  tests/kms_busy.c                            | 2 --
>  tests/kms_chamelium.c                       | 2 --
>  tests/kms_color.c                           | 2 --
>  tests/kms_concurrent.c                      | 2 --
>  tests/kms_content_protection.c              | 2 --
>  tests/kms_crtc_background_color.c           | 2 --
>  tests/kms_cursor_crc.c                      | 2 --
>  tests/kms_cursor_edge_walk.c                | 2 --
>  tests/kms_fence_pin_leak.c                  | 2 --
>  tests/kms_flip_event_leak.c                 | 2 --
>  tests/kms_flip_tiling.c                     | 2 --
>  tests/kms_invalid_dotclock.c                | 2 --
>  tests/kms_legacy_colorkey.c                 | 2 --
>  tests/kms_mmap_write_crc.c                  | 2 --
>  tests/kms_panel_fitting.c                   | 2 --
>  tests/kms_pipe_b_c_ivb.c                    | 2 --
>  tests/kms_pipe_crc_basic.c                  | 2 --
>  tests/kms_plane.c                           | 2 --
>  tests/kms_plane_cursor.c                    | 2 --
>  tests/kms_plane_lowres.c                    | 2 --
>  tests/kms_plane_multiple.c                  | 2 --
>  tests/kms_plane_scaling.c                   | 2 --
>  tests/kms_properties.c                      | 2 --
>  tests/kms_psr.c                             | 2 --
>  tests/kms_psr2_su.c                         | 2 --
>  tests/kms_pwrite_crc.c                      | 2 --
>  tests/kms_rmfb.c                            | 2 --
>  tests/kms_rotation_crc.c                    | 2 --
>  tests/kms_sequence.c                        | 2 --
>  tests/kms_setmode.c                         | 2 --
>  tests/kms_universal_plane.c                 | 2 --
>  tests/kms_vblank.c                          | 2 --
>  tests/kms_vrr.c                             | 2 --
>  tests/perf.c                                | 2 --
>  tests/prime_busy.c                          | 1 -
>  tests/prime_mmap_kms.c                      | 2 --
>  tests/prime_udl.c                           | 2 --
>  tests/testdisplay.c                         | 1 -
>  tests/tools_test.c                          | 2 --
>  tools/intel_dp_compliance.c                 | 2 --
>  113 files changed, 235 deletions(-)
> 

[-- Attachment #1.2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3270 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev