Re: [igt-dev] [PATCH i-g-t v2] gitlab-ci: add build for MIPS

Arkadiusz Hiler
2019-06-14T10:33:56Z

On Thu, Jun 13, 2019 at 03:01:06PM +0100, Guillaume Tucker wrote:
> Add Docker image and Gitlab CI steps to run builds for the MIPS
> architecture using Debian Stretch with backports.
>
> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
> ---
> .gitlab-ci.yml | 28 ++++++++++++++++++++++++++++
> Dockerfile.debian-mips | 39 +++++++++++++++++++++++++++++++++++++++
> meson-cross-mips.txt | 12 ++++++++++++
> 3 files changed, 79 insertions(+)
> create mode 100644 Dockerfile.debian-mips
> create mode 100644 meson-cross-mips.txt
>
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index 771143a9ea95..e390f8f472d5 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -90,6 +90,17 @@ build:tests-debian-meson-arm64:
> paths:
> - build
>
> +build:tests-debian-meson-mips:
> + image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-mips:latest
> + stage: build
> + script:
> + - export PKG_CONFIG_PATH=/usr/lib/mips-linux-gnu/pkgconfig/
> + - meson --cross-file meson-cross-mips.txt build
> + - ninja -C build
> + artifacts:
> + paths:
> + - build
> +
> build:tests-debian-autotools:
> image: $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian:latest
> stage: build
> @@ -221,6 +232,23 @@ containers:igt-debian-arm64:
> - docker build -t $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-arm64 -f Dockerfile.debian-arm64 .
> - docker push $CI_REGISTRY/$CI_PROJECT_PATH/igt-debian-arm64

Any particular reason for not having ninja-test step for MIPS?

Other than that (and Petri's concern, since I don't speak Debian),
looks good.

- Arek