From: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH 00/76] Ensure that file descriptors will be closed on exit
Date: Mon, 26 Sep 2022 08:17:05 +0200 [thread overview]
Message-ID: <cover.1664173031.git.mchehab@kernel.org> (raw)
From: Mauro Carvalho Chehab <mchehab@kernel.org>
GCC is usually smart enough to close devices on exit, but that doesn't work
with the logic inside igt_skip(), as it uses longjmp, causing the code to
go out of scope. Such scoped variables must be tracked in an outer scope to
the skipping subtest.
Change the logic on IGT tests in order to avoid keeping device opened at
the end of the test.
Chris Wilson (76):
lib: Introduce typed cleanups
i915/gem_basic: Close device before exit
i915/gem_flink_basic: Close device before exit
i915/gem_linear_blits: Close device before exit
i915/gem_blits: Close device before exit
i915/gem_close: Close device before exit
i915/gem_create: Close device before exit
i915/gem_ctx_engines: Close device before exit
i915/gem_ctx_shared: Close device before exit
i915/gem_exec_alignment: Close device before exit
i915/gem_render_copy: Close device before exit
i915/gem_render_copy_redux: Close device before exit
i915/gem_media_fill: Close device before exit
i915/gem_userptr_blits: Close device before exit
i915/gem_workarounds: Close device before exit
i915/gem_unref_active_buffers: Close device before exit
i915/gem_exec_endless: Close device before exit
i915/gem_request_retire: Close device before exit
i915/gem_unfence_active_buffers: Close device before exit
i915/i915_pciid: Close device before exit
kms_cursor_legacy: Close device before exit
kms_flip: Close device before exit
kms_pipe_crc_basic: Close device before exit
kms_psr: Close device before exit
kms_flip: Close device before exit
kms_force_connector_basic: Close device before exit
dumb_buffer: Close device before exit
kms_atomic: Close device before exit
kms_atomic_interruptible: Close device before exit
kms_atomic_transition: Close device before exit
i915/kms_big_fb: Close device before exit
i915/kms_ccs: Close device before exit
kms_color: Close device before exit
kms_cursor_crc: Close device before exit
i915/kms_big_joiner: Close device before exit
i915/kms_cdclk: Close device before exit
i915/kms_fence_pin_leak: Close device before exit
i915/kms_flip_scaled_crc: Close device before exit
i915/kms_flip_tiling: Close device before exit
i915/kms_mmap_write_crc: Close device before exit
i915/kms_pipe_b_c_ivb: Close device before exit
i915/kms_psr2_sf: Close device before exit
i915/kms_psr2_su: Close device before exit
i915/kms_pwrite_crc: Close device before exit
kms_flip_event_leak: Close device before exit
kms_hdr: Close device before exit
kms_invalid_mode: Close device before exit
kms_panel_fitting: Close device before exit
kms_plane: Close device before exit
kms_plane_alpha_blend: Close device before exit
kms_plane_cursor: Close device before exit
kms_plane_multiple: Close device before exit
kms_plane_scaling: Close device before exit
kms_properties: Close device before exit
kms_rotation_crc: Close device before exit
kms_sequence: Close device before exit
kms_universal_plane: Close device before exit
kms_vblank: Close device before exit
syncobj_wait: Close device before exit
syncobj_basic: Close device before exit
syncobj_timeline: Close device before exit
drm_import_export: Close device before exit
kms_dp_aux_dev: Close device before exit
kms_hdmi_inject: Close device before exit
kms_3d: Close device before exit
kms_scaling_modes: Close device before exit
kms_dither: Close device before exit
drm_read: Close device before exit
kms_cursor_edge_walk: Close device before exit
kms_plane_lowres: Close device before exit
kms_content_protection: Close device before exit
feature_discovery: Close device before exit
i915/i915_pm_dc: Close device before exit
core_auth: Close(master) before exit
i915/gem_exec_balancer: Close device before exit
i915/gem_ctx_isolation: Close device before exit
lib/igt_core.c | 6 ++
lib/igt_core.h | 2 +
lib/igt_types.c | 17 +++
lib/igt_types.h | 47 ++++++++
lib/meson.build | 1 +
lib/tests/bad_subtest_type.c | 19 ++++
lib/tests/igt_types.c | 136 ++++++++++++++++++++++++
lib/tests/meson.build | 2 +
tests/core_auth.c | 8 +-
tests/drm_import_export.c | 5 +
tests/drm_read.c | 4 +-
tests/dumb_buffer.c | 4 +
tests/feature_discovery.c | 5 +-
tests/i915/gem_basic.c | 8 +-
tests/i915/gem_blits.c | 1 +
tests/i915/gem_close.c | 3 +-
tests/i915/gem_create.c | 3 +-
tests/i915/gem_ctx_engines.c | 3 +-
tests/i915/gem_ctx_isolation.c | 3 +-
tests/i915/gem_ctx_shared.c | 3 +-
tests/i915/gem_exec_alignment.c | 3 +-
tests/i915/gem_exec_balancer.c | 3 +-
tests/i915/gem_exec_endless.c | 3 +-
tests/i915/gem_flink_basic.c | 11 +-
tests/i915/gem_linear_blits.c | 3 +-
tests/i915/gem_media_fill.c | 1 +
tests/i915/gem_render_copy.c | 1 +
tests/i915/gem_render_copy_redux.c | 4 +
tests/i915/gem_request_retire.c | 5 +-
tests/i915/gem_unfence_active_buffers.c | 1 +
tests/i915/gem_unref_active_buffers.c | 1 +
tests/i915/gem_userptr_blits.c | 4 +-
tests/i915/gem_workarounds.c | 3 +-
tests/i915/i915_pciid.c | 2 +
tests/i915/i915_pm_dc.c | 1 +
tests/i915/kms_big_fb.c | 1 +
tests/i915/kms_big_joiner.c | 1 +
tests/i915/kms_busy.c | 1 +
tests/i915/kms_ccs.c | 4 +-
tests/i915/kms_cdclk.c | 1 +
tests/i915/kms_fence_pin_leak.c | 1 +
tests/i915/kms_flip_scaled_crc.c | 1 +
tests/i915/kms_flip_tiling.c | 1 +
tests/i915/kms_mmap_write_crc.c | 1 +
tests/i915/kms_pipe_b_c_ivb.c | 1 +
tests/i915/kms_psr.c | 1 +
tests/i915/kms_psr2_sf.c | 1 +
tests/i915/kms_psr2_su.c | 1 +
tests/i915/kms_pwrite_crc.c | 1 +
tests/kms_3d.c | 1 +
tests/kms_atomic.c | 1 +
tests/kms_atomic_interruptible.c | 1 +
tests/kms_atomic_transition.c | 1 +
tests/kms_color.c | 1 +
tests/kms_content_protection.c | 1 +
tests/kms_cursor_crc.c | 1 +
tests/kms_cursor_edge_walk.c | 4 +-
tests/kms_cursor_legacy.c | 1 +
tests/kms_dither.c | 1 +
tests/kms_dp_aux_dev.c | 1 +
tests/kms_flip.c | 3 +
tests/kms_flip_event_leak.c | 1 +
tests/kms_force_connector_basic.c | 7 +-
tests/kms_hdmi_inject.c | 1 +
tests/kms_hdr.c | 1 +
tests/kms_invalid_mode.c | 1 +
tests/kms_panel_fitting.c | 4 +-
tests/kms_pipe_crc_basic.c | 1 +
tests/kms_plane.c | 1 +
tests/kms_plane_alpha_blend.c | 1 +
tests/kms_plane_cursor.c | 1 +
tests/kms_plane_lowres.c | 4 +-
tests/kms_plane_multiple.c | 4 +-
tests/kms_plane_scaling.c | 4 +-
tests/kms_properties.c | 1 +
tests/kms_rotation_crc.c | 1 +
tests/kms_scaling_modes.c | 4 +-
tests/kms_sequence.c | 4 +
tests/kms_universal_plane.c | 1 +
tests/kms_vblank.c | 4 +
tests/syncobj_basic.c | 4 +
tests/syncobj_timeline.c | 4 +
tests/syncobj_wait.c | 4 +
83 files changed, 385 insertions(+), 33 deletions(-)
create mode 100644 lib/igt_types.c
create mode 100644 lib/igt_types.h
create mode 100644 lib/tests/bad_subtest_type.c
create mode 100644 lib/tests/igt_types.c
--
2.37.3
next reply other threads:[~2022-09-26 6:18 UTC|newest]
Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 6:17 Mauro Carvalho Chehab [this message]
2022-09-26 6:17 ` [igt-dev] [PATCH 01/76] lib: Introduce typed cleanups Mauro Carvalho Chehab
[not found] ` <YzcISxi01TrOL4aU@kamilkon-desk1>
2022-10-05 6:44 ` Mauro Carvalho Chehab
[not found] ` <10813270.BaYr0rKQ5T@jkrzyszt-mobl1.ger.corp.intel.com>
2022-10-05 7:41 ` Mauro Carvalho Chehab
[not found] ` <Yz02HL4ue1N1O4hi@zkempczy-mobl2>
2022-10-05 8:02 ` Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 02/76] i915/gem_basic: Close device before exit Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 03/76] i915/gem_flink_basic: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 04/76] i915/gem_linear_blits: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 05/76] i915/gem_blits: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 06/76] i915/gem_close: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 07/76] i915/gem_create: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 08/76] i915/gem_ctx_engines: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 09/76] i915/gem_ctx_shared: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 10/76] i915/gem_exec_alignment: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 11/76] i915/gem_render_copy: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 12/76] i915/gem_render_copy_redux: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 13/76] i915/gem_media_fill: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 14/76] i915/gem_userptr_blits: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 15/76] i915/gem_workarounds: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 16/76] i915/gem_unref_active_buffers: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 17/76] i915/gem_exec_endless: " Mauro Carvalho Chehab
[not found] ` <YzbgHzTKxDBM9DjG@kamilkon-desk1>
2022-10-05 6:23 ` Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 18/76] i915/gem_request_retire: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 19/76] i915/gem_unfence_active_buffers: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 20/76] i915/i915_pciid: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 21/76] kms_cursor_legacy: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 22/76] kms_flip: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 23/76] kms_pipe_crc_basic: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 24/76] kms_psr: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 25/76] kms_flip: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 26/76] kms_force_connector_basic: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 27/76] dumb_buffer: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 28/76] kms_atomic: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 29/76] kms_atomic_interruptible: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 30/76] kms_atomic_transition: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 31/76] i915/kms_big_fb: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 32/76] i915/kms_ccs: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 33/76] kms_color: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 34/76] kms_cursor_crc: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 35/76] i915/kms_big_joiner: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 36/76] i915/kms_cdclk: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 37/76] i915/kms_fence_pin_leak: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 38/76] i915/kms_flip_scaled_crc: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 39/76] i915/kms_flip_tiling: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 40/76] i915/kms_mmap_write_crc: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 41/76] i915/kms_pipe_b_c_ivb: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 42/76] i915/kms_psr2_sf: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 43/76] i915/kms_psr2_su: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 44/76] i915/kms_pwrite_crc: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 45/76] kms_flip_event_leak: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 46/76] kms_hdr: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 47/76] kms_invalid_mode: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 48/76] kms_panel_fitting: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 49/76] kms_plane: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 50/76] kms_plane_alpha_blend: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 51/76] kms_plane_cursor: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 52/76] kms_plane_multiple: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 53/76] kms_plane_scaling: " Mauro Carvalho Chehab
2022-09-26 6:17 ` [igt-dev] [PATCH 54/76] kms_properties: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 55/76] kms_rotation_crc: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 56/76] kms_sequence: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 57/76] kms_universal_plane: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 58/76] kms_vblank: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 59/76] syncobj_wait: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 60/76] syncobj_basic: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 61/76] syncobj_timeline: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 62/76] drm_import_export: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 63/76] kms_dp_aux_dev: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 64/76] kms_hdmi_inject: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 65/76] kms_3d: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 66/76] kms_scaling_modes: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 67/76] kms_dither: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 68/76] drm_read: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 69/76] kms_cursor_edge_walk: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 70/76] kms_plane_lowres: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 71/76] kms_content_protection: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 72/76] feature_discovery: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 73/76] i915/i915_pm_dc: " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 74/76] core_auth: Close(master) " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 75/76] i915/gem_exec_balancer: Close device " Mauro Carvalho Chehab
2022-09-26 6:18 ` [igt-dev] [PATCH 76/76] i915/gem_ctx_isolation: " Mauro Carvalho Chehab
[not found] ` <4844cbbf-7add-216d-38f8-4e8c903c06a5@linux.intel.com>
2022-09-30 12:38 ` [igt-dev] [PATCH 00/76] Ensure that file descriptors will be closed on exit Das, Nirmoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1664173031.git.mchehab@kernel.org \
--to=mauro.chehab@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox