From: Karolina Stolarek <karolina.stolarek@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v3 0/6] Introduce blt_cmd_info struct
Date: Wed, 11 Jan 2023 09:44:12 +0100 [thread overview]
Message-ID: <cover.1673426099.git.karolina.stolarek@intel.com> (raw)
This patch series introduces a new way of checking if a specific
tiling format and/or blitter copy command is supported on
the current platform. Instead of using functions with hardcoded
devices, now we store information about available features in
blt_cmd_info struct, each of the instances connected to the
intel_device_info definitions.
Two patches that follow the introduction of blt_cmd_info and
intel_device_info modification are a prep work for the fast
copy test -- extracting needed functions and updating
fill_data() to support TileYF (available only for Pre-gen12).
In addition to this, the patchset adds two fast copy tests: basic
fast-copy where two blit copies are done in separate batches, and
fast-copy-emit which uses emit_blt_fast_copy() and manually
crafts two copies in one batch.
v3 builds on the changes introduced in v2 and changes how
blt_tiling_type is defined. Now it's a contiguous enum, and the flags
used in .supported_tiling are built with a bit macro on the fly.
v3:
- Rewrite blt_tiling_type to be contiguous (Zbigniew, Kamil)
- Add BLT_BIT macro to create bit flags during .supported_tiling
field initialization (Zbigniew)
- Undo accidental line deletion in intel_chipset.c (Kamil)
- Add __TILING_MAX to blt_tiling_type (Zbigniew)
- Use asprintf when creating strings of subtest and PNG files
names (Zbigniew)
- Delete a duplicate WRITE_PNG call in fast_copy test (Zbigniew)
- Update documentation
- Update year in copyright headers
v2:
- Add documentation
- Rename blt_tiling to intel_blt_info to better capture the
nature of the library (Zbigniew)
- Rename "can" predicates for blitter commands to use "has"
(Kamil)
- Add a fast copy test with two copies in the same batch buffer
- Add blt_ prefixes to functions extracted from gem_ccs to
avoid name clash (Zbigniew/Kamil)
- Also move set_object_ext() out from gem_ccs so it can be
shared with other tests
- Significantly rewrite intel_blt_info library -- now it only
exposes blt_cmd_supports_tiling and blt_supports_command
and blt_cmd_info definitions that can be used by other
blitter libraries like i915_blt.
- Split introduction of intel_blt_info and usage of the struct
into two commits
- Add functions checking fast and block copy support to
i915_blt library
- Add reference to blt_cmd_info to intel_device_info definitions
(Zbigniew)
- Update commit messages (Kamil)
Karolina Stolarek (6):
i915/lib: Add new library for blitter and tiling formats
lib: Update platform definitions with blitter information
lib/i915_blt: Check for Tile-YF in fast_copy
lib/i915_blt: Add common functions for blt_copy_object
tests/gem_exercise_blt: Add fast-copy test
tests/gem_exercise_blt: Add fast-copy-emit test
.../igt-gpu-tools/igt-gpu-tools-docs.xml | 1 +
lib/i915/i915_blt.c | 195 +++++++--
lib/i915/i915_blt.h | 48 ++-
lib/i915/intel_blt_info.c | 248 +++++++++++
lib/i915/intel_blt_info.h | 96 +++++
lib/intel_chipset.h | 4 +
lib/intel_device_info.c | 47 +++
lib/meson.build | 1 +
tests/i915/gem_ccs.c | 209 +++-------
tests/i915/gem_exercise_blt.c | 387 ++++++++++++++++++
tests/i915/gem_lmem_swapping.c | 81 +---
tests/meson.build | 1 +
12 files changed, 1055 insertions(+), 263 deletions(-)
create mode 100644 lib/i915/intel_blt_info.c
create mode 100644 lib/i915/intel_blt_info.h
create mode 100644 tests/i915/gem_exercise_blt.c
--
2.25.1
next reply other threads:[~2023-01-11 8:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-11 8:44 Karolina Stolarek [this message]
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 1/6] i915/lib: Add new library for blitter and tiling formats Karolina Stolarek
2023-01-11 16:42 ` Kamil Konieczny
2023-01-12 8:24 ` Karolina Stolarek
2023-01-12 9:35 ` Karolina Stolarek
2023-01-12 10:43 ` Petri Latvala
2023-01-12 13:51 ` Karolina Stolarek
2023-01-12 11:28 ` Kamil Konieczny
2023-01-13 18:40 ` Zbigniew Kempczyński
2023-01-16 8:33 ` Karolina Stolarek
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 2/6] lib: Update platform definitions with blitter information Karolina Stolarek
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 3/6] lib/i915_blt: Check for Tile-YF in fast_copy Karolina Stolarek
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 4/6] lib/i915_blt: Add common functions for blt_copy_object Karolina Stolarek
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 5/6] tests/gem_exercise_blt: Add fast-copy test Karolina Stolarek
2023-01-11 8:44 ` [igt-dev] [PATCH i-g-t v3 6/6] tests/gem_exercise_blt: Add fast-copy-emit test Karolina Stolarek
2023-01-17 7:28 ` Zbigniew Kempczyński
2023-01-11 12:24 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce blt_cmd_info struct (rev3) Patchwork
2023-01-11 15:21 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1673426099.git.karolina.stolarek@intel.com \
--to=karolina.stolarek@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox