From: Karolina Stolarek <karolina.stolarek@intel.com>
To: igt-dev@lists.freedesktop.org
Subject: [igt-dev] [PATCH i-g-t v2 0/6] Extend and rename intel_tiling_info library
Date: Wed, 8 Feb 2023 14:47:33 +0100 [thread overview]
Message-ID: <cover.1675854161.git.karolina.stolarek@intel.com> (raw)
As for now, there is no central place that provides information on
command properties such as compression support or if the command
requires any additional setup. It is possible to modify the already
existing library, intel_tiling_info, and add such information there.
The series adds a new field to better describe blitter commands,
which stores bit flags describing properties. Flags defined as a part
of the series mostly target the block-copy command, as its features
vary the most between generations. The introduction of the field is
followed by an update of DG2 and MTL definitions and gem_ccs test.
This change means that intel_tiling_info library stores more than
just information on tiling formats. As keeping a tiling-specific
name would confuse users, we update the struct names as well as
the library name itself. Each of the renames happens in a separate
commit.
To summarize the name update:
- intel_tiling_info lib ---> intel_cmds_info lib
- blt_cmd_info struct ---> blt_cmds_desc struct
- blt_tiling_info struct ---> blt_cmd_info struct
Although the proposed change was expanded so much that it could be
a standalone series, I decided to label it v2 to link to the work
I sent as a single patch in [1].
v2:
- Rename the library and its structs to better describe what
they store
- Stop using has_flatccs field when checking if a command
can use compression; use blt_cmd_info flags field instead
- Update the name of blt_tiling field in intel_device_info,
as it describes more than just a list of supported tiling
formats
- Drop additional macros for DG2 and MTL definitions
[1] - https://patchwork.freedesktop.org/series/113595/
Karolina Stolarek (6):
lib/intel_tiling_info: Rename blt_cmd_info to blt_cmds_desc
lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info
lib/i915: Rename intel_tiling_info library
lib/intel_cmds_info: Add flags field to describe command properties
lib/i915_blt: Add checks for command properties
tests/gem_ccs: Check for extended block-copy and compression support
lib/i915/i915_blt.c | 112 +++++++++++++-----
lib/i915/i915_blt.h | 15 ++-
...{intel_tiling_info.c => intel_cmds_info.c} | 58 +++++----
...{intel_tiling_info.h => intel_cmds_info.h} | 22 ++--
lib/intel_chipset.h | 6 +-
lib/intel_device_info.c | 64 +++++-----
lib/meson.build | 6 +-
tests/i915/gem_ccs.c | 7 +-
8 files changed, 184 insertions(+), 106 deletions(-)
rename lib/i915/{intel_tiling_info.c => intel_cmds_info.c} (57%)
rename lib/i915/{intel_tiling_info.h => intel_cmds_info.h} (53%)
--
2.25.1
next reply other threads:[~2023-02-08 13:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 13:47 Karolina Stolarek [this message]
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 1/6] lib/intel_tiling_info: Rename blt_cmd_info to blt_cmds_desc Karolina Stolarek
2023-02-09 7:30 ` Zbigniew Kempczyński
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 2/6] lib/intel_tiling_info: Rename blt_tiling_info to blt_cmd_info Karolina Stolarek
2023-02-09 7:52 ` Zbigniew Kempczyński
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 3/6] lib/i915: Rename intel_tiling_info library Karolina Stolarek
2023-02-09 7:55 ` Zbigniew Kempczyński
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 4/6] lib/intel_cmds_info: Add flags field to describe command properties Karolina Stolarek
2023-02-09 7:57 ` Zbigniew Kempczyński
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 5/6] lib/i915_blt: Add checks for " Karolina Stolarek
2023-02-08 13:47 ` [igt-dev] [PATCH i-g-t v2 6/6] tests/gem_ccs: Check for extended block-copy and compression support Karolina Stolarek
2023-02-08 18:56 ` [igt-dev] ✓ Fi.CI.BAT: success for Extend and rename intel_tiling_info library Patchwork
2023-02-09 6:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1675854161.git.karolina.stolarek@intel.com \
--to=karolina.stolarek@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox