Re: [PATCH i-g-t 00/16] igt: clean up typedef usage, use for_each_output() more

Ville Syrjälä
2026-04-14T14:09:03Z

On Tue, Apr 14, 2026 at 10:14:20AM +0300, Jani Nikula wrote:
> This series spiraled into a few things:
>
> - use typedefs like igt_foo_t more consistently instead of struct
> igt_foo

I'm not a huge fan of the typedefs but getting rid of them now
would involve a gargantuan patch. So best to just accept them
I guess.

Series is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

>
> - rename the structs to have underscore prefix to discourage usage like
> struct _igt_foo
>
> - convert open coded output loops to use for_each_output()
>
> BR,
> Jani.
>
> Jani Nikula (16):
> tests: prefer igt_plane_t over struct igt_plane
> lib/kms: rename struct igt_plane to _igt_plane
> tests: prefer igt_display_t over struct igt_display
> lib/kms: rename struct igt_display to _igt_display
> lib/kms: rename struct igt_crtc to _igt_crtc
> lib/kms: drop struct igt_colorop definition
> tests/amdgpu/amd_abm: use for_each_output()
> tests/amdgpu/amd_hotplug: use for_each_output()
> tests/amdgpu/amd_subvp: use for_each_output()
> tests/amdgpu/amd_dp_dsc: use for_each_output()
> tests/amdgpu/amd_plane: use for_each_output()
> tests/kms_atomic_transition: use for_each_output()
> tests/kms_colorop: use for_each_output()
> tests/kms_content_protection: use for_each_output()
> tests/kms_getfb: use for_each_output()
> tests/kms_writeback: use for_each_output()
>
> lib/igt_kms.c | 2 +-
> lib/igt_kms.h | 16 ++++++++--------
> tests/amdgpu/amd_abm.c | 8 ++++----
> tests/amdgpu/amd_dp_dsc.c | 10 ++++++----
> tests/amdgpu/amd_hotplug.c | 8 +++++---
> tests/amdgpu/amd_plane.c | 8 +++++---
> tests/amdgpu/amd_subvp.c | 9 +++++----
> tests/intel/kms_dp_link_training.c | 4 ++--
> tests/intel/kms_dp_linktrain_fallback.c | 12 ++++++------
> tests/kms_atomic_transition.c | 6 +++---
> tests/kms_colorop.c | 6 ++----
> tests/kms_content_protection.c | 6 +++---
> tests/kms_getfb.c | 13 +++++++------
> tests/kms_writeback.c | 10 ++++------
> 14 files changed, 61 insertions(+), 57 deletions(-)
>
> --
> 2.47.3

--
Ville Syrjälä
Intel