From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>, <ramanaidu.naladala@intel.com>,
<sameer.lattannavar@intel.com>
Subject: Re: [PATCH i-g-t v3 1/2] tests/kms_flip: Update the skip message
Date: Thu, 14 Nov 2024 12:02:45 +0530 [thread overview]
Message-ID: <d06c2684-dbf9-426b-90a6-34667904578f@intel.com> (raw)
In-Reply-To: <20241114051835.1860727-2-pranay.samala@intel.com>
LGTM
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
On 14-11-2024 10:48 am, Pranay Samala wrote:
> Debugging would be easier if we had logs available for
> test failures and skips. This patch rephrases the skip
> message for better understanding.
>
> v2:
> - Remove .c extension in the filename (Swati)
>
> v3:
> - Add changes made in previous version in commit message (Swati)
> - Editing hax patch
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
> ---
> tests/kms_flip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index cbabbe74f..88cd41083 100755
> --- a/tests/kms_flip.c
> +++ b/tests/kms_flip.c
> @@ -1896,7 +1896,7 @@ static void run_pair(int duration, int flags)
>
> /* If we have fewer than 2 connected outputs then we won't have any
> * configuration at all. So skip in that case. */
> - igt_require_f(modes, "At least two displays required\n");
> + igt_require_f(modes, "At least two displays with same modes are required\n");
>
> if (duration) {
> duration = duration * 1000 / modes;
next prev parent reply other threads:[~2024-11-14 6:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 5:18 [PATCH i-g-t v3 0/2] tests/kms_flip: Update the skip message Pranay Samala
2024-11-14 5:18 ` [PATCH i-g-t v3 1/2] " Pranay Samala
2024-11-14 6:32 ` Sharma, Swati2 [this message]
2024-11-14 5:18 ` [PATCH i-g-t v3 2/2] HAX: Do not merge Pranay Samala
2024-11-14 6:15 ` ✗ CI.xeBAT: failure for tests/kms_flip: Update the skip message Patchwork
2024-11-14 6:25 ` ✗ Fi.CI.BAT: " Patchwork
2024-11-14 15:48 ` ✗ CI.xeFULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d06c2684-dbf9-426b-90a6-34667904578f@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=pranay.samala@intel.com \
--cc=ramanaidu.naladala@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox