Re: [PATCH i-g-t 1/1] tests/chamelium/kms_chamelium_frames: add intel related yuv restrictions

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi JP,

If you check randomize_plane_coordinates()

we already have fallback to align YUV to even if random config fails.

However, your patch enabled pre-alignment. Can you please check once?

On 16-03-2026 09:41 pm, Juha-Pekka Heikkila wrote:
> Add intel hw yuv related restriction handling; 16bpp yuv formats
> need to be set at even coordinates and even width. Palanar formats
> need to be at even x/y coordinates and even width/height
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>   tests/chamelium/kms_chamelium_frames.c | 33 +++++++++++++++++++++++++-
>   1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/tests/chamelium/kms_chamelium_frames.c b/tests/chamelium/kms_chamelium_frames.c
> index efd9ff1b7..404e32b87 100644
> --- a/tests/chamelium/kms_chamelium_frames.c
> +++ b/tests/chamelium/kms_chamelium_frames.c
> @@ -333,6 +333,21 @@ static void randomize_plane_setup(chamelium_data_t *data, igt_plane_t *plane,
>   
>   	*width = max((rand() % mode->hdisplay) + 1, 2 * min_dim);
>   	*height = max((rand() % mode->vdisplay) + 1, 2 * min_dim);
> +
> +	/*
> +	 * intel related restrictions for yuv; 16bpp yuv formats have to be
> +	 * even horizontal width/xposition. Planar yuv formats have to be
> +	 * even horizontal/vertical sizes/coordinates.
> +	 */
> +	if (is_intel_device(data->drm_fd)) {
> +		if (*format == DRM_FORMAT_YUYV || *format == DRM_FORMAT_YVYU ||
> +		    *format == DRM_FORMAT_UYVY || *format == DRM_FORMAT_VYUY)
> +			*width &= ~1;
> +		if (igt_format_is_yuv_semiplanar(*format)) {
> +			*width &= ~1;
> +			*height &= ~1;
> +		}
> +	}
>   }
>   
>   static void configure_plane(igt_plane_t *plane, uint32_t src_w, uint32_t src_h,
> @@ -355,7 +370,8 @@ static void randomize_plane_coordinates(
>   	uint32_t *src_y, uint32_t *crtc_w, uint32_t *crtc_h, int32_t *crtc_x,
>   	int32_t *crtc_y, bool allow_scaling)
>   {
> -	bool is_yuv = igt_format_is_yuv(fb->drm_format);
> +	uint32_t format = fb->drm_format;
> +	bool is_yuv = igt_format_is_yuv(format);
>   	uint32_t width = fb->width, height = fb->height;
>   	double ratio;
>   	int ret;
> @@ -364,6 +380,21 @@ static void randomize_plane_coordinates(
>   	*src_x = rand() % (width / 2);
>   	*src_y = rand() % (height / 2);
>   
> +	/*
> +	 * intel related restrictions for yuv; 16bpp yuv formats have to be
> +	 * even horizontal width/xposition. Planar yuv formats have to be
> +	 * even horizontal/vertical sizes/coordinates.
> +	 */
> +	if (is_intel_device(data->drm_fd)) {
> +		if (format == DRM_FORMAT_YUYV || format == DRM_FORMAT_YVYU ||
> +		    format == DRM_FORMAT_UYVY || format == DRM_FORMAT_VYUY)
> +			*src_x &= ~1;
> +		if (igt_format_is_yuv_semiplanar(format)) {
> +			*src_x &= ~1;
> +			*src_y &= ~1;
> +		}
> +	}
> +
>   	/* The source size only includes the active source area. */
>   	*src_w = width - *src_x;
>   	*src_h = height - *src_y;