From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] Fixup clang compiler warnings.
Date: Mon, 31 May 2021 14:18:24 +0200 [thread overview]
Message-ID: <d0d6b74b-fb74-57bb-5cd2-ec1bb52eedcf@linux.intel.com> (raw)
In-Reply-To: <YLTFtxka3CyIrIH4@platvala-desk.ger.corp.intel.com>
Op 31-05-2021 om 13:17 schreef Petri Latvala:
> On Mon, May 31, 2021 at 12:51:38PM +0200, Maarten Lankhorst wrote:
>> Allows building cleanly with clang again. It complains about using
>> invalid initialisers like char[][] = { 0 }.
>>
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> lib/igt_kms.c | 2 +-
>> lib/igt_nouveau.c | 2 +-
>> tests/i915/gem_exec_fence.c | 4 ++--
>> 3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index 28fb9c094eb2..fb7a14f940ea 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -292,7 +292,7 @@ struct edid **igt_kms_get_tiled_edid(uint8_t htile, uint8_t vtile)
>> {
>> uint8_t top[2];
>> int edids, i;
>> - static char raw_edid[MAX_EDID][256] = {0};
>> + static char raw_edid[MAX_EDID][256] = {{0}};
> Can't this be {} ?
>
>
If you make this a r-b. Sure!
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-05-31 12:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 10:51 [igt-dev] [PATCH i-g-t] Fixup clang compiler warnings Maarten Lankhorst
2021-05-31 11:17 ` Petri Latvala
2021-05-31 12:18 ` Maarten Lankhorst [this message]
2021-05-31 12:26 ` Petri Latvala
2021-05-31 12:32 ` Maarten Lankhorst
2021-05-31 11:54 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-05-31 14:39 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0d6b74b-fb74-57bb-5cd2-ec1bb52eedcf@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox