From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FB7910E39C for ; Tue, 26 Sep 2023 10:27:54 +0000 (UTC) Message-ID: Date: Tue, 26 Sep 2023 15:57:47 +0530 MIME-Version: 1.0 Content-Language: en-US From: "Sharma, Swati2" To: Nemesa Garg , igt-dev@lists.freedesktop.org References: <20230922161302.440145-1-nemesa.garg@intel.com> <32a7249f-a61d-c3bf-d397-5eb38d0e1c65@intel.com> In-Reply-To: <32a7249f-a61d-c3bf-d397-5eb38d0e1c65@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [igt-dev] [PATCH] tests/kms_rmfb: Add check for xe driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: Also, add closes tag in the commit. On 26-Sep-23 3:56 PM, Sharma, Swati2 wrote: > Hi Nemesa, > > Can you please add this test in fast-feedback and add as HAX patch, > to check CI results. > > On 22-Sep-23 9:43 PM, Nemesa Garg wrote: >> As the xe check is missing the value of open_count >> variable is not incrementing and because of this >> during drm_close_driver operation based on open_count >> value mutex is acquired and there is a callback to >> lastclose function. >> >> Signed-off-by: Nemesa Garg >> --- >>   lib/drmtest.c | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/drmtest.c b/lib/drmtest.c >> index e1da66c87..99b655680 100644 >> --- a/lib/drmtest.c >> +++ b/lib/drmtest.c >> @@ -649,7 +649,7 @@ int drm_open_driver(int chipset) >>        * starting a test and we install an exit handler to wait until >>        * idle before quitting. >>        */ >> -    if (is_i915_device(fd)) { >> +    if (is_i915_device(fd) || is_xe_device(fd)) { >>           if (__sync_fetch_and_add(&open_count, 1) == 0) { >>               __cancel_work_at_exit(fd); >>               at_exit_drm_fd = drm_reopen_driver(fd);