From: "Joshi, Kunal1" <kunal1.joshi@intel.com>
To: "Murthy, Arun R" <arun.r.murthy@intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [i-g-t,6/6] tests/intel/kms_usb4_switch: Add USB4 switch test suite
Date: Mon, 9 Mar 2026 16:44:22 +0530 [thread overview]
Message-ID: <d250bf1f-2d0e-493c-9000-b344d2a6371f@intel.com> (raw)
In-Reply-To: <d5d123a9-5559-4d08-a696-c499a656607e@intel.com>
[-- Attachment #1: Type: text/plain, Size: 772 bytes --]
Hello Arun,
On 09-03-2026 15:33, Murthy, Arun R wrote:
>> +static void test_switch_sr(data_t *data,
>> + const struct usb4switch_port *port_cfg_a,
>> + const struct usb4switch_port *port_cfg_b)
>> +{
>> + igt_crc_t ref_crcs[MAX_DISPLAYS_PER_PORT];
>> + int iterations = usb4switch_get_iterations(data->sw);
>> + int timeout = USB4_SWITCH_TIMEOUT_S;
> Why not have it as a const or use the macro directly?
Kept it as a local alias since this pattern is used widely in IGT for
function-local knobs such as timeout/iterations/count, and it makes call
sites a bit easier to read when reused multiple times.
That said, since this one is not modified, I can make it const to
express that more clearly.
[-- Attachment #2: Type: text/html, Size: 1338 bytes --]
next prev parent reply other threads:[~2026-03-09 11:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-25 21:28 [PATCH i-g-t 0/6] add test to validate dock/undock and switch Kunal Joshi
2026-02-25 21:28 ` [PATCH i-g-t 1/6] lib/igt_edid: add EDID serial extraction helpers Kunal Joshi
2026-03-09 9:30 ` [i-g-t,1/6] " Murthy, Arun R
2026-03-09 11:02 ` Joshi, Kunal1
2026-03-16 3:03 ` Murthy, Arun R
2026-02-25 21:28 ` [PATCH i-g-t 2/6] lib/igt_connector_helper: Add generic connector helpers Kunal Joshi
2026-03-09 9:38 ` [i-g-t,2/6] " Murthy, Arun R
2026-03-09 11:06 ` Joshi, Kunal1
2026-03-16 3:17 ` Murthy, Arun R
2026-02-25 21:28 ` [PATCH i-g-t 3/6] lib/igt_serial: add generic serial communication helper Kunal Joshi
2026-03-16 5:40 ` [i-g-t,3/6] " Murthy, Arun R
2026-02-25 21:28 ` [PATCH i-g-t 4/6] lib/igt_usb4_switch: add helper library for USB4 Switch 3141 Kunal Joshi
2026-03-16 8:45 ` [i-g-t,4/6] " Murthy, Arun R
2026-02-25 21:28 ` [PATCH i-g-t 5/6] tests/kms_feature_discovery: add basic usb4 switch discovery Kunal Joshi
2026-03-09 10:05 ` [i-g-t,5/6] " Murthy, Arun R
2026-02-25 21:28 ` [PATCH i-g-t 6/6] tests/intel/kms_usb4_switch: Add USB4 switch test suite Kunal Joshi
2026-03-09 10:03 ` [i-g-t,6/6] " Murthy, Arun R
2026-03-09 11:14 ` Joshi, Kunal1 [this message]
2026-03-16 3:38 ` Murthy, Arun R
2026-02-26 2:20 ` ✗ Xe.CI.BAT: failure for add test to validate dock/undock and switch (rev3) Patchwork
2026-02-26 3:04 ` ✓ i915.CI.BAT: success " Patchwork
2026-02-26 6:52 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-02-26 7:45 ` ✗ i915.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d250bf1f-2d0e-493c-9000-b344d2a6371f@intel.com \
--to=kunal1.joshi@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox