Re: [PATCH i-g-t v2 0/6] RFC: Add attachments support

["Knop, Ryszard" <ryszard.knop@intel.com>]

Hey Zbigniew,

In general, I'm not convinced putting all attachments into the
results.json file is a good idea. This introduces a significant amount
of overhead for CI reporting processes that don't care about those
attachments (vis, CBL, JP Heikkila's SISO), makes those files extremely
large and difficult for manual inspection.

Can you consider specifying attachments as filenames that should be
present in a directory relative to the results.json instead?

Thanks, Ryszard

On Tue, 2026-03-24 at 14:12 +0100, Zbigniew Kempczyński wrote:
> This series introduces support for hook/test written attachments.
> It is somehow limited and stiff but allows to write anything test/hook
> wants to attachments directory and if naming contract will be fulfiled
> content in base64 form will be included in appropriate subtest/dynsubtest
> results.json part.
> 
> Series targets our need to include guc logs for failed tests especially
> in the point of time when it occurs.
> 
> v2: - added clearing of attachments dir in overwrite mode
>     - guc-log hook script is now installed to igt datadir/hooks dir
>     - added hook-exec-allowlist to selectively execute hook scripts
> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> Cc: Kamil Konieczny <kamil.konieczny@linux.intel.com>
> Cc: Ryszard Knop <ryszard.knop@intel.com>
> Cc: Gustavo Sousa <gustavo.sousa@intel.com>
> Cc: Krzysztof Karas <krzysztof.karas@intel.com>
> 
> Zbigniew Kempczyński (6):
>   runner: Rename dirfd to avoid clash with dirfd()
>   runner: Create attachments directory to use by hooks
>   runner: Add attachments directory content in subtests results
>   scripts/hooks: Example guc log copy script to attachments dir
>   runner: Rename parsing function
>   runner: Add hook-exec-allowlist to execute hooks selectively
> 
>  lib/igt_hook.c                    |  4 ++
>  runner/executor.c                 | 88 ++++++++++++++++++++++++----
>  runner/executor.h                 |  2 +
>  runner/resultgen.c                | 97 +++++++++++++++++++++++++++++++
>  runner/settings.c                 | 31 +++++++---
>  runner/settings.h                 |  2 +
>  scripts/hooks/guc_copy_on_fail.sh | 24 ++++++++
>  scripts/meson.build               |  2 +
>  8 files changed, 230 insertions(+), 20 deletions(-)
>  create mode 100755 scripts/hooks/guc_copy_on_fail.sh