From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-f196.google.com (mail-qt1-f196.google.com [209.85.160.196]) by gabe.freedesktop.org (Postfix) with ESMTPS id AACC9891C7 for ; Wed, 20 Feb 2019 19:28:49 +0000 (UTC) Received: by mail-qt1-f196.google.com with SMTP id j36so28582810qta.7 for ; Wed, 20 Feb 2019 11:28:49 -0800 (PST) Message-ID: From: Lyude Paul Date: Wed, 20 Feb 2019 14:28:46 -0500 In-Reply-To: <20190220153913.10753-4-paul.kocialkowski@bootlin.com> References: <20190220153913.10753-1-paul.kocialkowski@bootlin.com> <20190220153913.10753-4-paul.kocialkowski@bootlin.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v5 03/22] lib/igt_fb: Refactor create_bo_for_fb to prepare for VC4 support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Paul Kocialkowski , igt-dev@lists.freedesktop.org Cc: Petri Latvala , Eben Upton , Thomas Petazzoni List-ID: UmV2aWV3ZWQtYnk6IEx5dWRlIFBhdWwgPGx5dWRlQHJlZGhhdC5jb20+CgpPbiBXZWQsIDIwMTkt MDItMjAgYXQgMTY6MzggKzAxMDAsIFBhdWwgS29jaWFsa293c2tpIHdyb3RlOgo+IFRoZSBjdXJy ZW50IGNyZWF0ZV9ib19mb3JfZmIgdXNlcyBhIGRldmljZS1zcGVjaWZpYyBCTyBpbnN0ZWFkIG9m IGR1bWIKPiBhbGxvY2F0aW9uIHdoZW4gZHVtYiBhbGxvY2F0aW9uIGlzIG5vdCBhcHByb3ByaWF0 ZSBhbmQgdGhlIGRyaXZlciBpcwo+IEludGVsLiBUaGVuLCBpdCB3aWxsIGFzc2VydCB0aGF0IHRo ZSBwYXJhbWV0ZXJzIGFyZSBhcHByb3ByaWF0ZSBmb3IKPiBkdW1iIGFsbG9jYXRpb24uCj4gCj4g VGhlIGNvbmRpdGlvbnMgcmVsYXRlZCB0byB0aWxpbmcsIHNpemUgYW5kIHN0cmlkZSBhcmUgc3Vm ZmljaWVudCBmb3IKPiBuZWVkaW5nIGEgZGV2aWNlLXNwZWNpZmljIEJPIGFuZCB0aGV5IGFyZSBu b3Qgc3BlY2lmaWMgdG8gSW50ZWwuCj4gSG93ZXZlciwgYSBkZXZpY2Utc3BlY2lmaWMgQk8gZm9y IFlVViBpcyBvbmx5IG5lZWRlZCBmb3IgSW50ZWwuCj4gCj4gQ2hhbmdlIHRoZSBjb25kaXRpb25z IGFjY29yZGluZ2x5IGFuZCBzZXQgYSBkZXZpY2VfYm8gdmFyaWFibGUuIFRoaXMKPiB2YXJpYWJs ZSBhbGxvd3MgbWFraW5nIGZiLT5zaXplIGNhbGN1bGF0aW9uIGNvbW1vbiBiZXR3ZWVuIHRoZQo+ IGRldmljZS1zcGVjaWZpYyBhbmQgZHVtYiBwYXRocy4gVXNlIHRoZSB2YXJpYWJsZSBhZnRlciB0 aGF0IGFuZAo+IGRpc3Rpbmd1aXNoIGJldHdlZW4gdGhlIGRldmljZSB0eXBlcyBmb3IgYWxsb2Nh dGluZyBhbmQgZXJyb3Igb3V0IGlmCj4gaXQncyBub3Qgc3VwcG9ydGVkLgo+IAo+IFRoaXMgbWFr ZXMgdGhlIGV4dHJhIGNoZWNrcyB0aGF0IGR1bWIgYWxsb2NhdGlvbiBpcyB2YWxpZCByZWR1bmRh bnQsCj4gc2luY2UgdGhlc2UgY2FzZXMgd2lsbCBhbHdheXMgZmFsbCB1bmRlciBkZXZpY2Utc3Bl Y2lmaWMgYWxsb2NhdGlvbgo+IGFuZCBwb3RlbnRpYWxseSBlcnJvciBvdXQgdGhlbi4KPiAKPiBT aWduZWQtb2ZmLWJ5OiBQYXVsIEtvY2lhbGtvd3NraSA8cGF1bC5rb2NpYWxrb3dza2lAYm9vdGxp bi5jb20+Cj4gLS0tCj4gIGxpYi9pZ3RfZmIuYyB8IDQzICsrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyks IDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ZiLmMgYi9saWIvaWd0 X2ZiLmMKPiBpbmRleCAwNThjZmFiNjA0YjguLjYwZTZiYjAwYjU1YyAxMDA2NDQKPiAtLS0gYS9s aWIvaWd0X2ZiLmMKPiArKysgYi9saWIvaWd0X2ZiLmMKPiBAQCAtNjEwLDM2ICs2MTAsMzcgQEAg c3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ICAJdW5zaWdu ZWQgaW50IGJwcCA9IDA7Cj4gIAl1bnNpZ25lZCBpbnQgcGxhbmU7Cj4gIAl1bnNpZ25lZCAqc3Ry aWRlcyA9ICZmYi0+c3RyaWRlc1swXTsKPiArCWJvb2wgZGV2aWNlX2JvID0gZmFsc2U7Cj4gIAlp bnQgZmQgPSBmYi0+ZmQ7Cj4gIAo+IC0JaWYgKGlzX2k5MTVfZGV2aWNlKGZkKSAmJgo+IC0JICAg KGZiLT50aWxpbmcgfHwgZmItPnNpemUgfHwgZmItPnN0cmlkZXNbMF0gfHwgaWd0X2Zvcm1hdF9p c195dXYoZmItCj4gPmRybV9mb3JtYXQpKSkgewo+IC0JCXVpbnQ2NF90IHNpemU7Cj4gLQo+IC0J CXNpemUgPSBjYWxjX2ZiX3NpemUoZmIpOwo+ICsJLyoKPiArCSAqIFRoZSBjdXJyZW50IGR1bWIg YnVmZmVyIGFsbG9jYXRpb24gQVBJIGRvZXNuJ3QgcmVhbGx5IGFsbG93IHRvCj4gKwkgKiBzcGVj aWZ5IGEgY3VzdG9tIHNpemUgb3Igc3RyaWRlLiBZZXQgdGhlIGNhbGxlciBpcyBmcmVlIHRvIHNw ZWNpZnkKPiArCSAqIHRoZW0sIHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHRvIHVzZSBhIGRldmlj ZSBCTyB0aGVuLgo+ICsJICovCj4gKwlpZiAoZmItPnRpbGluZyB8fCBmYi0+c2l6ZSB8fCBmYi0+ c3RyaWRlc1swXSB8fAo+ICsJICAgIChpc19pOTE1X2RldmljZShmZCkgJiYgaWd0X2Zvcm1hdF9p c195dXYoZmItPmRybV9mb3JtYXQpKSkKPiArCQlkZXZpY2VfYm8gPSB0cnVlOwo+ICAKPiAtCQkv KiByZXNwZWN0IHRoZSBzaXplIHJlcXVlc3RlZCBieSB0aGUgY2FsbGVyICovCj4gLQkJaWYgKGZi LT5zaXplID09IDApCj4gLQkJCWZiLT5zaXplID0gc2l6ZTsKPiArCS8qIFJlc3BlY3QgdGhlIHNp emUgcmVxdWVzdGVkIGJ5IHRoZSBjYWxsZXIuICovCj4gKwlpZiAoZmItPnNpemUgPT0gMCkKPiAr CQlmYi0+c2l6ZSA9IGNhbGNfZmJfc2l6ZShmYik7Cj4gIAo+ICsJaWYgKGRldmljZV9ibykgewo+ ICAJCWZiLT5pc19kdW1iID0gZmFsc2U7Cj4gLQkJZmItPmdlbV9oYW5kbGUgPSBnZW1fY3JlYXRl KGZkLCBmYi0+c2l6ZSk7Cj4gLQkJZ2VtX3NldF90aWxpbmcoZmQsIGZiLT5nZW1faGFuZGxlLAo+ IC0JCQkgICAgICAgaWd0X2ZiX21vZF90b190aWxpbmcoZmItPnRpbGluZyksCj4gLQkJCSAgICAg ICBmYi0+c3RyaWRlc1swXSk7Cj4gKwo+ICsJCWlmIChpc19pOTE1X2RldmljZShmZCkpIHsKPiAr CQkJZmItPmdlbV9oYW5kbGUgPSBnZW1fY3JlYXRlKGZkLCBmYi0+c2l6ZSk7Cj4gKwkJCWdlbV9z ZXRfdGlsaW5nKGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiArCQkJCSAgICAgICBpZ3RfZmJfbW9kX3Rv X3RpbGluZyhmYi0+dGlsaW5nKSwKPiArCQkJCSAgICAgICBmYi0+c3RyaWRlc1swXSk7Cj4gKwkJ fSBlbHNlIHsKPiArCQkJaWd0X2Fzc2VydChmYWxzZSk7Cj4gKwkJfQo+ICAKPiAgCQlnb3RvIG91 dDsKPiAgCX0KPiAgCj4gLQkvKgo+IC0JICogVGhlIGN1cnJlbnQgZHVtYiBidWZmZXIgYWxsb2Nh dGlvbiBBUEkgZG9lc24ndCByZWFsbHkgYWxsb3cgdG8KPiAtCSAqIHNwZWNpZnkgYSBjdXN0b20g c2l6ZSBvciBzdHJpZGUuIFlldCB0aGUgY2FsbGVyIGlzIGZyZWUgdG8gc3BlY2lmeQo+IC0JICog dGhlbSwgc28gd2UgbmVlZCB0byBtYWtlIHN1cmUgdG8gZXJyb3Igb3V0IGluIHRoaXMgY2FzZS4K PiAtCSAqLwo+IC0JaWd0X2Fzc2VydChmYi0+c2l6ZSA9PSAwKTsKPiAtCWlndF9hc3NlcnQoZmIt PnN0cmlkZXNbMF0gPT0gMCk7Cj4gLQo+IC0JZmItPnNpemUgPSBjYWxjX2ZiX3NpemUoZmIpOwo+ ICAJZm9yIChwbGFuZSA9IDA7IHBsYW5lIDwgZmItPm51bV9wbGFuZXM7IHBsYW5lKyspCj4gIAkJ YnBwICs9IERJVl9ST1VORF9VUChmYi0+cGxhbmVfYnBwW3BsYW5lXSwKPiAgCQkJCSAgICBwbGFu ZSA/IGZtdC0+aHN1YiAqIGZtdC0+dnN1YiA6IDEpOwotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2