From: "Kahola, Mika" <mika.kahola@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled: on mode selection choose mode with lowest vertical refresh
Date: Tue, 2 Feb 2021 11:03:38 +0000 [thread overview]
Message-ID: <d322e6ad5fa34951b21da9bfbe324036@intel.com> (raw)
In-Reply-To: <20210201184041.30451-1-juhapekka.heikkila@gmail.com>
> -----Original Message-----
> From: igt-dev <igt-dev-bounces@lists.freedesktop.org> On Behalf Of Juha-
> Pekka Heikkila
> Sent: Monday, February 1, 2021 8:41 PM
> To: igt-dev@lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled: on mode selection
> choose mode with lowest vertical refresh
>
> Use mode with lowest vertical refresh to keep needed cdclk down.
>
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
> ---
> tests/kms_flip_scaled_crc.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_flip_scaled_crc.c b/tests/kms_flip_scaled_crc.c index
> f77484063..c41709b68 100644
> --- a/tests/kms_flip_scaled_crc.c
> +++ b/tests/kms_flip_scaled_crc.c
> @@ -174,9 +174,12 @@ static void test_flip_to_scaled(data_t *data,
> uint32_t index, enum pipe pipe,
> for (int i = 0; i < output->config.connector->count_modes; i++) {
> if (output->config.connector->modes[i].hdisplay == data-
> >attemptmodewidth &&
> output->config.connector->modes[i].vdisplay == data-
> >attemptmodeheight) {
> + if (modetoset &&
> + modetoset->vrefresh < output->config.connector-
> >modes[i].vrefresh)
> + continue;
> +
> modetoset = &output->config.connector->modes[i];
> - break;
> - }
> + }
> }
>
> if (!modetoset)
> --
> 2.28.0
>
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2021-02-02 11:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-01 18:40 [igt-dev] [PATCH i-g-t] tests/kms_flip_scaled: on mode selection choose mode with lowest vertical refresh Juha-Pekka Heikkila
2021-02-01 19:36 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-02 1:20 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2021-02-02 11:03 ` Kahola, Mika [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d322e6ad5fa34951b21da9bfbe324036@intel.com \
--to=mika.kahola@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox