Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Karthik B S <karthik.b.s@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <sameer.lattannavar@intel.com>,
	Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
Subject: Re: [PATCH i-g-t] tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms
Date: Wed, 26 Jun 2024 11:13:06 +0530	[thread overview]
Message-ID: <d3770d78-3334-47a3-a439-a6b1e4f684a3@intel.com> (raw)
In-Reply-To: <20240621043248.612664-1-pranay.samala@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1268 bytes --]


On 6/21/2024 10:02 AM, Pranay Samala wrote:
> The getfb2-accept-ccs subtest tests on ccs modifiers.
> With Xe2 platforms we no more have the ccs modifiers.
>
> Adding a check to verify the platform. If it is
> Xe2 platform then test will skip, otherwise it
> will execute further.
>
> Signed-off-by: Pranay Samala<pranay.samala@intel.com>
> ---
>   tests/kms_getfb.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/tests/kms_getfb.c b/tests/kms_getfb.c
> index bb9679bc9..81829ca3b 100644
> --- a/tests/kms_getfb.c
> +++ b/tests/kms_getfb.c
> @@ -161,6 +161,9 @@ static void get_ccs_fb(int fd, struct drm_mode_fb_cmd2 *ret)
>   	igt_require(has_addfb2_iface(fd));
>   	devid = intel_get_drm_devid(fd);
>   
> +	igt_require_f(intel_graphics_ver(devid) < 20,
> +		      "No ccs modifiers on Xe2\n");
> +

Hi Pranay,

I see that getfb tests are skipping on legacy platforms with this patch.
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11292/index.html?testfilter=kms_getfb

This should be resolved by replacing 'intel_graphics_ver' with 
'intel_display_ver'. Could you please update this.

Thanks,
Karthik.B.S
>   	if (HAS_FLATCCS(devid)) {
>   		add.modifier[0] = I915_FORMAT_MOD_4_TILED_DG2_RC_CCS;
>   		add.pitches[0] = ALIGN(add.width * 4, 4 * 512);

[-- Attachment #2: Type: text/html, Size: 2425 bytes --]

  parent reply	other threads:[~2024-06-26  5:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21  4:32 [PATCH i-g-t] tests/kms_getfb: Skip getfb2-accept-ccs subtest on Xe2 platforms Pranay Samala
2024-06-21  5:31 ` ✓ CI.xeBAT: success for " Patchwork
2024-06-21  6:03 ` ✓ Fi.CI.BAT: " Patchwork
2024-06-21  6:58 ` ✗ CI.xeFULL: failure " Patchwork
2024-06-21 11:36   ` Kamil Konieczny
2024-06-22  5:37 ` ✗ Fi.CI.IGT: " Patchwork
2024-06-25 10:08 ` [PATCH i-g-t] " Juha-Pekka Heikkila
2024-06-26  5:43 ` Karthik B S [this message]
2024-06-26  8:43   ` Juha-Pekka Heikkila
2024-06-26  9:14     ` Karthik B S

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d3770d78-3334-47a3-a439-a6b1e4f684a3@intel.com \
    --to=karthik.b.s@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    --cc=pranay.samala@intel.com \
    --cc=sameer.lattannavar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox