From: Jani Nikula <jani.nikula@intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
igt-dev@lists.freedesktop.org
Subject: Re: [PATCH i-g-t v2 13/23] tests/intel/kms_psr2_sf: Convert pipes[] to crtcs[]
Date: Tue, 24 Feb 2026 11:09:43 +0200 [thread overview]
Message-ID: <d379053c2f71247fbc67c777ffd0b515b490bf8c@intel.com> (raw)
In-Reply-To: <20260221032003.30936-14-ville.syrjala@linux.intel.com>
On Sat, 21 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Convert the pipes[] array to crtcs[] in kms_psr2_sf. The
> remainder of the pipe->crtc conversions will be handled
> with cocci.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> tests/intel/kms_psr2_sf.c | 66 +++++++++++++++++++--------------------
> 1 file changed, 33 insertions(+), 33 deletions(-)
>
> diff --git a/tests/intel/kms_psr2_sf.c b/tests/intel/kms_psr2_sf.c
> index f79d9b0b751e..ff63a3c84f10 100644
> --- a/tests/intel/kms_psr2_sf.c
> +++ b/tests/intel/kms_psr2_sf.c
> @@ -1157,8 +1157,8 @@ int igt_main()
> data_t data = {};
> igt_output_t *outputs[IGT_MAX_PIPES * IGT_MAX_PIPES];
> int i, y, z;
> - int pipes[IGT_MAX_PIPES * IGT_MAX_PIPES];
> - int n_pipes = 0;
> + igt_crtc_t *crtcs[IGT_MAX_PIPES * IGT_MAX_PIPES];
> + int n_crtcs = 0;
> int coexist_features[IGT_MAX_PIPES * IGT_MAX_PIPES];
I wonder what the deal with the IGT_MAX_PIPES^2 is. It's completely
unnecessary. But not part of this patch, so *shrug*.
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> const char *append_fbc_subtest[2] = {
> "",
> @@ -1212,14 +1212,14 @@ int igt_main()
> if (!output_supports_pr_psr2_sel_fetch)
> continue;
>
> - pipes[n_pipes] = data.pipe;
> - outputs[n_pipes] = data.output;
> + crtcs[n_crtcs] = crtc;
> + outputs[n_crtcs] = data.output;
>
> - coexist_features[n_pipes] = 0;
> + coexist_features[n_crtcs] = 0;
> if (is_dsc_supported_by_sink(data.drm_fd, data.output))
> - coexist_features[n_pipes] |= FEATURE_DSC;
> + coexist_features[n_crtcs] |= FEATURE_DSC;
>
> - n_pipes++;
> + n_crtcs++;
> pr_psr2_sel_fetch_supported = true;
> }
> igt_require_f(pr_psr2_sel_fetch_supported,
> @@ -1244,8 +1244,8 @@ int igt_main()
> append_fbc_subtest[y],
> append_psr_subtest[z],
> op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1265,8 +1265,8 @@ int igt_main()
> append_fbc_subtest[y],
> append_psr_subtest[z],
> op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1286,8 +1286,8 @@ int igt_main()
> append_fbc_subtest[y],
> append_psr_subtest[z],
> op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1303,8 +1303,8 @@ int igt_main()
> igt_describe("Test that selective fetch works on cursor plane");
> igt_subtest_with_dynamic_f("%s%scursor-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1320,8 +1320,8 @@ int igt_main()
> "moving cursor plane (no update)");
> igt_subtest_with_dynamic_f("%s%scursor-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1337,8 +1337,8 @@ int igt_main()
> "plane exceeding partially visible area (no update)");
> igt_subtest_with_dynamic_f("%s%scursor-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1354,8 +1354,8 @@ int igt_main()
> "exceeding fully visible area (no update)");
> igt_subtest_with_dynamic_f("%s%scursor-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1372,8 +1372,8 @@ int igt_main()
> igt_describe("Test that selective fetch works on moving overlay plane");
> igt_subtest_with_dynamic_f("%s%s%s-sf-dmg-area", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1388,8 +1388,8 @@ int igt_main()
> "plane (no update)");
> igt_subtest_with_dynamic_f("%s%soverlay-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1405,8 +1405,8 @@ int igt_main()
> "plane partially exceeding visible area (no update)");
> igt_subtest_with_dynamic_f("%s%soverlay-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1422,8 +1422,8 @@ int igt_main()
> "fully exceeding visible area (no update)");
> igt_subtest_with_dynamic_f("%s%soverlay-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1440,8 +1440,8 @@ int igt_main()
> "with blended overlay plane");
> igt_subtest_with_dynamic_f("%s%s%s-sf-dmg-area", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
> @@ -1460,8 +1460,8 @@ int igt_main()
> igt_describe("Test that selective fetch works on overlay plane");
> igt_subtest_with_dynamic_f("%s%soverlay-%s-sf", append_fbc_subtest[y],
> append_psr_subtest[z], op_str(data.op)) {
> - for (i = 0; i < n_pipes; i++) {
> - data.pipe = pipes[i];
> + for (i = 0; i < n_crtcs; i++) {
> + data.pipe = crtcs[i]->pipe;
> data.output = outputs[i];
>
> if (!pipe_output_combo_valid(&data))
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-02-24 9:09 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 3:19 [PATCH i-g-t v2 00/23] tests/kms: More igt_crtc_t conversions Ville Syrjala
2026-02-21 3:19 ` [PATCH i-g-t v2 01/23] tests/intel/kms_psr: Don't pass uninitialized 'pipe' to intel_fbc_supported_on_chipset() Ville Syrjala
2026-02-23 11:22 ` Jani Nikula
2026-02-24 7:28 ` Ville Syrjälä
2026-02-23 11:23 ` Jani Nikula
2026-02-23 12:01 ` Jani Nikula
2026-02-24 8:49 ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24 8:53 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 02/23] tests/intel/kms_psr2_sf: Don't pass zero initialized 'data.pipe' " Ville Syrjala
2026-02-24 8:51 ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24 8:56 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 03/23] tests/intel/kms_flip_scaled_crc: Remove unused 'enum pipe pipe' Ville Syrjala
2026-02-23 11:34 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 04/23] tests/kms_concurrent: Actually run the test over all connected crtcs Ville Syrjala
2026-02-23 3:09 ` Karthik B S
2026-02-21 3:19 ` [PATCH i-g-t v2 05/23] tests/amdgpu/amd_abm: Don't use uninitialized 'pipe' Ville Syrjala
2026-02-24 14:08 ` Jani Nikula
2026-02-25 9:18 ` Ville Syrjälä
2026-02-21 3:19 ` [PATCH i-g-t v2 06/23] tests/kms: Use 'enum pipe' over int' Ville Syrjala
2026-02-23 11:44 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 07/23] lib/kms: Add igt_crtc_for_crtc_id() Ville Syrjala
2026-02-23 11:46 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 08/23] tests/kms_lease: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-23 11:48 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 09/23] tests/kms_lease: Pass lease_t to prepare_crtc() Ville Syrjala
2026-02-23 11:49 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 10/23] tests/intel/kms_frontbuffer_tracking: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-23 11:52 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 11/23] tests/kms_plane_scaling: " Ville Syrjala
2026-02-23 14:06 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 12/23] tests/drm_read: " Ville Syrjala
2026-02-24 8:58 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 13/23] tests/intel/kms_psr2_sf: Convert pipes[] to crtcs[] Ville Syrjala
2026-02-24 9:09 ` Jani Nikula [this message]
2026-02-21 3:19 ` [PATCH i-g-t v2 14/23] tests/kms_vblank: Use igt_crtc_t instead of enum pipe Ville Syrjala
2026-02-24 13:43 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 15/23] tests/kms_plane_multiple: " Ville Syrjala
2026-02-24 13:48 ` Jani Nikula
2026-02-25 7:44 ` Ville Syrjälä
2026-02-21 3:19 ` [PATCH i-g-t v2 16/23] tests/kms_tiled_display: " Ville Syrjala
2026-02-24 13:48 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 17/23] tests/intel/kms_psr: " Ville Syrjala
2026-02-24 13:49 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 18/23] tests/kms_prime: " Ville Syrjala
2026-02-24 13:50 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 19/23] tests/chamelium: " Ville Syrjala
2026-02-24 13:51 ` Jani Nikula
2026-02-21 3:19 ` [PATCH i-g-t v2 20/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 1 Ville Syrjala
2026-02-24 13:56 ` Jani Nikula
2026-02-21 3:20 ` [PATCH i-g-t v2 21/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 2 Ville Syrjala
2026-02-24 13:58 ` Jani Nikula
2026-02-21 3:20 ` [PATCH i-g-t v2 22/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 3 Ville Syrjala
2026-02-24 8:51 ` [PATCH i-g-t v3 " Ville Syrjala
2026-02-24 14:04 ` Jani Nikula
2026-02-21 3:20 ` [PATCH i-g-t v2 23/23] tests/kms: Use igt_crtc_t instead of enum pipe, part 4 Ville Syrjala
2026-02-24 14:06 ` Jani Nikula
2026-02-21 3:59 ` ✓ Xe.CI.BAT: success for tests/kms: More igt_crtc_t conversions (rev2) Patchwork
2026-02-21 4:13 ` ✓ i915.CI.BAT: " Patchwork
2026-02-21 16:12 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-23 13:25 ` ✗ Xe.CI.FULL: " Patchwork
2026-02-24 12:43 ` ✓ Xe.CI.BAT: success for tests/kms: More igt_crtc_t conversions (rev5) Patchwork
2026-02-24 12:58 ` ✓ i915.CI.BAT: " Patchwork
2026-02-24 18:52 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-24 22:57 ` ✓ Xe.CI.FULL: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d379053c2f71247fbc67c777ffd0b515b490bf8c@intel.com \
--to=jani.nikula@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox