From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.bootlin.com (mail.bootlin.com [62.4.15.54]) by gabe.freedesktop.org (Postfix) with ESMTP id A0B606E936 for ; Mon, 14 Jan 2019 15:13:03 +0000 (UTC) Message-ID: From: Paul Kocialkowski Date: Mon, 14 Jan 2019 16:13:02 +0100 In-Reply-To: <20190110143854.GX20097@intel.com> References: <20190108152001.5367-4-maxime.ripard@bootlin.com> <20190110143854.GX20097@intel.com> Mime-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v2 04/13] igt: fb: Move i915 YUV buffer clearing code to a function List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: Petri Latvala , eben@raspberrypi.org, igt-dev@lists.freedesktop.org, Thomas Petazzoni List-ID: SGksCgpPbiBUaHUsIDIwMTktMDEtMTAgYXQgMTY6MzggKzAyMDAsIFZpbGxlIFN5cmrDpGzDpCB3 cm90ZToKPiBPbiBUaHUsIEphbiAxMCwgMjAxOSBhdCAxMToxMDowOUFNICswMTAwLCBQYXVsIEtv Y2lhbGtvd3NraSB3cm90ZToKPiA+IE9uIFR1ZSwgMjAxOS0wMS0wOCBhdCAxNjoxOSArMDEwMCwg TWF4aW1lIFJpcGFyZCB3cm90ZToKPiA+ID4gVGhlIFlVViBidWZmZXIgYWxsb2NhdGlvbiBwYXRo IGZvciB0aGUgaTkxNSBkcml2ZXIgYWxzbyBoYXMgc29tZSBjb2RlIHRvCj4gPiA+IGNsZWFyIGEg WVVWIGJ1ZmZlci4KPiA+ID4gCj4gPiA+IEFzIHRoYXQgaXMgZ29pbmcgdG8gYmUgdXNlZnVsIGZv ciBhbGwgdGhlIG90aGVyIGRyaXZlcnMsIGxldCdzIG1vdmUgaXQgdG8KPiA+ID4gYSBzZXBhcmF0 ZSBmdW5jdGlvbi4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IE1heGltZSBSaXBhcmQgPG1h eGltZS5yaXBhcmRAYm9vdGxpbi5jb20+Cj4gPiAKPiA+IEknbSBub3QgcmVhbGx5IHN1cmUgd2h5 IGNsZWFyaW5nIHRoZSBidWZmZXJzIGlzIGEgdXNlZnVsIHRoaW5nIHRvIGRvCj4gPiBhbmQgd2h5 IHdlIHNob3VsZCBvbmx5IGRvIGl0IGZvciBZVVYgYW5kIG5vdCBSR0IgZm9ybWF0cy4KPiAKPiAw ID0gYmxhY2sgZm9yIFJHQiwgMCAhPSBibGFjayBmb3IgWVVWLiBUaGUgbWVtc2V0IHdhcyBqdXN0 IHRvIG1ha2UKPiB0aGluZ3MgbW9yZSBjb25zaXN0ZW50LiBCdXQgbm90IHN1cmUgaWYgYW55IHRl c3Qgd291bGQgYWN0dWFsbHkKPiBmYWlsIGlmIHdlIGp1c3QgZHJvcCB0aGUgbWVtc2V0LgoKUmln aHQsIEkgdW5kZXJzdGFuZCB0aGF0IHRoaXMgaXMgcmVxdWlyZWQgZm9yIHNldHRpbmcgdGhlIGZy YW1lYnVmZmVyCnRvIGJsYWNrLCBidXQgSSdtIGp1c3Qgd29uZGVyaW5nIHdoeSB0aGlzIGhhcyB0 byBiZSBkb25lIGluIHRoZSBmaXJzdApwbGFjZS4KCkFzIGZhciBhcyBJIGtub3csIChSR0IpIGJ1 ZmZlcnMgYWxsb2NhdGVkIHdpdGggR0VNIGFyZSBub3QgemVyby1lZCBieQp0aGUgYWxsb2NhdG9y LCBub3IgYnkgYW55IGNvbXBvbmVudCBpbiBJR1QuIFNvIEknbSB3b25kZXJpbmcgd2h5IHdlJ3Jl CnRha2luZyB0aGUgZXh0cmEgdGltZSBmb3IgY2xlYXJpbmcgYnVmZmVycyBpbiB0aGUgWVVWIGNh c2UuCgpDaGVlcnMsCgpQYXVsCgo+ID4gQW55d2F5LCBzaW5jZSB0aGlzIGNvZGUgd2FzIGFscmVh ZHkgdGhlcmUgYW5kIHRoZSByZWZhY3RvcmluZwo+ID4gZGVmaW5pdGVseSBtYWtlcyBzZW5zZToK PiA+IAo+ID4gUmV2aWV3ZWQtYnk6IFBhdWwgS29jaWFsa293c2tpIDxwYXVsLmtvY2lhbGtvd3Nr aUBib290bGluLmNvbT4KPiA+IAo+ID4gQ2hlZXJzLAo+ID4gCj4gPiBQYXVsCj4gPiAKPiA+ID4g LS0tCj4gPiA+ICBsaWIvaWd0X2ZiLmMgfCA4MCArKysrKysrKysrKysrKysrKysrKysrKysrKyst LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+ICAxIGZpbGUgY2hhbmdlZCwgNDIgaW5zZXJ0 aW9ucygrKSwgMzggZGVsZXRpb25zKC0pCj4gPiA+IAo+ID4gPiBkaWZmIC0tZ2l0IGEvbGliL2ln dF9mYi5jIGIvbGliL2lndF9mYi5jCj4gPiA+IGluZGV4IDQ1NjkxZmQ0NDFkOS4uZDY5YzNmYjJk MzhkIDEwMDY0NAo+ID4gPiAtLS0gYS9saWIvaWd0X2ZiLmMKPiA+ID4gKysrIGIvbGliL2lndF9m Yi5jCj4gPiA+IEBAIC00ODQsNiArNDg0LDQ3IEBAIHVpbnQ2NF90IGlndF9mYl90aWxpbmdfdG9f bW9kKHVpbnQ2NF90IHRpbGluZykKPiA+ID4gIAl9Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0 YXRpYyB2b2lkIGNsZWFyX3l1dl9idWZmZXIoc3RydWN0IGlndF9mYiAqZmIpCj4gPiA+ICt7Cj4g PiA+ICsJYm9vbCBmdWxsX3JhbmdlID0gZmItPmNvbG9yX3JhbmdlID09IElHVF9DT0xPUl9ZQ0JD Ul9GVUxMX1JBTkdFOwo+ID4gPiArCXZvaWQgKnB0cjsKPiA+ID4gKwo+ID4gPiArCWlndF9hc3Nl cnQoaWd0X2Zvcm1hdF9pc195dXYoZmItPmRybV9mb3JtYXQpKTsKPiA+ID4gKwo+ID4gPiArCS8q IEVuc3VyZSB0aGUgZnJhbWVidWZmZXIgaXMgcHJlYWxsb2NhdGVkICovCj4gPiA+ICsJcHRyID0g aWd0X2ZiX21hcF9idWZmZXIoZmItPmZkLCBmYik7Cj4gPiA+ICsJaWd0X2Fzc2VydCgqKHVpbnQz Ml90ICopcHRyID09IDApOwo+ID4gPiArCj4gPiA+ICsJc3dpdGNoIChmYi0+ZHJtX2Zvcm1hdCkg ewo+ID4gPiArCWNhc2UgRFJNX0ZPUk1BVF9OVjEyOgo+ID4gPiArCQltZW1zZXQocHRyICsgZmIt Pm9mZnNldHNbMF0sCj4gPiA+ICsJCSAgICAgICBmdWxsX3JhbmdlID8gMHgwMCA6IDB4MTAsCj4g PiA+ICsJCSAgICAgICBmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0pOwo+ID4g PiArCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMV0sCj4gPiA+ICsJCSAgICAgICAweDgwLAo+ ID4gPiArCQkgICAgICAgZmItPnN0cmlkZXNbMV0gKiBmYi0+cGxhbmVfaGVpZ2h0WzFdKTsKPiA+ ID4gKwkJYnJlYWs7Cj4gPiA+ICsJY2FzZSBEUk1fRk9STUFUX1hZVVY4ODg4Ogo+ID4gPiArCQl3 bWVtc2V0KHB0ciArIGZiLT5vZmZzZXRzWzBdLCBmdWxsX3JhbmdlID8gMHgwMDAwODA4MCA6IDB4 MDAxMDgwODAsCj4gPiA+ICsJCQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0g LyBzaXplb2Yod2NoYXJfdCkpOwo+ID4gPiArCQlicmVhazsKPiA+ID4gKwljYXNlIERSTV9GT1JN QVRfWVVZVjoKPiA+ID4gKwljYXNlIERSTV9GT1JNQVRfWVZZVToKPiA+ID4gKwkJd21lbXNldChw dHIgKyBmYi0+b2Zmc2V0c1swXSwKPiA+ID4gKwkJCWZ1bGxfcmFuZ2UgPyAweDgwMDA4MDAwIDog MHg4MDEwODAxMCwKPiA+ID4gKwkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFsw XSAvIHNpemVvZih3Y2hhcl90KSk7Cj4gPiA+ICsJCWJyZWFrOwo+ID4gPiArCWNhc2UgRFJNX0ZP Uk1BVF9VWVZZOgo+ID4gPiArCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ID4gPiArCQl3bWVtc2V0 KHB0ciArIGZiLT5vZmZzZXRzWzBdLAo+ID4gPiArCQkJZnVsbF9yYW5nZSA/IDB4MDA4MDAwODAg OiAweDEwODAxMDgwLAo+ID4gPiArCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVfaGVpZ2h0 WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ID4gKwkJYnJlYWs7Cj4gPiA+ICsJfQo+ID4gPiAr Cj4gPiA+ICsJaWd0X2ZiX3VubWFwX2J1ZmZlcihmYiwgcHRyKTsKPiA+ID4gK30KPiA+ID4gKwo+ ID4gPiAgLyogaGVscGVycyB0byBjcmVhdGUgbmljZS1sb29raW5nIGZyYW1lYnVmZmVycyAqLwo+ ID4gPiAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9yX2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ID4g PiAgewo+ID4gPiBAQCAtNTAxLDUwICs1NDIsMTMgQEAgc3RhdGljIGludCBjcmVhdGVfYm9fZm9y X2ZiKHN0cnVjdCBpZ3RfZmIgKmZiKQo+ID4gPiAgCQlmYi0+aXNfZHVtYiA9IGZhbHNlOwo+ID4g PiAgCj4gPiA+ICAJCWlmIChpc19pOTE1X2RldmljZShmZCkpIHsKPiA+ID4gLQkJCXZvaWQgKnB0 cjsKPiA+ID4gLQkJCWJvb2wgZnVsbF9yYW5nZSA9IGZiLT5jb2xvcl9yYW5nZSA9PSBJR1RfQ09M T1JfWUNCQ1JfRlVMTF9SQU5HRTsKPiA+ID4gIAo+ID4gPiAgCQkJZmItPmdlbV9oYW5kbGUgPSBn ZW1fY3JlYXRlKGZkLCBmYi0+c2l6ZSk7Cj4gPiA+ICAKPiA+ID4gIAkJCWdlbV9zZXRfdGlsaW5n KGZkLCBmYi0+Z2VtX2hhbmRsZSwKPiA+ID4gIAkJCQkgICAgICAgaWd0X2ZiX21vZF90b190aWxp bmcoZmItPnRpbGluZyksCj4gPiA+ICAJCQkJICAgICAgIGZiLT5zdHJpZGVzWzBdKTsKPiA+ID4g LQo+ID4gPiAtCQkJZ2VtX3NldF9kb21haW4oZmQsIGZiLT5nZW1faGFuZGxlLAo+ID4gPiAtCQkJ CSAgICAgICBJOTE1X0dFTV9ET01BSU5fR1RULCBJOTE1X0dFTV9ET01BSU5fR1RUKTsKPiA+ID4g LQo+ID4gPiAtCQkJLyogRW5zdXJlIHRoZSBmcmFtZWJ1ZmZlciBpcyBwcmVhbGxvY2F0ZWQgKi8K PiA+ID4gLQkJCXB0ciA9IGdlbV9tbWFwX19ndHQoZmQsIGZiLT5nZW1faGFuZGxlLAo+ID4gPiAt CQkJCQkgICAgZmItPnNpemUsIFBST1RfUkVBRCB8IFBST1RfV1JJVEUpOwo+ID4gPiAtCQkJaWd0 X2Fzc2VydCgqKHVpbnQzMl90ICopcHRyID09IDApOwo+ID4gPiAtCj4gPiA+IC0JCQlzd2l0Y2gg KGZiLT5kcm1fZm9ybWF0KSB7Cj4gPiA+IC0JCQljYXNlIERSTV9GT1JNQVRfTlYxMjoKPiA+ID4g LQkJCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gPiA+IC0JCQkJICAgICAgIGZ1bGxf cmFuZ2UgPyAweDAwIDogMHgxMCwKPiA+ID4gLQkJCQkgICAgICAgZmItPnN0cmlkZXNbMF0gKiBm Yi0+cGxhbmVfaGVpZ2h0WzBdKTsKPiA+ID4gLQkJCQltZW1zZXQocHRyICsgZmItPm9mZnNldHNb MV0sCj4gPiA+IC0JCQkJICAgICAgIDB4ODAsCj4gPiA+IC0JCQkJICAgICAgIGZiLT5zdHJpZGVz WzFdICogZmItPnBsYW5lX2hlaWdodFsxXSk7Cj4gPiA+IC0JCQkJYnJlYWs7Cj4gPiA+IC0JCQlj YXNlIERSTV9GT1JNQVRfWFlVVjg4ODg6Cj4gPiA+IC0JCQkJd21lbXNldChwdHIgKyBmYi0+b2Zm c2V0c1swXSwgZnVsbF9yYW5nZSA/IDB4MDAwMDgwODAgOiAweDAwMTA4MDgwLAo+ID4gPiAtCQkJ CQlmYi0+c3RyaWRlc1swXSAqIGZiLT5wbGFuZV9oZWlnaHRbMF0gLyBzaXplb2Yod2NoYXJfdCkp Owo+ID4gPiAtCQkJCWJyZWFrOwo+ID4gPiAtCQkJY2FzZSBEUk1fRk9STUFUX1lVWVY6Cj4gPiA+ IC0JCQljYXNlIERSTV9GT1JNQVRfWVZZVToKPiA+ID4gLQkJCQl3bWVtc2V0KHB0ciArIGZiLT5v ZmZzZXRzWzBdLAo+ID4gPiAtCQkJCQlmdWxsX3JhbmdlID8gMHg4MDAwODAwMCA6IDB4ODAxMDgw MTAsCj4gPiA+IC0JCQkJCWZiLT5zdHJpZGVzWzBdICogZmItPnBsYW5lX2hlaWdodFswXSAvIHNp emVvZih3Y2hhcl90KSk7Cj4gPiA+IC0JCQkJYnJlYWs7Cj4gPiA+IC0JCQljYXNlIERSTV9GT1JN QVRfVVlWWToKPiA+ID4gLQkJCWNhc2UgRFJNX0ZPUk1BVF9WWVVZOgo+ID4gPiAtCQkJCXdtZW1z ZXQocHRyICsgZmItPm9mZnNldHNbMF0sCj4gPiA+IC0JCQkJCWZ1bGxfcmFuZ2UgPyAweDAwODAw MDgwIDogMHgxMDgwMTA4MCwKPiA+ID4gLQkJCQkJZmItPnN0cmlkZXNbMF0gKiBmYi0+cGxhbmVf aGVpZ2h0WzBdIC8gc2l6ZW9mKHdjaGFyX3QpKTsKPiA+ID4gLQkJCQlicmVhazsKPiA+ID4gLQkJ CX0KPiA+ID4gLQkJCWdlbV9tdW5tYXAocHRyLCBmYi0+c2l6ZSk7Cj4gPiA+ICsJCQljbGVhcl95 dXZfYnVmZmVyKGZkKTsKPiA+ID4gIAo+ID4gPiAgCQkJcmV0dXJuIGZiLT5nZW1faGFuZGxlOwo+ ID4gPiAgCQl9IGVsc2Ugewo+ID4gLS0gCj4gPiBQYXVsIEtvY2lhbGtvd3NraSwgQm9vdGxpbgo+ ID4gRW1iZWRkZWQgTGludXggYW5kIGtlcm5lbCBlbmdpbmVlcmluZwo+ID4gaHR0cHM6Ly9ib290 bGluLmNvbQotLSAKUGF1bCBLb2NpYWxrb3dza2ksIEJvb3RsaW4KRW1iZWRkZWQgTGludXggYW5k IGtlcm5lbCBlbmdpbmVlcmluZwpodHRwczovL2Jvb3RsaW4uY29tCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwppZ3QtZGV2IG1haWxpbmcgbGlzdAppZ3Qt ZGV2QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2lndC1kZXYK