Re: [PATCH i-g-t v1] tests/intel/kms_joiner: Fix mixed_output subtest skips

[Karthik B S <karthik.b.s@intel.com>]

Hi Santhosh,

On 5/8/2026 9:29 AM, Santhosh Reddy Guddati wrote:
> In the mixed output case, mixed_output[1] is a non-big-joiner output,
> but bigjoiner_mode_found() was unconditionally called for both outputs,
> causing the subtest to skip. Only require a big joiner mode for the
> first output (j=0); the second uses its default mode.
>
> cc: Karthik B.S <karthik.b.s@intel.com>
> cc: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> Signed-off-by: Santhosh Reddy Guddati <santhosh.reddy.guddati@intel.com>
> ---
>   tests/intel/kms_joiner.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_joiner.c b/tests/intel/kms_joiner.c
> index 86226a3ba..20f39ceef 100644
> --- a/tests/intel/kms_joiner.c
> +++ b/tests/intel/kms_joiner.c
> @@ -386,7 +386,7 @@ static void test_invalid_modeset_two_joiner(data_t *data,
>   
>   			output = outputs[j];
>   
> -			if (!force_joiner) {
> +			if (!force_joiner && (!mixed || j == 0)) {

The patch is correct logically and required, but IMHO it would be good 
if we can rename the existing variables to make it more clear from the 
variable name itself.

Thanks and Regards,
Karthik.B.S
>   				igt_require_f(bigjoiner_mode_found(data->drm_fd, output->config.connector, max_dotclock, &mode),
>   							  "No big joiner mode found on output %s\n", output->name);
>   				igt_output_override_mode(output, &mode);