Re: [PATCH i-g-t v4 1/2] tests/intel/xe_fault_injection: Inject errors during xe_guc_mmio_send_recv

[Michal Wajdeczko <michal.wajdeczko@intel.com>]

Hi,

some late comments below:

On 22.01.2025 08:38, Satyanarayana K V P wrote:
> Use the kernel fault injection infrastructure to test error handling
> of xe at probe time when executing xe_guc_mmio_send_recv() so that
> more code paths are tested, such as error handling and unwinding.
> 
> Error can be injected using:
> igt@xe_fault_injection@inject-fault-probe-function-xe_guc_mmio_send_recv
> 
> v2: Sorted the entry xe_guc_mmio_send_recv in inject-fault-probe-function-* list
> 
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Michał Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Francois Dugast <francois.dugast@intel.com>
> Signed-off-by: Satyanarayana K V P <satyanarayana.k.v.p@intel.com>
> Reviewed-by: Francois Dugast <francois.dugast@intel.com>
> ---
>  tests/intel/xe_fault_injection.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/intel/xe_fault_injection.c b/tests/intel/xe_fault_injection.c
> index 7ae941367..3a0e2aa29 100644
> --- a/tests/intel/xe_fault_injection.c
> +++ b/tests/intel/xe_fault_injection.c
> @@ -163,6 +163,7 @@ static void set_retval(const char function_name[], long long retval)
>   * @xe_guc_ads_init:		xe_guc_ads_init
>   * @xe_guc_ct_init:		xe_guc_ct_init
>   * @xe_guc_log_init:		xe_guc_log_init
> + * @xe_guc_mmio_send_recv:     xe_guc_mmio_send_recv

hmm, I know that you are trying to follow existing comment style, but
what is the actual purpose of typing a function name twice here?

and why this sub-test documentation is so separate from the actual place
where this function is used (in igt_main far below) ?

>   * @xe_guc_relay_init:		xe_guc_relay_init
>   * @xe_pm_init_early:		xe_pm_init_early
>   * @xe_sriov_init:		xe_sriov_init
> @@ -294,6 +295,7 @@ igt_main
>  		{ "xe_guc_ads_init" },
>  		{ "xe_guc_ct_init" },
>  		{ "xe_guc_log_init" },
> +		{ "xe_guc_mmio_send_recv" },
>  		{ "xe_guc_relay_init" },
>  		{ "xe_pm_init_early" },
>  		{ "xe_sriov_init" },