From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 425E46F20E for ; Thu, 24 Jan 2019 18:20:29 +0000 (UTC) From: "Souza, Jose" Date: Thu, 24 Jan 2019 18:20:26 +0000 Message-ID: References: <20190123235636.8720-1-jose.souza@intel.com> <20190124063953.GA2011@intel.com> In-Reply-To: <20190124063953.GA2011@intel.com> Content-Language: en-US MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t v4 1/4] test/psr: Skip PSR2 tests when panel resolution is bigger than PSR2 HW supports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============1263651497==" Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Vivi, Rodrigo" , "Pandiyan, Dhinakaran" Cc: "igt-dev@lists.freedesktop.org" List-ID: --===============1263651497== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-C+z2tfEVwad0xNr0Vnbu" --=-C+z2tfEVwad0xNr0Vnbu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-01-23 at 22:39 -0800, Rodrigo Vivi wrote: > On Wed, Jan 23, 2019 at 06:25:07PM -0800, Dhinakaran Pandiyan wrote: > > On Wed, 2019-01-23 at 15:56 -0800, Jos=C3=A9 Roberto de Souza wrote: > > > If resolution that will be used in PSR tests is bigger than the > > > resolution that PSR2 HW supports, PSR2 will not be enabled so > > > those > > > tests should be skiped. Most of eDP panels only supports one > > > resolution that is why we don't even try to use other resolution. > > >=20 > > > BSpec: 7713 > > I don't like the fact that we are re-implementing driver code in > > the > > test to avoid false-positives. We should really replace the panel > > on > > the WHL machine with a panel that is expected to work.=20 > >=20 >=20 > I fully agree. The debugfs should be auto-suficient. >=20 > In the past it was the idea of Source OK. if sink support yes and > source ok > and we tried to enabled but it is not getting active, > than we have a bug somewhere. >=20 > I don't know the current status of the psr debugfs anymore, but > I believe the test case should infer this information from there > somehow instead of re-implement the driver code here. >=20 > > But, as a temporary measure to make CI happy and enable PSR2. >=20 > why is this only affecting PSR2 case? PSR2 has a maximum resolution suported and the only resolution that CI eDP panel supports is bigger than that. >=20 > > Reviewed-by: Dhinakaran Pandiyan > >=20 > > Rodrigo, what's your opinion on this? > >=20 > > -DK > > > Cc: Dhinakaran Pandiyan > > > Cc: Rodrigo Vivi > > > Signed-off-by: Jos=C3=A9 Roberto de Souza > > > --- > > > tests/kms_psr.c | 21 +++++++++++++++++++-- > > > 1 file changed, 19 insertions(+), 2 deletions(-) > > >=20 > > > diff --git a/tests/kms_psr.c b/tests/kms_psr.c > > > index 3e16a6bf..4792e158 100644 > > > --- a/tests/kms_psr.c > > > +++ b/tests/kms_psr.c > > > @@ -445,13 +445,30 @@ int main(int argc, char *argv[]) > > > igt_require_f(sink_support(&data, PSR_MODE_1), > > > "Sink does not support PSR\n"); > > > =20 > > > - data.supports_psr2 =3D sink_support(&data, PSR_MODE_2); > > > - > > > data.bufmgr =3D drm_intel_bufmgr_gem_init(data.drm_fd, > > > 4096); > > > igt_assert(data.bufmgr); > > > drm_intel_bufmgr_gem_enable_reuse(data.bufmgr); > > > =20 > > > display_init(&data); > > > + > > > + data.supports_psr2 =3D sink_support(&data, PSR_MODE_2); > > > + if (data.supports_psr2) { > > > + uint32_t devid =3D > > > intel_get_drm_devid(data.drm_fd); > > > + uint16_t max_h =3D 0, max_v =3D 0; > > > + int gen =3D intel_gen(devid); > > > + > > > + if (gen >=3D 10 || IS_GEMINILAKE(devid)) { > > > + max_h =3D 4096; > > > + max_v =3D 2304; > > > + } else if (gen =3D=3D 9) { > > > + max_h =3D 3640; > > > + max_v =3D 2304; > > > + } > > > + > > > + if (data.mode->hdisplay > max_h || > > > + data.mode->vdisplay > max_v) > > > + data.supports_psr2 =3D false; > > > + } > > > } > > > =20 > > > for (data.op_psr_mode =3D PSR_MODE_1; data.op_psr_mode <=3D > > > PSR_MODE_2; --=-C+z2tfEVwad0xNr0Vnbu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlxKAegACgkQVenbO/mO Wkkwcwf/aXjxaLcgRiPwp8yR5rjXsPvkCL8r2VOqFN0Y3AYUfIOUU31H//9WT/QR 6lFCFG0PrqIDdmlzkecLjxUvgcDVSoSdgh7E52rYL/cBG4ntkCr+KCbgN+VJyDtO GrQbNZa7MHz4j9loa4xYpi8xeYimei5tcvmgeGHW22DdprC55OT5Qb1LX0KkOyXP z43Q5AQX1zheL6HyUjgUDHrEn3IMLCuinT88BCJTnjKpxfLAF+DTB5LQSETG3UB1 7fb05CMJzkuugoxfsLIkAbUmDMxJui0kCofdrmVoQ6AJ4FiDiAlJ9PXbkISkSJjx h/UJkOrDd85vZx1aGimXOWhR00YIMw== =ij6/ -----END PGP SIGNATURE----- --=-C+z2tfEVwad0xNr0Vnbu-- --===============1263651497== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRldiBt YWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg== --===============1263651497==--