From: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>
To: Arkadiusz Hiler <arkadiusz.hiler@intel.com>,
"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t] tests/amdpu: Build amd_bypass test with autotools
Date: Fri, 28 Jun 2019 12:11:46 +0000 [thread overview]
Message-ID: <d443af41-0011-c623-bd16-3e2883868548@amd.com> (raw)
In-Reply-To: <20190628103813.19986-1-arkadiusz.hiler@intel.com>
On 6/28/19 6:38 AM, Arkadiusz Hiler wrote:
> It was added only on the meson side of things.
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
> Fixes: 3c4edeba35ac ("tests/amdgpu: add 8bpc bypass mode test.")
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
I did actually notice this during review but thought that autotools was
on the way to being deprecated so I wasn't sure whether to bring it up
or not.
I guess the pipeline checking the diff answers that question, I'll keep
this in mind for future patches.
Thanks!
Nicholas Kazlauskas
> ---
> tests/Makefile.sources | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/Makefile.sources b/tests/Makefile.sources
> index 027ed82f..250dbd33 100644
> --- a/tests/Makefile.sources
> +++ b/tests/Makefile.sources
> @@ -6,6 +6,7 @@ NOUVEAU_TESTS = \
>
> AMDGPU_TESTS = \
> amdgpu/amd_basic \
> + amdgpu/amd_bypass \
> amdgpu/amd_color \
> amdgpu/amd_cs_nop \
> amdgpu/amd_prime \
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-06-28 12:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 10:38 [igt-dev] [PATCH i-g-t] tests/amdpu: Build amd_bypass test with autotools Arkadiusz Hiler
2019-06-28 11:12 ` Ser, Simon
2019-06-28 11:50 ` Arkadiusz Hiler
2019-06-28 12:11 ` Kazlauskas, Nicholas [this message]
2019-06-28 17:04 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-06-29 0:47 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d443af41-0011-c623-bd16-3e2883868548@amd.com \
--to=nicholas.kazlauskas@amd.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox